Add IPv6 and dual-stack support for SubnetIPReservation#1435
Draft
wenqiq wants to merge 3 commits into
Draft
Conversation
Support VpcConnectivityProfile.Ipv6Blocks in IPBlocksInfo sync Include paths from VpcConnectivityProfile.Ipv6Blocks into the same externalIPBlockPaths set as ExternalIpBlocks during IPBlocksInfo reconciliation. This ensures that external IPv6 IP blocks assigned to a VPC connectivity profile have their CIDRs and IP ranges surfaced in the IPBlocksInfo CR (ExternalIPCIDRs / ExternalIPRanges) without requiring any CRD schema change. Signed-off-by: Wenqi Qiu <wenqi.qiu@broadcom.com>
wenqiq
force-pushed
the
topic/wenqi/SubnetIPReservationIPv6
branch
2 times, most recently
from
13bc3ab to
4ef05d7
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1435 +/- ##
==========================================
- Coverage 77.02% 76.96% -0.07%
==========================================
Files 156 156
Lines 22048 22084 +36
==========================================
+ Hits 16983 16996 +13
+ Misses 3859 3858 -1
- Partials 1206 1230 +24
🚀 New features to boost your workflow:
|
Signed-off-by: Wenqi Qiu <wenqi.qiu@broadcom.com>
wenqiq
force-pushed
the
topic/wenqi/SubnetIPReservationIPv6
branch
from
45b1d35 to
8cce586
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.