Support IPv6 for Subnet/SubnetSet #1437
Open
yanjunz97 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Wenqi Qiu <wenqi.qiu@broadcom.com>
Signed-off-by: Yanjun Zhou <yanjun.zhou@broadcom.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
- Coverage 77.02% 76.98% -0.05%
==========================================
Files 156 156
Lines 22048 22281 +233
==========================================
+ Hits 16983 17153 +170
- Misses 3859 3908 +49
- Partials 1206 1220 +14
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR focus on the happy path for IPv6 support on Subnet/SubnetSet.
It covers the following topics
Testing done:
IPv6 Subnet is not fully support at NSX side so the testing done only covers some simple cases.
Add IPv6 blocks to vpcconnectivityprofile and mock sv ipfamily to DualStack
Created ns-3 and observed the default SubnetSet are IPv4IPv6
Create a IPv6 Subnet
Create a dual stack Subnet
Create a subnet in nsx and shared through vpcenetworkconfiguration
Create a pre-created SubnetSet with IPv6 subnet and IPv4IPv6 Subnet