Support auto-allocate VLAN for SubnetConnectionBindingMap#1445
Draft
wenqiq wants to merge 5 commits into
Draft
Conversation
When spec.vlanTrafficTag is not set, the subnetbinding controller allocates a VLAN from [0, 4094], writes it to spec, and realizes the NSX binding map. Used VLANs are discovered via NSX search on parent Subnet paths so bindings created outside the Supervisor are included. VLAN extension child Subnets prefer spec/status vlanId when it is still free on the target. Signed-off-by: Wenqi Qiu <wenqi.qiu@broadcom.com>
wenqiq
force-pushed
the
topic/wenqi/VLAN-auto-allocation
branch
from
018d05f to
3443291
Compare
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (12.03%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1445 +/- ##
==========================================
+ Coverage 77.03% 77.68% +0.64%
==========================================
Files 156 186 +30
Lines 22221 24483 +2262
==========================================
+ Hits 17118 19019 +1901
- Misses 3891 4184 +293
- Partials 1212 1280 +68
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When spec.vlanTrafficTag is not set, the subnetbinding controller allocates a VLAN from [0, 4094], writes it to spec, and realizes the NSX binding map. Used VLANs are discovered via NSX search on parent Subnet paths so bindings created outside the Supervisor are included. VLAN extension child Subnets prefer spec/status vlanId when it is still free on the target.