Skip to content

Commit d80e419

Browse files
committed
change
1 parent 0876913 commit d80e419

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

pkg/command/plugin.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,6 @@ func newInstallPluginCmd() *cobra.Command {
257257
return err
258258
}
259259
err = pluginmanager.InstallPluginsFromLocalSource(pluginName, version, getTarget(), local, false)
260-
pluginmanager.StopSpinner()
261260
if err != nil {
262261
return err
263262
}
@@ -280,7 +279,6 @@ func newInstallPluginCmd() *cobra.Command {
280279

281280
pluginVersion := version
282281
err = pluginmanager.InstallStandalonePlugin(pluginName, pluginVersion, getTarget())
283-
pluginmanager.StopSpinner()
284282
if err != nil {
285283
return err
286284
}
@@ -343,6 +341,7 @@ func newUpgradePluginCmd() *cobra.Command {
343341

344342
// With the Central Repository feature we can simply request to install
345343
// the recommendedVersion.
344+
pluginmanager.SetTotalPluginsToInstall(1)
346345
err = pluginmanager.UpgradePlugin(pluginName, cli.VersionLatest, getTarget())
347346
if err != nil {
348347
return err

pkg/pluginmanager/manager.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1182,6 +1182,7 @@ func InstallPluginsFromLocalSource(pluginName, version string, target configtype
11821182
return errors.Errorf("unable to find plugin '%v' matching version '%v'", pluginName, version)
11831183
}
11841184

1185+
defer StopSpinner()
11851186
if len(matchedPlugins) == 1 {
11861187
return installOrUpgradePlugin(&matchedPlugins[0], version, installTestPlugin)
11871188
}

0 commit comments

Comments
 (0)