pluginGroup update

Author: chandrareddyp

pkg/pluginmanager/manager.go

@@ -611,24 +611,30 @@ func InstallPluginsFromGroup(pluginName, groupIDAndVersion string, options ...Pl
 // InstallPluginsFromGivenPluginGroup installs either the specified plugin or all plugins from given plugin group plugins.
 func InstallPluginsFromGivenPluginGroup(pluginName, groupIDAndVersion string, pg *plugininventory.PluginGroup) (string, error) {
 	numErrors := 0
-	numInstalled := 0
 	mandatoryPluginsExist := false
 	pluginExist := false
+	pluginsInstalled = 0
+
+	pluginsToInstall := make([]*plugininventory.PluginGroupPluginEntry, 0)
 	for _, plugin := range pg.Versions[pg.RecommendedVersion] {
 		if pluginName == cli.AllPlugins || pluginName == plugin.Name {
 			pluginExist = true
 			if plugin.Mandatory {
 				mandatoryPluginsExist = true
-				err := InstallStandalonePlugin(plugin.Name, plugin.Version, plugin.Target)
-				if err != nil {
-					numErrors++
-					log.Warningf("unable to install plugin '%s': %v", plugin.Name, err.Error())
-				} else {
-					numInstalled++
-				}
+				pluginsToInstall = append(pluginsToInstall, plugin) // Add mandatory plugin to the slice
 			}
 		}
 	}
+	totalPluginsToInstall = len(pluginsToInstall)
+	for _, plugin := range pluginsToInstall {
+		err := InstallStandalonePlugin(plugin.Name, plugin.Version, plugin.Target)
+		if err != nil {
+			numErrors++
+			log.Warningf("unable to install plugin '%s': %v", plugin.Name, err.Error())
+		} else {
+			pluginsInstalled++
+		}
+	}
 
 	if !pluginExist {
 		return groupIDAndVersion, fmt.Errorf("plugin '%s' is not part of the group '%s'", pluginName, groupIDAndVersion)
@@ -645,7 +651,7 @@ func InstallPluginsFromGivenPluginGroup(pluginName, groupIDAndVersion string, pg
 		return groupIDAndVersion, fmt.Errorf("could not install %d plugin(s) from group '%s'", numErrors, groupIDAndVersion)
 	}
 
-	if numInstalled == 0 {
+	if pluginsInstalled == 0 {
 		return groupIDAndVersion, fmt.Errorf("plugin '%s' is not part of the group '%s'", pluginName, groupIDAndVersion)
 	}
 
@@ -749,6 +755,7 @@ func installOrUpgradePlugin(p *discovery.Discovered, version string, installTest
 	installingMsg, _, errMsg := getPluginInstallationMessage(p, version, plugin != nil, isPluginAlreadyInstalled)
 
 	installingMsg = fmt.Sprintf("[%v/%v] %v", pluginsInstalled, totalPluginsToInstall, installingMsg)
+	errMsg = fmt.Sprintf("[%v/%v] %v", pluginsInstalled, totalPluginsToInstall, errMsg)
 
 	var spinner component.OutputWriterSpinner
 
@@ -1191,7 +1198,6 @@ func InstallDiscoveredContextPlugins(plugins []discovery.Discovered) error {
 	if len(pluginsToInstall) == 0 {
 		log.Info("All required plugins are already installed and up-to-date")
 	} else if pluginsInstalled == totalPluginsToInstall {
-
 		log.Infof("Successfully installed all required %v plugins", pluginsInstalled)
 	} else {
 		log.Infof("Successfully installed %v of %v required plugins", pluginsInstalled, totalPluginsToInstall)