🐛 fix(diskpromo): retry PromoteDisks on transient vSphere errors#1612
Open
zhangheliu wants to merge 1 commit into
Open
Conversation
Transient faults such as ConcurrentAccess indicate a competing vSphere operation was in flight; they are self-resolving and do not require a permanent failure response. Previously, a failed PromoteDisks_Task caused the reconciler to return nil without requeueing, leaving the VM stuck until the task expired from vSphere's RecentTask list (~10 minutes). This change detects transient errors via fault.IsTransientError and continues the RecentTask loop instead of returning, allowing the next reconcile cycle to issue a fresh PromoteDisks_Task immediately. A dedicated condition reason (DiskPromotionTaskTransientError) is introduced to surface the transient-retry state to users. Bumps govmomi to v0.55.0-alpha.0.0.20260518191903-48ab34adb211 to include vmware/govmomi#4016, which classifies ConcurrentAccess as a transient error in fault.IsTransientError.
zhangheliu
force-pushed
the
topic/zhangheliu/vmsvc-3646-fix-diskpromo-transient-error
branch
from
282afe0 to
fe8e5a9
Compare
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
When
PromoteDisks_Taskfails with a transient vSphere fault (e.g.ConcurrentAccess), the competing operation is self-resolving — no operator action is required. Previously the reconciler returnednilwithout requeueing, leaving the VM stuck until the failed task expired from vSphere'sRecentTasklist (~10 minutes).This PR detects transient errors via
fault.IsTransientErrorandcontinues theRecentTaskloop instead of returning, allowing the next reconcile cycle to issue a freshPromoteDisks_Taskimmediately. The existing loop invariants ensure no duplicate tasks are created (see inline code comments for details).A dedicated condition reason
DiskPromotionTaskTransientErroris introduced to surface the transient-retry state to users.Bumps
govmomitov0.55.0-alpha.0.0.20260518191903-48ab34adb211to include vmware/govmomi#4016, which classifiesConcurrentAccessas a transient error infault.IsTransientError.Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
The
govmomibump uses a pseudo-version referencing the commit that merged PR #4016 togovmomimain. Once an officialgovmomitag is cut that includes this fix, this can be updated to the tagged release.Please add a release note if necessary: