fix: omit comparison to bool constant

tenthirtyam · lbajolet-hashicorp · commit 58d9b5591c8b · 2024-10-16T15:52:47.000-04:00
Omit comparison to bool constant.

Signed-off-by: Ryan Johnson &lt;ryan.johnson@broadcom.com&gt;
diff --git a/builder/vsphere/supervisor/step_import_image.go b/builder/vsphere/supervisor/step_import_image.go
@@ -163,7 +163,7 @@ func (s *StepImportImage) validate(ctx context.Context, logger *PackerLogger) er
 }
 
 func (s *StepImportImage) Cleanup(state multistep.StateBag) {
-	if v, ok := state.GetOk(StateKeyImageImportRequestCreated); !ok || v.(bool) == false {
+	if v, ok := state.GetOk(StateKeyImageImportRequestCreated); !ok || !v.(bool) {
 		// Either the image import step was skipped or the object was not created successfully.
 		// Skip deleting the ContentLibraryItemImportRequest object.
 		return

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ func (s StepImportImage) validate(ctx context.Context, logger PackerLogger) er`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`func (s *StepImportImage) Cleanup(state multistep.StateBag) {`
`166`		`- if v, ok := state.GetOk(StateKeyImageImportRequestCreated); !ok \|\| v.(bool) == false {`
	`166`	`+ if v, ok := state.GetOk(StateKeyImageImportRequestCreated); !ok \|\| !v.(bool) {`
`167`	`167`	`// Either the image import step was skipped or the object was not created successfully.`
`168`	`168`	`// Skip deleting the ContentLibraryItemImportRequest object.`
`169`	`169`	`return`