chore: improve test error messages (#705)

tenthirtyam · web-flow · commit 85aa67876b30 · 2026-05-15T09:39:14.000-04:00
Replaced generic formatted messages that referenced the res variable with explicit messages like "expected resource pool, but returned nil" to make test failures easier to understand.

Signed-off-by: Ryan Johnson &lt;ryan.johnson@broadcom.com&gt;
diff --git a/builder/vsphere/driver/resource_pool_test.go b/builder/vsphere/driver/resource_pool_test.go
@@ -100,7 +100,7 @@ func TestVCenterDriver_FindResourcePoolStandaloneESX(t *testing.T) {
 		t.Fatalf("unexpected error: '%s'", err)
 	}
 	if res == nil {
-		t.Fatalf("unexpected result: expected '%v', but returned 'nil'", res)
+		t.Fatalf("unexpected result: expected resource pool, but returned nil")
 	}
 	expectedResourcePool := "Resources"
 	if res.pool.Name() != expectedResourcePool {
@@ -113,7 +113,7 @@ func TestVCenterDriver_FindResourcePoolStandaloneESX(t *testing.T) {
 		t.Fatalf("unexpected error: '%s'", err)
 	}
 	if res == nil {
-		t.Fatalf("unexpected result: expected '%v', but returned 'nil'", res)
+		t.Fatalf("unexpected result: expected non-nil resource pool, but returned nil")
 	}
 	if res.pool.Name() != expectedResourcePool {
 		t.Fatalf("unexpected result: expected '%s', but returned '%s'", expectedResourcePool, res.pool.Name())

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ func TestVCenterDriver_FindResourcePoolStandaloneESX(t *testing.T) {`
`100`	`100`	`t.Fatalf("unexpected error: '%s'", err)`
`101`	`101`	`}`
`102`	`102`	`if res == nil {`
`103`		`- t.Fatalf("unexpected result: expected '%v', but returned 'nil'", res)`
	`103`	`+ t.Fatalf("unexpected result: expected resource pool, but returned nil")`
`104`	`104`	`}`
`105`	`105`	`expectedResourcePool := "Resources"`
`106`	`106`	`if res.pool.Name() != expectedResourcePool {`
`@@ -113,7 +113,7 @@ func TestVCenterDriver_FindResourcePoolStandaloneESX(t *testing.T) {`
`113`	`113`	`t.Fatalf("unexpected error: '%s'", err)`
`114`	`114`	`}`
`115`	`115`	`if res == nil {`
`116`		`- t.Fatalf("unexpected result: expected '%v', but returned 'nil'", res)`
	`116`	`+ t.Fatalf("unexpected result: expected non-nil resource pool, but returned nil")`
`117`	`117`	`}`
`118`	`118`	`if res.pool.Name() != expectedResourcePool {`
`119`	`119`	`t.Fatalf("unexpected result: expected '%s', but returned '%s'", expectedResourcePool, res.pool.Name())`