Skip to content

Commit ea541e1

Browse files
committed
Squashed commit of the following:
commit 94d217c Author: Ryan Johnson <ryan.johnson@broadcom.com> Date: Mon Feb 23 22:02:37 2026 -0500 docs: fix typos and grammer (#667) Addressed spelling, grammar, and phrasing. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com> commit 09e41b6 Author: Ryan Johnson <ryan.johnson@broadcom.com> Date: Mon Feb 23 22:02:02 2026 -0500 chore: remove `.go-version` (#666) Removed the`.go-version` now that all workflows that use `actions/setup-go` now get the version from the module in `go.mod`. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com> commit 2c7c9c5 Author: Ryan Johnson <ryan@tenthirtyam.org> Date: Sun Feb 22 12:09:06 2026 -0500 docs: update examples url (#664) Replaced references to `github.com/vmware-samples/packer-examples-for-vsphere` with `github.com/vmware/packer-examples-for-vsphere`. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org> commit 2c771b3 Author: Ryan Johnson <ryan@tenthirtyam.org> Date: Sun Feb 22 12:01:24 2026 -0500 docs: update `README.md` (#663) Update `README.md`. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org> commit d17cc76 Author: Ryan Johnson <ryan@tenthirtyam.org> Date: Sun Feb 22 11:37:43 2026 -0500 chore(gh): update release workflow tag pattern (#662) Replaced broad `v*` tag filter with a more specific pattern: `v*.*.*` to match stable SemVer releases (e.g. `v2.2.0`) and pre-releases (e.g. `v2.2.0-beta`, `v2.2.0-rc.1`). Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org> commit 6632d05 Author: Ryan Johnson <ryan.johnson@broadcom.com> Date: Sat Feb 21 12:14:40 2026 -0500 chore: update `CODEOWNERS` (#661) Update `CODEOWNERS`. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org> commit 224d5a3 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Feb 20 10:16:58 2026 -0500 chore(deps): bump actions/stale from 10.1.1 to 10.2.0 (#660) Bumps [actions/stale](https://github.com/actions/stale) from 10.1.1 to 10.2.0. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@9971854...b5d41d4) --- updated-dependencies: - dependency-name: actions/stale dependency-version: 10.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit dee83a3 Author: Ryan Johnson <ryan.johnson@broadcom.com> Date: Fri Feb 20 08:07:54 2026 -0500 docs: update `CONTRIBUTING.md` (#658) Revised the `CONTRIBUTING.md`. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com> commit 8587200 Author: Ryan Johnson <ryan.johnson@broadcom.com> Date: Wed Feb 18 12:56:13 2026 -0500 chore(dev): prepare development cycle (#656) Prepare the plugin for the 2.2.0 development cycle and pre-release builds. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
1 parent ec3d62d commit ea541e1

File tree

29 files changed

+199
-180
lines changed

29 files changed

+199
-180
lines changed
File renamed without changes.

.github/CONTRIBUTING.md

Lines changed: 86 additions & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -1,71 +1,88 @@
11
# Contributing Guidelines
22

3-
Thank you for your interest in contributing to our project. Whether it's a bug
4-
report, new feature, correction, or additional documentation, we greatly value
5-
feedback and contributions from our community.
6-
7-
Please read through this document before submitting any issues or pull requests
8-
to ensure we have all the necessary information to effectively respond to your
9-
bug report or contribution.
10-
11-
## Reporting Bugs and Suggesting Enhancements
12-
13-
We welcome you to use the [GitHub issues][gh-issues] to report bugs or suggest
14-
enhancements.
15-
16-
When filing an issue, please check existing open, or recently closed, issues to
17-
make sure someone else hasn't already reported.
18-
19-
Please try to include as much information as you can using the issue form.
20-
Details like these are incredibly useful:
21-
22-
- A reproducible test case or series of steps.
23-
- Any modifications you've made relevant to the bug.
24-
- Anything unusual about your environment or deployment.
25-
26-
## Contributing via Pull Requests
27-
28-
Contributions using pull requests are appreciated.
29-
30-
**Before** sending us a pull request, please ensure that:
31-
32-
1. You [open a discussion][gh-discussions] to discuss any significant work with
33-
the maintainer(s).
34-
2. You [open an issue][gh-issues] and link your pull request to the issue for
35-
context.
36-
3. You are working against the latest source on the `main` branch.
37-
4. You check existing open, and recently merged, pull requests to make sure
38-
someone else hasn't already addressed the problem.
39-
40-
To open a pull request, please:
41-
42-
1. Fork the repository.
43-
2. Modify the source; please focus on the **specific** change you are
44-
contributing.
45-
3. Ensure local tests pass.
46-
4. Update the documentation, if required.
47-
5. Sign-off and commit to your fork
48-
[using clear commit messages][git-commit]. Please use
49-
[Conventional Commits][conventional-commits].
50-
6. Open a pull request, answering any default questions in the pull request.
51-
7. Pay attention to any automated failures reported in the pull request, and
52-
stay involved in the conversation.
53-
54-
GitHub provides additional documentation on [forking a repository][gh-forks] and
55-
[creating a pull request][gh-pull-requests].
3+
We greatly value feedback and contributions from our community.
4+
5+
Please review this document before submitting any issues or pull requests to ensure we
6+
have all the necessary information to effectively collaborate on your contribution.
7+
8+
> [!TIP]
9+
If you need help or have questions about using the plugin, please refer to the
10+
[documentation](https://github.com/vmware/packer-plugin-vsphere/tree/main/docs) or open
11+
a [discussion][gh-discussions].
12+
13+
## Issues
14+
15+
Use [GitHub issues][gh-issues] to report bugs or suggest enhancements using the
16+
following guidelines.
17+
18+
> [!WARNING]
19+
> Issues that do not follow the guidelines may be closed by the maintainers without
20+
> further investigation.
21+
22+
Before opening an issue, please [search existing issues](https://github.com/vmware/packer-plugin-vsphere/issues?q=is%3Aissue+is%3Aopen+label%3Abug)
23+
to avoid duplicates.
24+
25+
When opening an issue, use the provided issue form to ensure that you provide all the
26+
necessary details. These details are important for maintainers to understand and
27+
reproduce the issue.
28+
29+
> [!IMPORTANT]
30+
> - Ensure that you are using a recent version of the plugin.
31+
> - Ensure that you are using a supported version of VMware vSphere. The plugin supports versions in accordance with the [Broadcom Product Lifecycle][product-lifecycle].
32+
33+
> [!TIP]
34+
> - Learn about [formatting code on GitHub](https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#quoting-code).
35+
> - Learn about [referencing issues](https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#referencing-issues-and-pull-requests).
36+
> - Learn about [creating a GitHub Gist](https://docs.github.com/en/get-started/writing-on-github/editing-and-sharing-content-with-gists/creating-gists).
37+
38+
## Pull Requests
39+
40+
Use GitHub pull requests to propose changes to the codebase using the following guidelines.
41+
42+
> [!WARNING]
43+
> Pull requests that do not follow the guidelines may be closed by the maintainers
44+
> without further review.
45+
46+
**Before** submitting a pull request, ensure that:
47+
48+
1. You have [opened a discussion][gh-discussions] to discuss any **significant** work with
49+
the maintainer(s). This ensures that your contribution is aligned with the
50+
project's direction and avoids unnecessary work.
51+
2. You have identified or [open an issue][gh-issues]. This ensures that your contribution
52+
focuses on a specific topic and avoids duplicating effort.
53+
3. You have forked the repository. Refer to the [GitHub documentation][gh-forks] for help.
54+
3. You are working against the latest source on the `main` branch. You may need to
55+
rebase your branch against the latest `main` branch.
56+
4. You have created a topic branch based on `main`. Do not work directly on the `main` branch.
57+
5. You have modified the source based on logical units of work. Focus on the specific change
58+
you are contributing. Pull requests that contain multiple unrelated changes will be
59+
rejected.
60+
4. You have followed the existing style and conventions of the project.
61+
5. You have added tests for your changes.
62+
5. You have generated the updated documentation and associated assets by running `make generate`.
63+
5. You have tested building the plugin by running `make build`.
64+
7. You have tested your changes with a local build of the plugin by running `make dev`.
65+
9. You have verified all new and existing tests are passing by running `make test`.
66+
10. You have used [Conventional Commits][conventional-commits] format for commit messages.
67+
11. You have signed-off and committed your changes [using clear commit messages][git-commit].
68+
69+
When opening a pull request, ensure that:
70+
71+
1. You title your pull request using the [Conventional Commits][conventional-commits] format.
72+
2. You provide a detailed description of the changes in the pull request template.
73+
2. You open any work-in-progress pull requests as a draft.
74+
3. You mark the pull request as ready for review when you are ready for it to be reviewed.
75+
4. You follow the status checks for the pull request to ensure that all checks are passing.
76+
5. You stay involved in the conversation with the maintainers to ensure that your contribution
77+
can be reviewed.
78+
79+
> [!TIP]
80+
> If you have any questions about the contribution process, open a [discussion][gh-discussions].
5681
5782
### Contributor Flow
5883

5984
This is an outline of the contributor workflow:
6085

61-
- Create a topic branch from where you want to base your work.
62-
- Make commits of logical units.
63-
- Make sure your commit messages are
64-
[in the proper format][conventional-commits].
65-
- Push your changes to the topic branch in your fork.
66-
- Submit a pull request. If the pull request is a work in progress, please open
67-
as draft.
68-
6986
Example:
7087

7188
```shell
@@ -82,7 +99,7 @@ git push origin feat/add-x
8299

83100
### Formatting Commit Messages
84101

85-
We follow the conventions on [How to Write a Git Commit Message][git-commit] and
102+
Follow the conventions on [How to Write a Git Commit Message][git-commit] and use
86103
[Conventional Commits][conventional-commits].
87104

88105
Be sure to include any related GitHub issue references in the commit message.
@@ -99,7 +116,7 @@ Signed-off-by: Jane Doe <jdoe@example.com>
99116
Ref: #123
100117
```
101118

102-
### Staying In Sync With Upstream
119+
### Stay In Sync With Upstream
103120

104121
When your branch gets out of sync with the `upstream/main` branch, use the
105122
following to update:
@@ -130,22 +147,20 @@ If you need to squash changes into an earlier commit, you can use:
130147
```shell
131148
git add .
132149
git commit --fixup <commit>
133-
git rebase --interactive --autosquash upsstream/main
150+
git rebase --interactive --autosquash upstream/main
134151
git push --force-with-lease origin feat/add-x
135152
```
136153

137-
Be sure to add a comment to the pull request indicating your new changes are
138-
ready to review, as GitHub does not generate a notification when you `git push`.
139-
140-
## Finding Contributions to Work On
154+
When resolving review comments, mark the conversation as resolved and note the commit
155+
SHA that addresses the review comment. This helps maintainers verify the issue has been
156+
resolved.
141157

142-
Looking at the existing issues is a great way to find something to contribute
143-
on. If you have an idea you'd like to discuss,
144-
[open a discussion][gh-discussions].
158+
Request a review from the maintainers when you are ready for a follow-up review.
145159

146160
[conventional-commits]: https://conventionalcommits.org
147161
[gh-discussions]: https://github.com/vmware/packer-plugin-vsphere/discussions
148162
[gh-forks]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo
149163
[gh-issues]: https://github.com/vmware/packer-plugin-vsphere/issues
150164
[gh-pull-requests]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request
151165
[git-commit]: https://cbea.ms/git-commit
166+
[product-lifecycle]: https://support.broadcom.com/group/ecx/productlifecycle

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ name: Release
66
on:
77
push:
88
tags:
9-
- 'v*'
9+
- 'v*.*.*' # Match release tags (stable and pre-releases), e.g. v1.2.3, v1.2.3-rc.1
1010

1111
permissions:
1212
contents: write

.github/workflows/stale.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
issues: write
1616
pull-requests: write
1717
steps:
18-
- uses: actions/stale@997185467fa4f803885201cee163a9f38240193d # v10.1.1
18+
- uses: actions/stale@b5d41d4e1d5dceea10e7104786b73624c18a190f # v10.2.0
1919
with:
2020
repo-token: ${{ secrets.GITHUB_TOKEN }}
2121
days-before-stale: 360

.go-version

Lines changed: 0 additions & 1 deletion
This file was deleted.

.web-docs/components/builder/vsphere-clone/README.md

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ JSON Example:
347347

348348
<!-- Code generated from the comments of the ConfigParamsConfig struct in builder/vsphere/common/step_config_params.go; DO NOT EDIT MANUALLY -->
349349

350-
- `configuration_parameters` (map[string]string) - A map of key-value pairs to sent to the [`extraConfig`](https://dp-downloads.broadcom.com/api-content/apis/API_VWSA_001/8.0U3/html/ReferenceGuides/vim.vm.ConfigSpec.html#extraConfig).
350+
- `configuration_parameters` (map[string]string) - A map of key-value pairs to send to the [`extraConfig`](https://dp-downloads.broadcom.com/api-content/apis/API_VWSA_001/8.0U3/html/ReferenceGuides/vim.vm.ConfigSpec.html#extraConfig).
351351
in the vSphere API's `VirtualMachineConfigSpec`.
352352

353353
HCL Example:
@@ -371,7 +371,7 @@ JSON Example:
371371
```
372372

373373
~> **Note:** Configuration keys that would conflict with parameters that
374-
are explicitly configurable through other fields in the `ConfigSpec`` object
374+
are explicitly configurable through other fields in the `ConfigSpec` object
375375
are silently ignored. Refer to the [`VirtualMachineConfigSpec`](https://dp-downloads.broadcom.com/api-content/apis/API_VWSA_001/8.0U3/html/ReferenceGuides/vim.vm.ConfigSpec.html)
376376
in the vSphere API documentation.
377377

@@ -965,10 +965,10 @@ wget http://{{ .HTTPIP }}:{{ .HTTPPort }}/foo/bar/preseed.cfg
965965
- `floppy_dirs` ([]string) - A list of directories to copy files from.
966966

967967
- `floppy_content` (map[string]string) - Key/Values to add to the floppy disk. The keys represent the paths, and
968-
the values contents. It can be used alongside `floppy_files` or
968+
the value contents. It can be used alongside `floppy_files` or
969969
`floppy_dirs`, which is useful to add large files without loading them
970-
into memory. If any paths are specified by both, the contents in
971-
`floppy_content` will take precedence.
970+
into memory. If both specify a path, the contents in `floppy_content` will take
971+
precedence.
972972

973973
HCL Example:
974974

@@ -980,8 +980,8 @@ wget http://{{ .HTTPIP }}:{{ .HTTPPort }}/foo/bar/preseed.cfg
980980
```
981981

982982
- `floppy_label` (string) - The label to use for the floppy disk that is attached when the virtual
983-
machine is booted. This is most useful for cloud-init, Kickstart or other
984-
early initialization tools, which can benefit from labelled floppy disks.
983+
machine is booted. This is most useful for cloud-init, Kickstart, or other
984+
early initialization tools, which can benefit from labeled floppy disks.
985985
By default, the floppy label will be 'packer'.
986986

987987
<!-- End of code generated from the comments of the FloppyConfig struct in builder/vsphere/common/step_add_floppy.go; -->
@@ -993,8 +993,7 @@ wget http://{{ .HTTPIP }}:{{ .HTTPPort }}/foo/bar/preseed.cfg
993993

994994
<!-- Code generated from the comments of the ConnectConfig struct in builder/vsphere/common/step_connect.go; DO NOT EDIT MANUALLY -->
995995

996-
- `vcenter_server` (string) - The fully qualified domain name or IP address of the vCenter instance
997-
instance.
996+
- `vcenter_server` (string) - The fully qualified domain name or IP address of the vCenter instance.
998997

999998
- `username` (string) - The username to authenticate with the vCenter instance.
1000999

.web-docs/components/builder/vsphere-iso/README.md

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ their respective End of General Support dates. For detailed information, refer t
1414
- Basic examples are available in the [examples](https://github.com/vmware/packer-plugin-vsphere/tree/main/examples/)
1515
directory of the GitHub repository.
1616

17-
- Additional examples are available in the [`vmware-samples/packer-examples-for-vsphere`](https://github.com/vmware-samples/packer-examples-for-vsphere)
17+
- Additional examples are available in the [`vmware/packer-examples-for-vsphere`](https://github.com/vmware/packer-examples-for-vsphere)
1818
GitHub repository maintained by VMware by Broadcom.
1919

2020
## Configuration Reference
@@ -107,8 +107,7 @@ wget http://{{ .HTTPIP }}:{{ .HTTPPort }}/foo/bar/preseed.cfg
107107

108108
<!-- Code generated from the comments of the ConnectConfig struct in builder/vsphere/common/step_connect.go; DO NOT EDIT MANUALLY -->
109109

110-
- `vcenter_server` (string) - The fully qualified domain name or IP address of the vCenter instance
111-
instance.
110+
- `vcenter_server` (string) - The fully qualified domain name or IP address of the vCenter instance.
112111

113112
- `username` (string) - The username to authenticate with the vCenter instance.
114113

@@ -182,7 +181,7 @@ wget http://{{ .HTTPIP }}:{{ .HTTPPort }}/foo/bar/preseed.cfg
182181

183182
- `convert_to_template` (bool) - Convert the virtual machine to a template after the build is complete.
184183
Defaults to `false`.
185-
If set to `true`, the virtual machine can not be imported into a content library.
184+
If set to `true`, the virtual machine cannot be imported into a content library.
186185

187186
- `export` (\*common.ExportConfig) - The configuration for exporting the virtual machine to an OVF.
188187
The virtual machine is not exported if [export configuration](#export-configuration) is not specified.
@@ -652,10 +651,10 @@ boot time.
652651
- `floppy_dirs` ([]string) - A list of directories to copy files from.
653652

654653
- `floppy_content` (map[string]string) - Key/Values to add to the floppy disk. The keys represent the paths, and
655-
the values contents. It can be used alongside `floppy_files` or
654+
the value contents. It can be used alongside `floppy_files` or
656655
`floppy_dirs`, which is useful to add large files without loading them
657-
into memory. If any paths are specified by both, the contents in
658-
`floppy_content` will take precedence.
656+
into memory. If both specify a path, the contents in `floppy_content` will take
657+
precedence.
659658

660659
HCL Example:
661660

@@ -667,8 +666,8 @@ boot time.
667666
```
668667

669668
- `floppy_label` (string) - The label to use for the floppy disk that is attached when the virtual
670-
machine is booted. This is most useful for cloud-init, Kickstart or other
671-
early initialization tools, which can benefit from labelled floppy disks.
669+
machine is booted. This is most useful for cloud-init, Kickstart, or other
670+
early initialization tools, which can benefit from labeled floppy disks.
672671
By default, the floppy label will be 'packer'.
673672

674673
<!-- End of code generated from the comments of the FloppyConfig struct in builder/vsphere/common/step_add_floppy.go; -->
@@ -1617,7 +1616,7 @@ JSON Example:
16171616

16181617
<!-- Code generated from the comments of the ConfigParamsConfig struct in builder/vsphere/common/step_config_params.go; DO NOT EDIT MANUALLY -->
16191618

1620-
- `configuration_parameters` (map[string]string) - A map of key-value pairs to sent to the [`extraConfig`](https://dp-downloads.broadcom.com/api-content/apis/API_VWSA_001/8.0U3/html/ReferenceGuides/vim.vm.ConfigSpec.html#extraConfig).
1619+
- `configuration_parameters` (map[string]string) - A map of key-value pairs to send to the [`extraConfig`](https://dp-downloads.broadcom.com/api-content/apis/API_VWSA_001/8.0U3/html/ReferenceGuides/vim.vm.ConfigSpec.html#extraConfig).
16211620
in the vSphere API's `VirtualMachineConfigSpec`.
16221621

16231622
HCL Example:
@@ -1641,7 +1640,7 @@ JSON Example:
16411640
```
16421641

16431642
~> **Note:** Configuration keys that would conflict with parameters that
1644-
are explicitly configurable through other fields in the `ConfigSpec`` object
1643+
are explicitly configurable through other fields in the `ConfigSpec` object
16451644
are silently ignored. Refer to the [`VirtualMachineConfigSpec`](https://dp-downloads.broadcom.com/api-content/apis/API_VWSA_001/8.0U3/html/ReferenceGuides/vim.vm.ConfigSpec.html)
16461645
in the vSphere API documentation.
16471646

.web-docs/components/data-source/virtualmachine/README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@ virtual machine can be used in the vSphere Clone builder to select a template.
7676

7777
<!-- Code generated from the comments of the ConnectConfig struct in builder/vsphere/common/step_connect.go; DO NOT EDIT MANUALLY -->
7878

79-
- `vcenter_server` (string) - The fully qualified domain name or IP address of the vCenter instance
80-
instance.
79+
- `vcenter_server` (string) - The fully qualified domain name or IP address of the vCenter instance.
8180

8281
- `username` (string) - The username to authenticate with the vCenter instance.
8382

.web-docs/components/post-processor/vsphere/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ The following configuration options are available for the post-processor.
8585
same as the source virtual machine's.
8686

8787
This option is useful when deploying to vCenter instance or an ESX host whose
88-
version is different than the one used to create the artifact.
88+
version is different from the one used to create the artifact.
8989

9090
Refer to [KB 315655](https://knowledge.broadcom.com/external/article?articleNumber=315655)
9191
for more information on supported virtual hardware versions.

CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
* @tenthirtyam @hashicorp/packer
1+
* @vmware/packer-plugin-vsphere-maintainers

0 commit comments

Comments
 (0)