refactor: update post-processor regex, backoff, and msg#708
Merged
tenthirtyam merged 1 commit intoMay 15, 2026
Conversation
- Adjust `hostnameRegex` to enforce full-string matching by adding grouping and anchors, fixing a validation bug. - Extract backoff configuration into a variable and use Exponential backoff (InitialBackoff=200ms, MaxBackoff=30s, Multiplier=2) for retries. - Improve error handling by wrapping the underlying error with %w and returning an explicit error when the remote command exits with a non-zero status. These changes improve retry behavior and provide clearer diagnostics for uploads. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
github-actions
Bot
added
needs-review
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hostnameRegexto enforce full-string matching by adding grouping and anchors, fixing a validation bug.These changes improve retry behavior and provide clearer diagnostics for uploads.
Type
fix: Bug Fixfeat: Feature or Enhancementdocs: Documentationrefactor: Refactoringchore: Build, Dependencies, Workflows, etc.other: Other (Please describe.)Breaking Changes?
Tests
Output:
Documentation
Issue References
Release Note
Additional Information