Skip to content

refactor: update post-processor regex, backoff, and msg #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tenthirtyam merged 1 commit into from
May 15, 2026
+12 −4
Merged

refactor: update post-processor regex, backoff, and msg #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions post-processor/vsphere/post-processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ var (
// Regular expression to validate an RFC1035 hostname from an FQDN or simple
// hostname. For example "esxi-01". Requires proper DNS setup and/or correct DNS
// search domain setting.
hostnameRegex = regexp.MustCompile(`^[[:alnum:]][[:alnum:]\-]{0,61}[[:alnum:]]|[[:alpha:]]$`)
hostnameRegex = regexp.MustCompile(`^([[:alnum:]][[:alnum:]\-]{0,61}[[:alnum:]]|[[:alpha:]])$`)

// Simple regular expression to validate IPv4 values.
// For example "192.168.168.1".
Expand Down Expand Up @@ -310,17 +310,25 @@ func (p *PostProcessor) PostProcess(ctx context.Context, ui packersdk.Ui, artifa
ExecuteCommand: commandAndArgs,
}
flattenedCmd := strings.Join(commandAndArgs, " ")
backoff := &retry.Backoff{
InitialBackoff: 200 * time.Millisecond,
MaxBackoff: 30 * time.Second,
Multiplier: 2,
}
err = retry.Config{
Tries: p.config.MaxRetries,
ShouldRetry: func(err error) bool {
return err != nil
},
RetryDelay: (&retry.Backoff{InitialBackoff: 200 * time.Millisecond, MaxBackoff: 30 * time.Second, Multiplier: 2}).Exponential,
RetryDelay: backoff.Exponential,
}.Run(ctx, func(ctx context.Context) error {
cmd := &packersdk.RemoteCmd{Command: flattenedCmd}
err = cmd.RunWithUi(ctx, comm, ui)
if err != nil || cmd.ExitStatus() != 0 {
return fmt.Errorf("error uploading virtual machine")
if err != nil {
return fmt.Errorf("error uploading virtual machine: %w", err)
}
if cmd.ExitStatus() != 0 {
return fmt.Errorf("error uploading virtual machine: exit status %d", cmd.ExitStatus())
}
return nil
})
Expand Down
Loading