tdnf: capture install output so it does not overlay the curses UI#46
Merged
Merged
Conversation
execute(do_json=False) used subprocess.check_call(), inheriting the installer's stdout/stderr. During a UI install that overlays the curses progress bar with tdnf/rpm messages (e.g. file paths like /etc/os-release). Capture the output and send it to the log instead. Co-Authored-By: Daniel Casota <dcasota@gmail.com>
This was referenced Jun 5, 2026
Contributor
Author
|
Part of a coordinated Photon 5.0 installer fix set:
|
Contributor
|
Thank you, @dcasota ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tdnf.execute(do_json=False)usessubprocess.check_call(args), which inherits the installer's stdout/stderr. During a curses (UI) install, tdnf/rpm output — including file paths such as/etc/os-release— is printed directly to the terminal and overlays the installer progress bar.Fix
Capture the subprocess output and route it to the installer log instead, preserving the previous return value and failure (
CalledProcessError) behaviour.🤖 Generated with Claude Code