Update Resolve-PhysicalHostServiceAccounts

LifeOfBrianOC · web-flow · commit 51979af41197 · 2024-05-16T13:47:13.000+01:00
Signed-off-by: Brian O'Connell &lt;brianoc4@gmail.com&gt;

Signed-off-by: Brian O'Connell &lt;brianoc4@gmail.com&gt;
diff --git a/VMware.CloudFoundation.InstanceRecovery.psm1 b/VMware.CloudFoundation.InstanceRecovery.psm1
@@ -2103,11 +2103,11 @@ Function Resolve-PhysicalHostServiceAccounts {
             LogMessage -type INFO -message "[$($hostInstance.name)] VCF Service Account Not Found: Creating"
             New-VMHostAccount -Id $svcAccountName -Password $svcAccountPassword -Description "ESXi User" | Out-Null
             New-VIPermission -Entity (Get-Folder root) -Principal $svcAccountName -Role Admin | Out-Null
-            Disconnect-VIServer $hostInstance.name -confirm:$false | Out-Null
         } else {
             LogMessage -type INFO -message "[$($hostInstance.name)] VCF Service Account Found: Setting Password"
             Set-VMHostAccount -UserAccount $svcAccountName -Password $svcAccountPassword | Out-Null
         }
+		Disconnect-VIServer $hostInstance.name -confirm:$false | Out-Null
     }
 
     Foreach ($hostInstance in $clusterHosts) {

Original file line number	Diff line number	Diff line change
`@@ -2103,11 +2103,11 @@ Function Resolve-PhysicalHostServiceAccounts {`
`2103`	`2103`	`LogMessage -type INFO -message "[$($hostInstance.name)] VCF Service Account Not Found: Creating"`
`2104`	`2104`	`New-VMHostAccount -Id $svcAccountName -Password $svcAccountPassword -Description "ESXi User" \| Out-Null`
`2105`	`2105`	`New-VIPermission -Entity (Get-Folder root) -Principal $svcAccountName -Role Admin \| Out-Null`
`2106`		`- Disconnect-VIServer $hostInstance.name -confirm:$false \| Out-Null`
`2107`	`2106`	`} else {`
`2108`	`2107`	`LogMessage -type INFO -message "[$($hostInstance.name)] VCF Service Account Found: Setting Password"`
`2109`	`2108`	`Set-VMHostAccount -UserAccount $svcAccountName -Password $svcAccountPassword \| Out-Null`
`2110`	`2109`	`}`
	`2110`	`+ Disconnect-VIServer $hostInstance.name -confirm:$false \| Out-Null`
`2111`	`2111`	`}`
`2112`	`2112`
`2113`	`2113`	`Foreach ($hostInstance in $clusterHosts) {`