control-service: remove support for old k8s (#3202)

# Why 
External customers are looking to run on newer versions of k8s than we
support.
We are using a very old batch/V1Beta1 api. 
We need to remove all references to this.

# What 
I deleted all code which was referencing it. This looks like a massive
PR but it should actually be fairly simple to review because it is just
deleting code.
 
# How was this tested??
Existing unit and integration tests. 
I will also be deploying it to newer versions of k8s this week.



Signed-off-by: murphp15 <murphp15@tcd.ie>

---------

Co-authored-by: github-actions <>
Co-authored-by: paulm2 <paulm2@vmware.com>

Author: murphp15

projects/control-service/projects/helm_charts/pipelines-control-service/README.md

@@ -2,8 +2,7 @@
 Versatile Data Kit is a platform that enables Data Engineers to implement automated pull ingestion (E in ELT) and batch data transformation into a database (T in ELT).
 
 ## Prerequisites
-- Kubernetes 1.19<=x>1.25 works with no config changes
-- for kubernetes 1.25+ the datajob template needs to be changed in the [values.yaml](./values.yaml). Specifically `enabled` needs to be set to `true` and `apiVersion` needs to be set to `batch/v1`
+- Kubernetes 1.24<
 - Helm 3.0
 - PV provisioner support in the underlying infrastructure if using the embedded database.
 - During helm install - CRUD on Kubernetes Deployment, Service, ServiceAccount, Role, Rolebindings. Control Service itself manages CronJob(Job and Pod as well), Secret resources. Statefulset and PVC if using the embedded database

projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml

@@ -974,7 +974,7 @@ customStartupProbeProbe: {}
 datajobTemplate:
   enabled: false
   template:
-    apiVersion: batch/v1beta1
+    apiVersion: batch/v1
     kind: CronJob
     metadata:
       annotations:                   # merged with additional annotations from TPCS

projects/control-service/projects/pipelines_control_service/src/integration-test/java/com/vmware/taurus/datajobs/it/DataJobDeploymentCrudAsyncIT.java

@@ -20,7 +20,6 @@
 
 @TestPropertySource(
     properties = {
-      "datajobs.control.k8s.k8sSupportsV1CronJob=true",
       "datajobs.deployment.configuration.persistence.writeTos=DB",
       "datajobs.deployment.configuration.persistence.readDataSource=DB",
       "datajobs.deployment.configuration.synchronization.task.enabled=true",

projects/control-service/projects/pipelines_control_service/src/integration-test/java/com/vmware/taurus/datajobs/it/DataJobDeploymentCrudIT.java

@@ -21,7 +21,6 @@
 
 @TestPropertySource(
     properties = {
-      "datajobs.control.k8s.k8sSupportsV1CronJob=true",
       "datajobs.deployment.configuration.persistence.writeTos=K8S",
       "datajobs.deployment.configuration.persistence.readDataSource=K8S",
       "datajobs.deployment.configuration.synchronization.task.enabled=false"

projects/control-service/projects/pipelines_control_service/src/integration-test/java/com/vmware/taurus/datajobs/it/TestJobDeployTempCredsIT.java

@@ -53,7 +53,6 @@
 @Import({TestJobDeployTempCredsIT.TaskExecutorConfig.class})
 @TestPropertySource(
     properties = {
-      "datajobs.control.k8s.k8sSupportsV1CronJob=true",
       "datajobs.aws.assumeIAMRole=true",
       "datajobs.aws.RoleArn=arn:aws:iam::320807031117:role/svc.ecr-integration-test",
       "datajobs.docker.registryType=ecr",

projects/control-service/projects/pipelines_control_service/src/integration-test/java/com/vmware/taurus/datajobs/it/TestJobImageBuilderDynamicVdkImageIT.java

@@ -45,7 +45,6 @@
 @Import({TestJobImageBuilderDynamicVdkImageIT.TaskExecutorConfig.class})
 @TestPropertySource(
     properties = {
-      "datajobs.control.k8s.k8sSupportsV1CronJob=true",
       "datajobs.deployment.supportedPythonVersions={3.8: {vdkImage:"
           + " 'registry.hub.docker.com/versatiledatakit/quickstart-vdk:pre-release', baseImage:"
           + " 'versatiledatakit/data-job-base-python-3.8:latest', builderImage:"

projects/control-service/projects/pipelines_control_service/src/integration-test/java/com/vmware/taurus/service/deploy/DataJobDeploymentCrudITV2.java

@@ -51,7 +51,6 @@
 @Import({DataJobDeploymentCrudITV2.TaskExecutorConfig.class})
 @TestPropertySource(
     properties = {
-      "datajobs.control.k8s.k8sSupportsV1CronJob=true",
       "datajobs.deployment.configuration.synchronization.task.enabled=true",
       "datajobs.deployment.configuration.synchronization.task.initial.delay.ms=1000000",
       // Setting this value to 1000000 effectively disables the scheduled execution of

projects/control-service/projects/pipelines_control_service/src/integration-test/resources/application-test.properties

@@ -13,7 +13,6 @@ datajobs.vdk_options_ini=
 
 datajobs.deployment.k8s.kubeconfig=${DEPLOYMENT_K8S_KUBECONFIG:}
 datajobs.deployment.k8s.namespace=${DEPLOYMENT_K8S_NAMESPACE:default}
-datajobs.control.k8s.k8sSupportsV1CronJob=false
 
 datajobs.control.k8s.kubeconfig=${CONTROL_K8S_KUBECONFIG:}
 datajobs.control.k8s.namespace=${CONTROL_K8S_NAMESPACE:default}

projects/control-service/projects/pipelines_control_service/src/integration-test/resources/data_job_templates/backoff_limit_exceeded_cron_job.yaml

@@ -1,7 +1,7 @@
 # Copyright 2023-2024 Broadcom
 # SPDX-License-Identifier: Apache-2.0
 
-apiVersion: batch/v1beta1
+apiVersion: batch/v1
 kind: CronJob
 metadata:
   annotations:                   # merged with additional annotations from TPCS

projects/control-service/projects/pipelines_control_service/src/integration-test/resources/data_job_templates/fast_failing_cron_job.yaml

@@ -1,7 +1,7 @@
 # Copyright 2023-2024 Broadcom
 # SPDX-License-Identifier: Apache-2.0
 
-apiVersion: batch/v1beta1
+apiVersion: batch/v1
 kind: CronJob
 metadata:
   annotations:                   # merged with additional annotations from TPCS