control-service: reduce logging (#2834)

mivanov1988 · web-flow · commit abffdf851c54 · 2023-10-25T15:39:12.000+03:00
Why Reducing unnecessary logging caused by the frequent async data jobs deployment scheduled every minute. ``` 2023-10-25 11:46:29,056 DEBUG [OpId:] ecutor-200 c.v.t.s.diag.telemetry.Telemetry Sending streaming telemetry to https://vcsa.vmware.com/ph-stg/api/hyper/send?_c=taurus.v0&_i=supecollider-control-service 2023-10-25 11:46:29,063 DEBUG [OpId:] ecutor-199 .t.s.k.DataJobsKubernetesService Datajob template file location is not set. Using internal datajob template. 2023-10-25 11:46:29,065 DEBUG [OpId:] ecutor-199 c.v.t.s.d.m.MetricsHelper Failed to convert object to json: class java.util.LinkedHashMap: failed to lazily initialize a collection of role: com.vmware.taurus.service.model.DataJob.executions, could not initialize proxy - no Session (through reference chain: java.util.LinkedHashMap["data_job"]->com.vmware.taurus.service.model.DataJob["executions"]) 2023-10-25 11:46:29,065 DEBUG [OpId:] ecutor-199 c.v.t.s.diag.telemetry.Telemetry Sending streaming telemetry to https://vcsa.vmware.com/ph-stg/api/hyper/send?_c=taurus.v0&_i=supecollider-control-service 2023-10-25 11:46:29,066 DEBUG [OpId:] ecutor-199 c.v.t.s.d.m.MetricsHelper Failed to convert object to json: class java.util.LinkedHashMap: failed to lazily initialize a collection of role: com.vmware.taurus.service.model.DataJob.executions, could not initialize proxy - no Session (through reference chain: java.util.LinkedHashMap["deployment"]->com.vmware.taurus.service.model.DesiredDataJobDeployment["dataJob"]->com.vmware.taurus.service.model.DataJob["executions"]) 2023-10-25 11:46:29,066 DEBUG [OpId:] ecutor-199 c.v.t.s.diag.telemetry.Telemetry Sending streaming telemetry to https://vcsa.vmware.com/ph-stg/api/hyper/send?_c=taurus.v0&_i=supecollider-control-service 2023-10-25 11:46:29,097 DEBUG [OpId:] ecutor-198 .t.s.k.DataJobsKubernetesService Datajob template file location is not set. Using internal datajob template. ``` What Adjusted the logging levels for specific log statements. Signed-off-by: Miroslav Ivanov miroslavi@vmware.com Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
diff --git a/projects/control-service/projects/base/src/main/java/com/vmware/taurus/service/diag/methodintercept/MetricsHelper.java b/projects/control-service/projects/base/src/main/java/com/vmware/taurus/service/diag/methodintercept/MetricsHelper.java
@@ -74,7 +74,7 @@ private static String serializeObject(Object obj) {
       mapper.setSerializationInclusion(JsonInclude.Include.NON_NULL);
       result = mapper.writeValueAsString(obj);
     } catch (JsonProcessingException e) {
-      log.debug("Failed to convert object to json: {}: {}", obj.getClass(), e.getMessage());
+      log.trace("Failed to convert object to json: {}: {}", obj.getClass(), e.getMessage());
       result = "" + obj;
     }
     return result;
diff --git a/projects/control-service/projects/base/src/main/java/com/vmware/taurus/service/diag/telemetry/Telemetry.java b/projects/control-service/projects/base/src/main/java/com/vmware/taurus/service/diag/telemetry/Telemetry.java
@@ -75,7 +75,7 @@ public void sendAsync(String payload) {
     if (StringUtils.isBlank(this.telemetryEndpoint)) {
       return;
     }
-    log.debug("Sending streaming telemetry to {}", telemetryEndpoint);
+    log.trace("Sending streaming telemetry to {}", telemetryEndpoint);
     HttpResponse.BodyHandler<String> handler = HttpResponse.BodyHandlers.ofString();
 
     HttpRequest request =
diff --git a/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java b/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java
@@ -227,7 +227,7 @@ protected boolean getK8sSupportsV1CronJob() {
 
   private V1CronJob loadV1CronjobTemplate() {
     if (StringUtils.isEmpty(datajobTemplateFileLocation)) {
-      log.debug("Datajob template file location is not set. Using internal datajob template.");
+      log.trace("Datajob template file location is not set. Using internal datajob template.");
       return loadInternalV1CronjobTemplate();
     }
     V1CronJob cronjobTemplate = loadConfigurableV1CronjobTemplate();
@@ -240,7 +240,7 @@ private V1CronJob loadV1CronjobTemplate() {
 
   private V1beta1CronJob loadV1beta1CronjobTemplate() {
     if (StringUtils.isEmpty(datajobTemplateFileLocation)) {
-      log.debug("Datajob template file location is not set. Using internal datajob template.");
+      log.trace("Datajob template file location is not set. Using internal datajob template.");
       return loadInternalV1beta1CronjobTemplate();
     }
     V1beta1CronJob cronjobTemplate = loadConfigurableV1beta1CronjobTemplate();
@@ -278,7 +278,7 @@ private V1CronJob loadInternalV1CronjobTemplate() {
   private V1beta1CronJob loadConfigurableV1beta1CronjobTemplate() {
     // Check whether to use configurable datajob template at all.
     if (StringUtils.isEmpty(datajobTemplateFileLocation)) {
-      log.debug("Datajob template file location is not set.");
+      log.trace("Datajob template file location is not set.");
       return null;
     }
 
@@ -295,7 +295,7 @@ private V1beta1CronJob loadConfigurableV1beta1CronjobTemplate() {
   private V1CronJob loadConfigurableV1CronjobTemplate() {
     // Check whether to use configurable datajob template at all.
     if (StringUtils.isEmpty(datajobTemplateFileLocation)) {
-      log.debug("Datajob template file location is not set.");
+      log.trace("Datajob template file location is not set.");
       return null;
     }
 
diff --git a/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java b/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java
@@ -137,7 +137,7 @@ public void updateDeployment(
 
     if (DeploymentStatus.USER_ERROR.equals(desiredJobDeployment.getStatus())
         || DeploymentStatus.PLATFORM_ERROR.equals(desiredJobDeployment.getStatus())) {
-      log.debug(
+      log.trace(
           "Skipping the data job [job_name={}] deployment due to the previously failed deployment"
               + " [status={}]",
           dataJob.getName(),
diff --git a/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/kubernetes/DataJobsKubernetesService.java b/projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/kubernetes/DataJobsKubernetesService.java
@@ -240,7 +240,7 @@ public Set<String> listCronJobs() throws ApiException {
         v1BetaCronJobs.getItems().stream()
             .map(j -> j.getMetadata().getName())
             .collect(Collectors.toSet());
-    log.debug("K8s V1Beta cron jobs: {}", v1BetaCronJobNames);
+    log.trace("K8s V1Beta cron jobs: {}", v1BetaCronJobNames);
     return Stream.concat(v1CronJobNames.stream(), v1BetaCronJobNames.stream())
         .collect(Collectors.toSet());
   }

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ private static String serializeObject(Object obj) {`
`74`	`74`	`mapper.setSerializationInclusion(JsonInclude.Include.NON_NULL);`
`75`	`75`	`result = mapper.writeValueAsString(obj);`
`76`	`76`	`} catch (JsonProcessingException e) {`
`77`		`- log.debug("Failed to convert object to json: {}: {}", obj.getClass(), e.getMessage());`
	`77`	`+ log.trace("Failed to convert object to json: {}: {}", obj.getClass(), e.getMessage());`
`78`	`78`	`result = "" + obj;`
`79`	`79`	`}`
`80`	`80`	`return result;`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public void sendAsync(String payload) {`
`75`	`75`	`if (StringUtils.isBlank(this.telemetryEndpoint)) {`
`76`	`76`	`return;`
`77`	`77`	`}`
`78`		`- log.debug("Sending streaming telemetry to {}", telemetryEndpoint);`
	`78`	`+ log.trace("Sending streaming telemetry to {}", telemetryEndpoint);`
`79`	`79`	`HttpResponse.BodyHandler<String> handler = HttpResponse.BodyHandlers.ofString();`
`80`	`80`
`81`	`81`	`HttpRequest request =`
Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ public Set<String> listCronJobs() throws ApiException {`
`240`	`240`	`v1BetaCronJobs.getItems().stream()`
`241`	`241`	`.map(j -> j.getMetadata().getName())`
`242`	`242`	`.collect(Collectors.toSet());`
`243`		`- log.debug("K8s V1Beta cron jobs: {}", v1BetaCronJobNames);`
	`243`	`+ log.trace("K8s V1Beta cron jobs: {}", v1BetaCronJobNames);`
`244`	`244`	`return Stream.concat(v1CronJobNames.stream(), v1BetaCronJobNames.stream())`
`245`	`245`	`.collect(Collectors.toSet());`
`246`	`246`	`}`