Skip to content

Commit e6cbae4

Browse files
authored
control-service: improve async deployment logging (#2826)
Why Reducing unnecessary logging caused by the frequent async data jobs deployment scheduled every minute. What Adjusted the logging levels for specific log statements. Signed-off-by: Miroslav Ivanov miroslavi@vmware.com Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
1 parent 7fba4f7 commit e6cbae4

4 files changed

Lines changed: 10 additions & 8 deletions

File tree

.pre-commit-config.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ repos:
3535
args: # http://www.pydocstyle.org/en/stable/error_codes.html --convention=pep257 seems too much?
3636
- --select=D101,D103,D300
3737
- --match='(?!test_).*\.py'
38-
- repo: https://github.com/pre-commit/mirrors-pylint
39-
rev: 'v3.0.0a5'
40-
hooks:
41-
- id: pylint
42-
args: [ --exit-zero ]
38+
#- repo: https://github.com/pre-commit/mirrors-pylint
39+
# rev: 'v3.0.0a5'
40+
# hooks:
41+
# - id: pylint
42+
# args: [ --exit-zero ]
4343
#- repo: https://github.com/pre-commit/mirrors-mypy
4444
# rev: v0.812
4545
# hooks:

projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ public void updateDeployment(
149149
boolean sendNotification = Boolean.TRUE.equals(desiredJobDeployment.getUserInitiated());
150150

151151
try {
152+
log.trace("Starting deployment of job {}", desiredJobDeployment.getDataJobName());
152153
deploymentProgress.started(dataJob.getJobConfig(), desiredJobDeployment);
153154

154155
if (desiredJobDeployment.getPythonVersion() == null) {

projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageBuilder.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,10 @@ public boolean buildImage(
134134
String builderAwsSessionToken = credentials.awsSessionToken();
135135
String awsRegion = credentials.region();
136136

137-
log.info("Build data job image for job {}. Image name: {}", dataJob.getName(), imageName);
137+
log.trace("Build data job image for job {}. Image name: {}", dataJob.getName(), imageName);
138138
if (!StringUtils.isBlank(registryType)) {
139139
if (unsupportedRegistryType(registryType)) {
140-
log.debug(
140+
log.warn(
141141
String.format(
142142
"Unsupported registry type: %s available options %s/%s",
143143
registryType, REGISTRY_TYPE_ECR, REGISTRY_TYPE_GENERIC));
@@ -151,7 +151,7 @@ public boolean buildImage(
151151
}
152152

153153
if (dockerRegistryService.dataJobImageExists(imageName, credentials)) {
154-
log.debug("Data Job image {} already exists and nothing else to do.", imageName);
154+
log.trace("Data Job image {} already exists and nothing else to do.", imageName);
155155
return true;
156156
}
157157

projects/control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageDeployerV2.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ public ActualDataJobDeployment scheduleJob(
9090
String jobImageName) {
9191
Validate.notNull(desiredDataJobDeployment, "desiredDataJobDeployment should not be null");
9292
Validate.notNull(jobImageName, "Image name is expected in jobDeployment");
93+
log.trace("Update cron job for data job {}", dataJob.getName());
9394

9495
try {
9596
return updateCronJob(

0 commit comments

Comments
 (0)