Update GuestOS name after upgrading VCH (#8427)

* Update GuestOS name after upgrading VCH

VitrualMachineSpec struct contains this info. This fix update the
field when upgrading vch.
BTW, not only upgrade but also configure command doing this calling
link: Configure()->d.update()->reconfigVCH()->update vmSpec. But it
may change lots of code to distinguish upgrade and configure in this
calling link, so I update vmSpec in both commands.

Modify test case `Check Upgrade Version` to add checking of GuestOS name

Author: YanzhaoLi

lib/install/management/configure.go

@@ -27,6 +27,7 @@ import (
 	"github.com/vmware/govmomi/vim25/types"
 
 	"github.com/vmware/vic/lib/config"
+	"github.com/vmware/vic/lib/constants"
 	"github.com/vmware/vic/lib/install/data"
 	"github.com/vmware/vic/lib/install/opsuser"
 	"github.com/vmware/vic/pkg/errors"
@@ -386,7 +387,7 @@ func (d *Dispatcher) ensureRollbackReady(conf *config.VirtualContainerHostConfig
 func (d *Dispatcher) reconfigVCH(conf *config.VirtualContainerHostConfigSpec, isoFile string) error {
 	defer trace.End(trace.Begin(isoFile, d.op))
 
-	spec := &types.VirtualMachineConfigSpec{}
+	spec := &types.VirtualMachineConfigSpec{AlternateGuestName: constants.DefaultAltVCHGuestName()}
 
 	if isoFile != "" {
 		deviceChange, err := d.switchISO(isoFile)

tests/resources/VCH-Util.robot

@@ -784,6 +784,10 @@ Upgrade with ID
 Check Upgraded Version
     ${rc}  ${output}=  Run And Return Rc And Output  bin/vic-machine-linux version
     @{vers}=  Split String  ${output}
+    ${releaseNumber}=  Run  echo @{vers}[2] | awk -F'-' '{print $1}'
+    ${rc}  ${out}=  Run And Return Rc And Output  govc vm.info %{VCH-NAME} 
+    Should Contain  ${out}  ${releaseNumber}
+    Should Be Equal As Integers  ${rc}  0
     ${rc}  ${output}=  Run And Return Rc And Output  bin/vic-machine-linux inspect --name=%{VCH-NAME} --target=%{TEST_URL}%{TEST_DATACENTER} --thumbprint=%{TEST_THUMBPRINT} --user=%{TEST_USERNAME} --password=%{TEST_PASSWORD} --compute-resource=%{TEST_RESOURCE}
     Log  ${output}
     Should Contain  ${output}  Completed successfully