Skip to content

Commit e2f1b28

Browse files
authored
Add VCH uuid into image storage usage calculation (#8418)
1 parent 9676e9f commit e2f1b28

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

lib/apiservers/portlayer/restapi/handlers/storage_handlers.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -733,12 +733,12 @@ func (h *StorageHandlersImpl) StatPath(params storage.StatPathParams) middleware
733733

734734
}
735735

736-
// ListImages returns a list of images in a store
736+
// GetImageStorageUsage returns images storage usage for this VCH
737737
func (h *StorageHandlersImpl) GetImageStorageUsage(params storage.GetImageStorageUsageParams) middleware.Responder {
738738
op := trace.NewOperationFromID(context.Background(), params.OpID, "GetImageStorageUsage(%s)", params.StoreName)
739739
defer trace.End(trace.Begin("GetImageStorageUsage", op))
740740

741-
result, err := h.imageCache.DataStore.GetImageStorageUsage(op)
741+
result, err := h.imageCache.DataStore.GetImageStorageUsage(op, params.StoreName)
742742
if err != nil {
743743
op.Errorf("Error gettting image storage usage: %s", err)
744744
return storage.NewGetImageStorageUsageDefault(500)

lib/portlayer/storage/image/image.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ type ImageStorer interface {
7777
DeleteImage(op trace.Operation, image *Image) (*Image, error)
7878

7979
// GetImageStorageUsage gets the image storage usage from the image store.
80-
GetImageStorageUsage(op trace.Operation) (int64, error)
80+
GetImageStorageUsage(op trace.Operation, storeName string) (int64, error)
8181

8282
storage.Resolver
8383
storage.Importer

lib/portlayer/storage/image/mock/store.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,6 @@ func (c *MockDataStore) DeleteImage(op trace.Operation, image *image.Image) (*im
187187
return image, nil
188188
}
189189

190-
func (c *MockDataStore) GetImageStorageUsage(op trace.Operation) (int64, error) {
190+
func (c *MockDataStore) GetImageStorageUsage(op trace.Operation, storeName string) (int64, error) {
191191
return 0, nil
192192
}

lib/portlayer/storage/image/vsphere/store.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -590,8 +590,8 @@ func (v *ImageStore) ListImages(op trace.Operation, store *url.URL, IDs []string
590590
return images, nil
591591
}
592592

593-
func (v *ImageStore) GetImageStorageUsage(op trace.Operation) (int64, error) {
594-
return v.Helper.GetFilesSize(op, "", true, "*.vmdk")
593+
func (v *ImageStore) GetImageStorageUsage(op trace.Operation, storeName string) (int64, error) {
594+
return v.Helper.GetFilesSize(op, v.imageStorePath(storeName), true, "*.vmdk")
595595
}
596596

597597
// DeleteImage deletes an image from the image store. If the image is in

0 commit comments

Comments
 (0)