fix(appearance): always use system title bar on macOS

Hide the System title bar checkbox on macOS and force the option on, since a frameless window is unusual on that platform.

Author: tamlok

src/core/sessionconfig.cpp

@@ -304,7 +304,14 @@ QuickAccessOpenMode SessionConfig::stringToOpenMode(const QString &p_str) {
   return QuickAccessOpenMode::Default;
 }
 
-bool SessionConfig::getSystemTitleBarEnabled() const { return m_systemTitleBarEnabled; }
+bool SessionConfig::getSystemTitleBarEnabled() const {
+#if defined(Q_OS_MACOS)
+  // On macOS, always use the system title bar; the option is hidden in settings.
+  return true;
+#else
+  return m_systemTitleBarEnabled;
+#endif
+}
 
 void SessionConfig::setSystemTitleBarEnabled(bool p_enabled) {
   updateConfig(m_systemTitleBarEnabled, p_enabled, this);

src/widgets/dialogs/settings/appearancepage.cpp

@@ -31,17 +31,19 @@ void AppearancePage::setupUI() {
 
   auto *cardLayout = SettingsPageHelper::addSection(mainLayout, tr("Appearance"), QString(), this);
 
+#if !defined(Q_OS_MACOS)
+  // On macOS the system title bar is always used, so this option is hidden.
   {
     const QString label(tr("System title bar"));
     m_systemTitleBarCheckBox = WidgetsFactory::createCheckBox(label, this);
     m_systemTitleBarCheckBox->setToolTip(tr("Use system title bar"));
-    cardLayout->addWidget(
-        SettingsPageHelper::createCheckBoxRow(m_systemTitleBarCheckBox,
-                                              m_systemTitleBarCheckBox->toolTip(), this));
+    cardLayout->addWidget(SettingsPageHelper::createCheckBoxRow(
+        m_systemTitleBarCheckBox, m_systemTitleBarCheckBox->toolTip(), this));
     addSearchItem(label, m_systemTitleBarCheckBox->toolTip(), m_systemTitleBarCheckBox);
     connect(m_systemTitleBarCheckBox, &QCheckBox::stateChanged, this,
             &AppearancePage::pageIsChangedWithRestartNeeded);
   }
+#endif
 
   {
     m_toolBarIconSizeSpinBox = WidgetsFactory::createSpinBox(this);
@@ -52,9 +54,8 @@ void AppearancePage::setupUI() {
 
     const QString label(tr("Main tool bar icon size"));
     cardLayout->addWidget(SettingsPageHelper::createSeparator(this));
-    cardLayout->addWidget(
-        SettingsPageHelper::createSettingRow(label, m_toolBarIconSizeSpinBox->toolTip(),
-                                             m_toolBarIconSizeSpinBox, this));
+    cardLayout->addWidget(SettingsPageHelper::createSettingRow(
+        label, m_toolBarIconSizeSpinBox->toolTip(), m_toolBarIconSizeSpinBox, this));
     addSearchItem(label, m_toolBarIconSizeSpinBox->toolTip(), m_toolBarIconSizeSpinBox);
     connect(m_toolBarIconSizeSpinBox, QOverload<int>::of(&QSpinBox::valueChanged), this,
             &AppearancePage::pageIsChangedWithRestartNeeded);