Data Core Must Die (discordia-space#8594)

* the datacore is dead, long live the crew record file list
apparently this stuff dates back to may 2012
new savefile version clears out old records preferences
reworked security records
character name replacer proc updates renamed items
reversed records sort polarity
reworked respawn character proc
adds setup disks for preset console programs
reduced security and medical file cabinet data to that which could be reasonably accurate for an entire round
deleted unused real rank system
fixed potential fake crew arrival runtime
cargo positions now named guild positions and JOBS_CARGO is now JOBS_GUILD
nonhuman positions now named silicon positions and JOBS_NONHUMAN is now JOBS_SILICON
world manifest now checks department rather than preset job names
updated PAI general, medical, and security records access program
fixed freelancer perk define name
added green thumb and neat job perk defines
deleted duplicate records customization file numbered 5
pruned record customization
WIP

* return to default for datacore purge
update note: setup disks merged seperately
security notes simplified

---------

Co-authored-by: Humonitarian <61586732+Humonitarian@users.noreply.github.com>

Author: vode-code

cev_eris.dme

@@ -281,7 +281,6 @@
 #include "code\datums\callback.dm"
 #include "code\datums\category.dm"
 #include "code\datums\contract.dm"
-#include "code\datums\datacore.dm"
 #include "code\datums\datum.dm"
 #include "code\datums\datum_click_handlers.dm"
 #include "code\datums\datum_hud.dm"
@@ -751,14 +750,12 @@
 #include "code\game\machinery\computer\computer.dm"
 #include "code\game\machinery\computer\guestpass.dm"
 #include "code\game\machinery\computer\law.dm"
-#include "code\game\machinery\computer\medical.dm"
 #include "code\game\machinery\computer\message.dm"
 #include "code\game\machinery\computer\Operating.dm"
 #include "code\game\machinery\computer\pod.dm"
 #include "code\game\machinery\computer\prisoner.dm"
 #include "code\game\machinery\computer\prisonshuttle.dm"
 #include "code\game\machinery\computer\robot.dm"
-#include "code\game\machinery\computer\security.dm"
 #include "code\game\machinery\computer\station_alert.dm"
 #include "code\game\machinery\doors\airlock.dm"
 #include "code\game\machinery\doors\airlock_control.dm"
@@ -1458,6 +1455,7 @@
 #include "code\modules\asset_cache\asset_cache_item.dm"
 #include "code\modules\asset_cache\asset_list.dm"
 #include "code\modules\asset_cache\asset_list_items.dm"
+#include "code\modules\asset_cache\assets\legacyuiicons.dm"
 #include "code\modules\asset_cache\assets\sanity.dm"
 #include "code\modules\asset_cache\assets\sheetmaterials.dm"
 #include "code\modules\asset_cache\assets\stats.dm"
@@ -2277,6 +2275,7 @@
 #include "code\modules\nano\modules\human_appearance.dm"
 #include "code\modules\nano\modules\law_manager.dm"
 #include "code\modules\nano\modules\nano_module.dm"
+#include "code\modules\nano\modules\tgui_type.dm"
 #include "code\modules\onestar\generator.dm"
 #include "code\modules\onestar\os_cash.dm"
 #include "code\modules\onestar\os_turret.dm"

code/__DEFINES/jobs.dm

@@ -8,10 +8,10 @@
 #define JOBS_MEDICAL "Moebius Biolab Officer","Moebius Doctor","Moebius Psychiatrist","Moebius Chemist","Moebius Paramedic","Moebius Bio-Engineer"
 #define JOBS_SCIENCE "Moebius Expedition Overseer","Moebius Scientist","Moebius Roboticist"
 #define JOBS_MOEBIUS "Moebius Biolab Officer","Moebius Doctor","Moebius Psychiatrist","Moebius Chemist","Moebius Paramedic","Moebius Bio-Engineer","Moebius Expedition Overseer","Moebius Scientist","Moebius Roboticist"
-#define JOBS_CARGO "Guild Merchant","Guild Technician","Guild Miner",
+#define JOBS_GUILD "Guild Merchant","Guild Technician","Guild Miner",
 #define JOBS_CIVILIAN "Club Manager","Club Worker","Club Artist",ASSISTANT_TITLE
 #define JOBS_CHURCH	"NeoTheology Preacher","NeoTheology Acolyte","NeoTheology Agrolyte","NeoTheology Custodian"
-#define JOBS_NONHUMAN "AI","Robot","pAI"
+#define JOBS_SILICON "AI","Robot","pAI"
 #define CREDITS "¢"
 #define CREDS "¢"
 

code/__DEFINES/perks.dm

@@ -1,6 +1,6 @@
 //fate perks
 #define PERK_PAPER_WORM /datum/perk/fate/paper_worm
-#define PERK_FREELACER /datum/perk/fate/freelancer
+#define PERK_FREELANCER /datum/perk/fate/freelancer
 #define PERK_NIHILIST /datum/perk/fate/nihilist
 #define PERK_MORALIST /datum/perk/fate/moralist
 #define PERK_ALCOHOLIC /datum/perk/fate/alcoholic
@@ -49,6 +49,8 @@
 #define PERK_CODESPEAK_COP /datum/perk/codespeak
 #define PERK_CODESPEAK_SERB /datum/perk/codespeak/serbian
 #define PERK_TECHNOMANCER /datum/perk/inspiration
+#define PERK_NEAT /datum/perk/neat
+#define PERK_GREEN_THUMB  /datum/perk/greenthumb
 #define PERK_CLUB /datum/perk/job/club
 #define PERK_CHANNELING /datum/perk/channeling
 

code/__HELPERS/manifest.dm

@@ -142,13 +142,13 @@
 		"sec" = filtered_nano_crew_manifest(security_positions),\
 		"eng" = filtered_nano_crew_manifest(engineering_positions),\
 		"med" = filtered_nano_crew_manifest(medical_positions),\
-		"sup" = filtered_nano_crew_manifest(cargo_positions),\
+		"sup" = filtered_nano_crew_manifest(guild_positions),\
 		"chr" = filtered_nano_crew_manifest(church_positions),\
-		"bot" = silicon_nano_crew_manifest(nonhuman_positions),\
+		"bot" = silicon_nano_crew_manifest(silicon_positions),\
 		"civ" = filtered_nano_crew_manifest(civilian_positions)\
 		)
 
 /proc/flat_nano_crew_manifest()
 	. = list()
 	. += filtered_nano_crew_manifest(null, TRUE)
-	. += silicon_nano_crew_manifest(nonhuman_positions)
+	. += silicon_nano_crew_manifest(silicon_positions)

code/__HELPERS/names.dm

@@ -94,8 +94,8 @@ var/syndicate_code_response//Code response for contractors.
 	var/locations[] = LAZYLEN(SSmapping.main_ship_areas_by_name) ? SSmapping.main_ship_areas_by_name : drinks // If null, defaults to drinks instead.
 
 	var/names[] = list()
-	for(var/datum/data/record/t in data_core.general)//Picks from crew manifest.
-		names += t.fields["name"]
+	for(var/datum/computer_file/report/crew_record/t in GLOB.all_crew_records)//Picks from crew manifest.
+		names += t.get_name()
 
 	var/maxwords = words//Extra var to check for duplicates.
 

code/__HELPERS/unsorted.dm

@@ -276,26 +276,21 @@ Turf and target are seperate in case you want to teleport some distance from a t
 		mind.name = newname
 
 	if(oldname)
-		//update the datacore records! This is goig to be a bit costly.
-		for(var/list/L in list(data_core.general, data_core.medical, data_core.security, data_core.locked))
-			for(var/datum/data/record/R in L)
-				if(R.fields["name"] == oldname)
-					R.fields["name"] = newname
-					break
+		for(var/datum/computer_file/report/crew_record/R in GLOB.all_crew_records)
+			if(R.get_name() == oldname)
+				R.set_name(newname)
 
 		//update our pda and id if we have them on our person
-		var/list/searching = GetAllContents(searchDepth = 3)
-		var/search_id = 1
-		var/search_pda = 1
-
-		for(var/A in searching)
-			if( search_id && istype(A,/obj/item/card/id) )
+		for(var/obj/A in GetAllContents(searchDepth = 3))
+			if(istype(A,/obj/item/card/id))
 				var/obj/item/card/id/ID = A
 				if(ID.registered_name == oldname)
 					ID.registered_name = newname
 					ID.name = "[newname]'s ID Card ([ID.assignment])"
-					if(!search_pda)	break
-					search_id = 0
+					if(istype(A.loc, /obj/item/modular_computer))
+						var/obj/item/modular_computer/tolabel = A.loc
+						tolabel.update_label()
+					break
 	return 1
 
 

code/controllers/subsystems/ticker.dm

@@ -241,7 +241,6 @@ SUBSYSTEM_DEF(ticker)
 		if(!H.mind || player_is_antag(H.mind, only_offstation_roles = 1) || !SSjob.ShouldCreateRecords(H.mind.assigned_role))
 			continue
 		CreateModularRecord(H)
-	data_core.manifest()
 
 	CHECK_TICK