standardizes for loops to using purely commas rather than comma-semicolon mixes (discordia-space#8627)

spacemanDMM hints moved to top of procs

Author: vode-code

code/controllers/subsystems/chunks.dm

@@ -217,14 +217,14 @@ SUBSYSTEM_DEF(chunks)
 	RegisterSignal(newContainer, COMSIG_MOVABLE_MOVED, PROC_REF(chunkHearerOnMove))
 
 /obj/proc/chunkHearerClearSelf(datum/source)
+	SIGNAL_HANDLER
 	var/atom/container = getContainingAtom()
 	UnregisterSignal(container, COMSIG_MOVABLE_MOVED)
 	UnregisterSignal(src, list(COMSIG_ATOM_CONTAINERED, COMSIG_PARENT_QDELETING))
 	// in this case we never registered
 	if(container.z != 0)
 		var/datum/chunk/chunk_reference = SSchunks.chunk_list_by_zlevel[container.z][CHUNKID(container.x, container.y)]
 		chunk_reference.hearers -= src
-	SIGNAL_HANDLER
 
 
 // This is done by the mob itself because keeping track of them with reference solving is trash and unefficient

code/controllers/subsystems/jamming.dm

@@ -9,7 +9,7 @@ SUBSYSTEM_DEF(jamming)
 
 /datum/controller/subsystem/jamming/Initialize(start_timeofday)
 	active_jammers = new /list(world.maxz)
-	for(var/i = 1, i < world.maxz; i++)
+	for(var/i = 1, i < world.maxz, i++)
 		active_jammers[i] = list()
 	. = ..()
 

code/datums/components/jamming.dm

@@ -35,10 +35,10 @@
 	if(!active)
 		return
 	var/list/affectedLevels = getAffectedLevels(oldLevel)
-	for(var/i = affectedLevels[1], i <= affectedLevels[2]; i++)
+	for(var/i = affectedLevels[1], i <= affectedLevels[2], i++)
 		SSjamming.active_jammers[i] -= src
 	affectedLevels = getAffectedLevels(newLevel)
-	for(var/i = affectedLevels[1], i <= affectedLevels[2]; i++)
+	for(var/i = affectedLevels[1], i <= affectedLevels[2], i++)
 		SSjamming.active_jammers[i] += src
 
 
@@ -53,7 +53,7 @@
 	if(active)
 		var/turf/ownerTurf = get_turf(owner)
 		var/list/affectedLevels = getAffectedLevels(ownerTurf.z)
-		for(var/i = affectedLevels[1], i <= affectedLevels[2]; i++)
+		for(var/i = affectedLevels[1], i <= affectedLevels[2], i++)
 			SSjamming.active_jammers[i] -= src
 	owner = null
 	..()
@@ -62,10 +62,10 @@
 	var/turf/ownerTurf = get_turf(owner)
 	var/list/affectedLevels = getAffectedLevels(ownerTurf.z)
 	if(active)
-		for(var/i = affectedLevels[1], i <= affectedLevels[2]; i++)
+		for(var/i = affectedLevels[1], i <= affectedLevels[2], i++)
 			SSjamming.active_jammers[i] -= src
 	else
-		for(var/i = affectedLevels[1], i <= affectedLevels[2]; i++)
+		for(var/i = affectedLevels[1], i <= affectedLevels[2], i++)
 			SSjamming.active_jammers[i] += src
 	active = !active
 

code/datums/perks/perk.dm

@@ -36,17 +36,17 @@
 
 /// Proc called when the perk is assigned to a human. Should be the first thing to be called.
 /datum/perk/proc/assign(mob/living/carbon/human/H)
+	SHOULD_CALL_PARENT(TRUE)
 	if(istype(H))
-		SHOULD_CALL_PARENT(TRUE)
 		holder = H
 		RegisterSignal(holder, COMSIG_MOB_LIFE, PROC_REF(on_process))
 		to_chat(holder, SPAN_NOTICE("[gain_text]"))
 		return TRUE
 
 /// Proc called when the perk is removed from a human. Obviously, in your perks, you should call parent as the last thing you do, since it deletes the perk itself.
 /datum/perk/proc/remove()
-	UnregisterSignal(holder, COMSIG_MOB_LIFE, PROC_REF(on_process))
 	SHOULD_CALL_PARENT(TRUE)
+	UnregisterSignal(holder, COMSIG_MOB_LIFE, PROC_REF(on_process))
 	qdel(src)
 
 /// Proc called , a bitflag is always expected.

code/game/gamemodes/events/blob.dm

@@ -37,7 +37,7 @@
 
 	log_and_message_admins("Blob spawned at \the [get_area(T)]", location = T)
 	Blob = new /obj/effect/blob/core(T)
-	for(var/i = 1; i < rand(3, 4), i++)
+	for(var/i = 1, i < rand(3, 4), i++)
 		Blob.Process()
 
 /datum/event/blob/tick()

code/game/machinery/camera/camera.dm

@@ -378,7 +378,7 @@
 /atom/proc/auto_turn()
 	//Automatically turns based on nearby walls.
 	var/turf/wall/T = null
-	for(var/i = 1, i <= 8; i += i)
+	for(var/i = 1, i <= 8, i += i)
 		T = get_ranged_target_turf(src, i, 1)
 		if(istype(T))
 			//If someone knows a better way to do this, let me know. -Giacom

code/game/objects/items/stacks/stack.dm

@@ -95,7 +95,7 @@
 		var/datum/stack_recipe_list/srl = recipe_list[recipes_sublist]
 		recipe_list = srl.recipes
 	var/t1 = text("<HTML><HEAD><title>Constructions from []</title></HEAD><body><TT>Amount Left: []<br>", src, src.get_amount())
-	for(var/i=1;i<=recipe_list.len,i++)
+	for(var/i=1,i<=recipe_list.len,i++)
 		var/E = recipe_list[i]
 		if (isnull(E))
 			t1 += "<hr>"

code/modules/dungeons/asteroid.dm

@@ -239,8 +239,8 @@
 
 	var/datum/rogue/asteroid/A = new(rand(core_min,core_max))
 
-	for(var/x = 1; x <= A.coresize, x++)
-		for(var/y = 1; y <= A.coresize, y++)
+	for(var/x = 1, x <= A.coresize, x++)
+		for(var/y = 1, y <= A.coresize, y++)
 			A.spot_add(A.coresize+x, A.coresize+y, A.type_wall)
 
 

code/modules/mob/animations.dm

@@ -234,7 +234,7 @@ note dizziness decrements automatically in the mob's Life() proc.
 			aiEyeFlag = 1
 
 		var/x
-		for(x=0; x<duration, x++)
+		for(x=0, x<duration, x++)
 			if(aiEyeFlag)
 				M.client.eye = locate(dd_range(1,oldeye.loc.x+rand(-strength,strength),world.maxx),dd_range(1,oldeye.loc.y+rand(-strength,strength),world.maxy),oldeye.loc.z)
 			else

code/modules/power/lighting.dm

@@ -778,7 +778,7 @@
 	//Automatically turns based on nearby walls, destroys if not found.
 	var/turf/wall/T = null
 	var/gotdir = 0
-	for(var/i = 1, i <= 8; i += i)
+	for(var/i = 1, i <= 8, i += i)
 		T = get_ranged_target_turf(src, i, 1)
 
 		if(istype(T))