Skip to content

Skarnet update#43583

Closed
mobinmob wants to merge 11 commits into
void-linux:masterfrom
mobinmob:skarnet-update
Closed

Skarnet update#43583
mobinmob wants to merge 11 commits into
void-linux:masterfrom
mobinmob:skarnet-update

Conversation

@mobinmob

@mobinmob mobinmob commented Apr 23, 2023

Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: YES

--

  • Update to skarnet packages and manpages.
  • A new package for s6-rc-man-pages is added and the man pages repos are now hosted on sourcehut, so homepage and distfiles are changed.

@mobinmob

mobinmob commented May 1, 2023

Copy link
Copy Markdown
Contributor Author

@Duncaen

Duncaen commented Jun 14, 2023

Copy link
Copy Markdown
Member

I don't like that we start vendoring random configuration files.

@Duncaen

Duncaen commented Jun 14, 2023

Copy link
Copy Markdown
Member

I would prefer if you do changes like that in separate PRs from just the bulk updates.

Comment thread srcpkgs/s6-rc-man-pages/template Outdated
Comment thread srcpkgs/s6-rc-man-pages/template Outdated
@mobinmob

mobinmob commented Jul 1, 2023

Copy link
Copy Markdown
Contributor Author

I would prefer if you do changes like that in separate PRs from just the bulk updates.

I agree, but there should be a way to have some configuration files that are tested, even if they are not endorsed in some way for the distribution. This was tested by @dkwo. I removed it and corrected the template and service to account for it. Maybe installing the file with vdoc as mdev.conf.sample and making clear in a comment that this is offered as an example will be acceptable?

@mobinmob

mobinmob commented Jul 1, 2023

Copy link
Copy Markdown
Contributor Author
  • Rebased on master.
  • Fixes (many thanks for the review @Duncaen !)
  • Added --enable-pedantic-posix to the execline configure_args.

Comment thread srcpkgs/mdevd/files/mdevd/run Outdated
Thanks to dkwo for the initial work and Duncaen for enhancements.
@mobinmob

mobinmob commented Jul 1, 2023

Copy link
Copy Markdown
Contributor Author
  • Added --enable-pedantic-posix to the execline configure_args.

In some (rare) cases the execline-cd is called instead of the shell internal command and that works in a slightly different way.

@dkwo

dkwo commented Jul 1, 2023

Copy link
Copy Markdown
Contributor

I tested that config for mdev a while ago, but dropping it or including as vdoc seems also fine.
Note that without a config it is rather useless.

@mobinmob

mobinmob commented Jul 1, 2023

Copy link
Copy Markdown
Contributor Author

I tested that config for mdev a while ago, but dropping it or including as vdoc seems also fine.
Note that without a config it is rather useless.

I think that mdevd has a pretty clear log message for a missing configuration file, so I hope a sample config under the usual place for documentation will be helpful.

@github-actions

Copy link
Copy Markdown

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions Bot added the Stale label Sep 30, 2023
@mobinmob

Copy link
Copy Markdown
Contributor Author

bump...

@github-actions github-actions Bot removed the Stale label Oct 1, 2023
@mobinmob

Copy link
Copy Markdown
Contributor Author

Superseeded by #47177 .

@mobinmob mobinmob closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants