New packages: sstp-client-1.0.20 and network-manager-sstp-1.3.2#58994
New packages: sstp-client-1.0.20 and network-manager-sstp-1.3.2#58994kalelidev wants to merge 2 commits into
Conversation
815cad7 to
4cf70c7
Compare
|
Since this depends on another new package in a separate pull request you should put them together in one request so that CI can build it and merging doesn't require merging two separate PRs. |
Thanks for the heads-up. |
|
I meant to comment this in #59016, since that one depends on this PR. |
@Duncaen Thanks for the heads-up earlier! I've now combined both packages into this PR (#58994):
Closed the separate #59016. CI should now build everything together without dependency issues. |
|
|
Duncaen
left a comment
There was a problem hiding this comment.
Please squash the commits so that its one commit per package.
|
Hi @Duncaen, |
f68d7ef to
f14343b
Compare
|
The subpackage symlink |
Duncaen
left a comment
There was a problem hiding this comment.
Some changes need to be addressed and merge conflict needs to be resolved.
da9d8ab to
b92535c
Compare
| distfiles="https://gitlab.com/sstp-project/sstp-client/-/releases/${version}/downloads/dist-gzip/sstp-client-${version}.tar.gz" | ||
| checksum="6c84b6cdcc21ebea6daeb8c5356dcdfd8681f4981a734f8485ed0b31fc30aadd" | ||
|
|
||
| make_dirs="/var/run/sstpc 0755 root root" |
There was a problem hiding this comment.
This make_dirs doesn't really make sense, /var/run is a symlink to /run which is tmpfs.
| revision=1 | ||
| build_style=gnu-configure | ||
| _pppver=2.5.0 | ||
| configure_args="--prefix=/usr |
There was a problem hiding this comment.
--prefix is added by the build style byu default and doesn't need to be listed.
indention inside variables should be a single space.
This adds the SSTP client from https://gitlab.com/sstp-project/sstp-client.
This adds support for the SSTP VPN plugin in NetworkManager from https://gitlab.gnome.org/GNOME/network-manager-sstp.
Includes patch to fix obsolete GTK4 spacing in UI generation.
Combined into one PR to resolve dependency for CI/build.
Shared library registration
Added to
common/shlibs:Testing the changes
I tested the changes in this PR: YES
New package
This new package conforms to the package requirements: YES
Local build testing
I built this PR locally for my native architecture, x86_64-glibc
I built this PR locally for these architectures:
aarch64 (cross)