fix(executor): resolve linting issues and improve logging

Fixes all linting issues identified in the Docker client integration:

- Add structured logging to DockerClient using slog.Logger
- Replace fmt.Printf with proper structured logging for container warnings
- Remove unused cleanupTimer field from CleanupManager
- Remove unused helper functions (intPtr, int64Ptr)
- Update deprecated Docker API calls:
  - Replace client.IsErrNotFound with errdefs.IsNotFound
  - Replace types.ContainerJSON with container.InspectResponse
- Remove unused import of github.com/docker/docker/api/types

All lint checks now pass and structured logging is consistent throughout.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: starbops

internal/executor/cleanup.go

@@ -12,11 +12,10 @@ import (
 
 // CleanupManager handles resource cleanup and container management
 type CleanupManager struct {
-	client       ContainerClient
-	logger       *slog.Logger
-	mu           sync.RWMutex
-	containers   map[string]*ContainerInfo
-	cleanupTimer *time.Timer
+	client     ContainerClient
+	logger     *slog.Logger
+	mu         sync.RWMutex
+	containers map[string]*ContainerInfo
 }
 
 // ContainerInfo tracks information about running containers

internal/executor/docker_client.go

@@ -4,10 +4,11 @@ import (
 	"context"
 	"fmt"
 	"io"
+	"log/slog"
 	"strings"
 	"time"
 
-	"github.com/docker/docker/api/types"
+	"github.com/containerd/errdefs"
 	"github.com/docker/docker/api/types/container"
 	"github.com/docker/docker/api/types/image"
 	"github.com/docker/docker/client"
@@ -18,14 +19,19 @@ import (
 type DockerClient struct {
 	client *client.Client
 	config *Config
+	logger *slog.Logger
 }
 
 // NewDockerClient creates a new Docker client with the given configuration
-func NewDockerClient(config *Config) (*DockerClient, error) {
+func NewDockerClient(config *Config, logger *slog.Logger) (*DockerClient, error) {
 	if config == nil {
 		config = NewDefaultConfig()
 	}
 
+	if logger == nil {
+		logger = slog.Default()
+	}
+
 	if err := config.Validate(); err != nil {
 		return nil, fmt.Errorf("invalid config: %w", err)
 	}
@@ -42,6 +48,7 @@ func NewDockerClient(config *Config) (*DockerClient, error) {
 	dockerClient := &DockerClient{
 		client: cli,
 		config: config,
+		logger: logger,
 	}
 
 	// Test connection
@@ -106,7 +113,7 @@ func (dc *DockerClient) CreateContainer(ctx context.Context, config *ContainerCo
 	if len(resp.Warnings) > 0 {
 		// Log warnings but don't fail
 		for _, warning := range resp.Warnings {
-			fmt.Printf("Container creation warning: %s\n", warning)
+			dc.logger.Warn("container creation warning", "warning", warning)
 		}
 	}
 
@@ -196,7 +203,7 @@ func (dc *DockerClient) RemoveContainer(ctx context.Context, containerID string,
 	err := dc.client.ContainerRemove(ctx, containerID, options)
 	if err != nil {
 		// Don't fail if container is already removed
-		if client.IsErrNotFound(err) {
+		if errdefs.IsNotFound(err) {
 			return nil
 		}
 		return NewContainerError(containerID, "remove_container", "failed to remove container", err)
@@ -219,7 +226,7 @@ func (dc *DockerClient) StopContainer(ctx context.Context, containerID string, t
 	err := dc.client.ContainerStop(ctx, containerID, options)
 	if err != nil {
 		// Don't fail if container is already stopped
-		if client.IsErrNotFound(err) {
+		if errdefs.IsNotFound(err) {
 			return nil
 		}
 		return NewContainerError(containerID, "stop_container", "failed to stop container", err)
@@ -308,7 +315,7 @@ func (dc *DockerClient) demultiplexLogs(logData []byte) (stdout, stderr string)
 }
 
 // GetContainerInfo returns information about a container
-func (dc *DockerClient) GetContainerInfo(ctx context.Context, containerID string) (*types.ContainerJSON, error) {
+func (dc *DockerClient) GetContainerInfo(ctx context.Context, containerID string) (*container.InspectResponse, error) {
 	if containerID == "" {
 		return nil, NewContainerError("", "get_info", "container ID is empty", nil)
 	}

internal/executor/executor.go

@@ -29,7 +29,7 @@ func NewExecutor(config *Config, logger *slog.Logger) (*Executor, error) {
 	}
 
 	// Create Docker client
-	dockerClient, err := NewDockerClient(config)
+	dockerClient, err := NewDockerClient(config, logger)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create Docker client: %w", err)
 	}
@@ -334,14 +334,4 @@ type ExecutorInfo struct {
 // Helper function to create string pointer
 func stringPtr(s string) *string {
 	return &s
-}
-
-// Helper function to create int pointer
-func intPtr(i int) *int {
-	return &i
-}
-
-// Helper function to create int64 pointer
-func int64Ptr(i int64) *int64 {
-	return &i
 }