Don't filter log message with level ERROR and above

The logging filters were being applied to all log messages
regardless of level. However, message with ERROR level and above
should never be filtered.

In addition, the general exception handler used by the emulator
can also be used by the main function, so remove the duplicate
exception handling.

Author: voidtrance

src/lib/logging/logging.c

@@ -395,7 +395,7 @@ int vortex_logger_log(vortex_logger_t *logger, log_level_t level,
     log_stream_t *next;
     char string[2048];
     size_t s = 0;
-    bool do_log;
+    bool do_log = true;
 
     if (!log_setup || !logger)
         return EFAULT;
@@ -407,12 +407,18 @@ int vortex_logger_log(vortex_logger_t *logger, log_level_t level,
         return 0;
 
     /*
-     * Filtering is done with the lock held to protect against
-     * a filter being added while logging is in progress.
+     * Message with levels ERROR and higher (more severe) are
+     * not filtered.
      */
-    pthread_mutex_lock(&log_setup->lock);
-    do_log = filter_record(logger);
-    pthread_mutex_unlock(&log_setup->lock);
+    if (level < LOG_LEVEL_ERROR) {
+        /*
+         * Filtering is done with the lock held to protect against
+         * a filter being added while logging is in progress.
+         */
+        pthread_mutex_lock(&log_setup->lock);
+        do_log = filter_record(logger);
+        pthread_mutex_unlock(&log_setup->lock);
+    }
 
     if (!do_log)
         return 0;

vortex_run.py

@@ -101,11 +101,12 @@ def emulator_exception_handler(exc_class, exc, tb):
     frame = _tb.tb_frame
     co = frame.f_code
     logging.critical(f"Exception occured at {co.co_name}:{frame.f_lineno} [{co.co_filename}]:")
-    logging.critical(f"    {str(exc)}")
+    logging.critical(f"     Exception: {str(exc)}")
     if logging.get_level() <= logging.DEBUG:
         lines = traceback.format_tb(tb)
-        for line in lines:
-            logging.critical("   " + line)
+        for entry in lines:
+            for line in entry.split("\n"):
+                logging.critical("   " + line.rstrip())
 
 def emulator_thread_exception_handler(args):
     emulator_exception_handler(args.exc_type, args.exc_value, args.exc_traceback)
@@ -150,12 +151,6 @@ def main():
         emulation.start()
     except KeyboardInterrupt:
         pass
-    except Exception as e:
-        logging.critical(f"Emulator exception: {e}")
-        if opts.debug.lower() == "debug":
-            lines = traceback.format_exception(e)
-            for line in lines:
-                logging.critical(line)
     finally:
         emulation.stop()