Commit 12e2cbb
committed
fix(injectable): don't default providedIn to 'root' when not specified
@Injectable() and @Injectable({}) were incorrectly defaulting providedIn
to 'root'. Angular's actual behavior is to omit providedIn entirely when
it's not explicitly specified, as confirmed by the official compliance tests.1 parent e698f76 commit 12e2cbb
File tree
2 files changed
+12
-12
lines changed- crates/oxc_angular_compiler/src
- component
- injectable
2 files changed
+12
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4316 | 4316 | | |
4317 | 4317 | | |
4318 | 4318 | | |
4319 | | - | |
| 4319 | + | |
4320 | 4320 | | |
4321 | | - | |
4322 | | - | |
| 4321 | + | |
| 4322 | + | |
4323 | 4323 | | |
4324 | 4324 | | |
4325 | 4325 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
233 | | - | |
| 233 | + | |
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
| 238 | + | |
239 | 239 | | |
240 | 240 | | |
241 | 241 | | |
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
253 | | - | |
254 | | - | |
| 253 | + | |
| 254 | + | |
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
| |||
681 | 681 | | |
682 | 682 | | |
683 | 683 | | |
684 | | - | |
685 | | - | |
| 684 | + | |
| 685 | + | |
686 | 686 | | |
687 | 687 | | |
688 | 688 | | |
| |||
715 | 715 | | |
716 | 716 | | |
717 | 717 | | |
718 | | - | |
| 718 | + | |
719 | 719 | | |
720 | 720 | | |
721 | 721 | | |
| |||
726 | 726 | | |
727 | 727 | | |
728 | 728 | | |
729 | | - | |
730 | | - | |
| 729 | + | |
| 730 | + | |
731 | 731 | | |
732 | 732 | | |
733 | 733 | | |
| |||
0 commit comments