Skip to content

Commit 5e541d4

Browse files
committed
fix(compiler): simplify output vector initialization and format key quoting
1 parent 9330ac1 commit 5e541d4

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

crates/oxc_angular_compiler/src/directive/compiler.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1623,9 +1623,7 @@ mod tests {
16231623
#[test]
16241624
fn test_create_outputs_literal_quotes_dotted_key() {
16251625
let allocator = Allocator::default();
1626-
let outputs = vec![
1627-
(Atom::from("activate.xs"), Atom::from("activateXs")),
1628-
];
1626+
let outputs = vec![(Atom::from("activate.xs"), Atom::from("activateXs"))];
16291627
let expr = create_outputs_literal(&allocator, &outputs).unwrap();
16301628
let emitter = JsEmitter::new();
16311629
let output = emitter.emit_expression(&expr);
@@ -1638,9 +1636,7 @@ mod tests {
16381636
#[test]
16391637
fn test_create_outputs_literal_no_quotes_for_simple_identifier() {
16401638
let allocator = Allocator::default();
1641-
let outputs = vec![
1642-
(Atom::from("activate"), Atom::from("activate")),
1643-
];
1639+
let outputs = vec![(Atom::from("activate"), Atom::from("activate"))];
16441640
let expr = create_outputs_literal(&allocator, &outputs).unwrap();
16451641
let emitter = JsEmitter::new();
16461642
let output = emitter.emit_expression(&expr);

crates/oxc_angular_compiler/src/linker/mod.rs

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,7 @@ fn needs_object_key_quoting(key: &str) -> bool {
5252

5353
/// Quote a property key if it contains unsafe characters (dots or hyphens).
5454
fn quote_key(key: &str) -> String {
55-
if needs_object_key_quoting(key) {
56-
format!("\"{key}\"")
57-
} else {
58-
key.to_string()
59-
}
55+
if needs_object_key_quoting(key) { format!("\"{key}\"") } else { key.to_string() }
6056
}
6157

6258
/// Partial declaration function names to link.
@@ -1314,8 +1310,9 @@ fn convert_inputs_to_definition_format(inputs_obj: &ObjectExpression<'_>, source
13141310
"{quoted_key}: [{flags}, \"{public_name}\", \"{declared_name}\", {transform_fn}]"
13151311
));
13161312
} else {
1317-
entries
1318-
.push(format!("{quoted_key}: [{flags}, \"{public_name}\", \"{declared_name}\"]"));
1313+
entries.push(format!(
1314+
"{quoted_key}: [{flags}, \"{public_name}\", \"{declared_name}\"]"
1315+
));
13191316
}
13201317
}
13211318
// Unknown format, keep as is

0 commit comments

Comments
 (0)