Commit 872f726
fix: account for non-Angular decorators when inserting decls_before_class (#63)
* fix: account for non-Angular decorators when inserting decls_before_class
When a class has non-Angular decorators (e.g., @log), the const
declarations (_c0, etc.) were inserted between the decorator and
the class statement, producing invalid syntax. Now checks decorator
span positions to insert before any preceding decorators.
Vite/Rolldown's built-in oxc_transformer handles the TS-to-JS
conversion (type stripping, decorator lowering) downstream, so no
additional transform step is needed in the Angular compiler.
Also adds a custom decorator to the playground for testing.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* test: add custom decorator e2e fixtures
Add edge-case fixtures for components with non-Angular class
decorators (single and multiple). Verifies the Angular compiler
preserves custom decorators without breaking generated code.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>1 parent 55ab818 commit 872f726
File tree
4 files changed
+80
-1
lines changed- crates/oxc_angular_compiler/src/component
- napi
- angular-compiler/e2e/compare/fixtures/edge-cases
- playground/src/app
4 files changed
+80
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1313 | 1313 | | |
1314 | 1314 | | |
1315 | 1315 | | |
1316 | | - | |
| 1316 | + | |
| 1317 | + | |
| 1318 | + | |
| 1319 | + | |
| 1320 | + | |
| 1321 | + | |
| 1322 | + | |
| 1323 | + | |
| 1324 | + | |
| 1325 | + | |
1317 | 1326 | | |
1318 | 1327 | | |
1319 | 1328 | | |
| |||
Lines changed: 61 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
4 | 7 | | |
5 | 8 | | |
6 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
0 commit comments