save

Author: Brooooooklyn

crates/oxc_angular_compiler/src/pipeline/phases/temporary_variables.rs

@@ -305,13 +305,15 @@ fn generate_temporaries_for_update<'a>(
 }
 
 /// Creates a DeclareVarStmt without an initializer.
-/// This matches Angular's behavior for temp variable declarations: `const tmp_X_Y;`
+/// This matches Angular's behavior for temp variable declarations: `var tmp_X_Y;`
+/// Note: Angular uses `var` (not `const`) for uninitialized temp variables.
+/// See: packages/compiler/src/output/abstract_js_emitter.ts line 6760
 fn create_declare_var_statement<'a>(allocator: &'a Allocator, name: &str) -> OutputStatement<'a> {
     OutputStatement::DeclareVar(oxc_allocator::Box::new_in(
         DeclareVarStmt {
             name: Atom::from(allocator.alloc_str(name)),
             value: None,
-            modifiers: StmtModifier::FINAL,
+            modifiers: StmtModifier::NONE, // Use `var` since there's no initializer
             leading_comment: None,
             source_span: None,
         },

crates/oxc_angular_compiler/tests/snapshots/integration_test__conditional_alias_with_binding_and_listener.snap

@@ -27,7 +27,7 @@ function TestComponent_Conditional_0_Template(rf,ctx) {
 function TestComponent_Template(rf,ctx) {
   if ((rf & 1)) { i0.ɵɵconditionalCreate(0,TestComponent_Conditional_0_Template,4,3); }
   if ((rf & 2)) {
-    const tmp_0_0;
+    var tmp_0_0;
     i0.ɵɵconditional(((tmp_0_0 = ctx.getParent(ctx.renderedOptions))? 0: -1),tmp_0_0);
   }
 }

crates/oxc_angular_compiler/tests/snapshots/integration_test__conditional_alias_with_listener.snap

@@ -20,7 +20,7 @@ function TestComponent_Conditional_0_Template(rf,ctx) {
 function TestComponent_Template(rf,ctx) {
   if ((rf & 1)) { i0.ɵɵconditionalCreate(0,TestComponent_Conditional_0_Template,4,0); }
   if ((rf & 2)) {
-    const tmp_0_0;
+    var tmp_0_0;
     i0.ɵɵconditional(((tmp_0_0 = ctx.getParent(ctx.renderedOptions))? 0: -1),tmp_0_0);
   }
 }

crates/oxc_angular_compiler/tests/snapshots/integration_test__if_alias_with_switch.snap

@@ -37,7 +37,7 @@ function TestComponent_Conditional_0_Template(rf,ctx) {
     i0.ɵɵtext(4,"\n");
   }
   if ((rf & 2)) {
-    const tmp_2_0;
+    var tmp_2_0;
     i0.ɵɵadvance();
     i0.ɵɵconditional((((tmp_2_0 = ctx.message.type) === "ConfirmNewCredential")? 1: ((tmp_2_0 === "PickCredential")? 2: 3)));
   }
@@ -48,7 +48,7 @@ function TestComponent_Template(rf,ctx) {
     i0.ɵɵpipe(1,"async");
   }
   if ((rf & 2)) {
-    const tmp_0_0;
+    var tmp_0_0;
     i0.ɵɵconditional(((tmp_0_0 = i0.ɵɵpipeBind1(1,1,ctx.data$))? 0: -1),tmp_0_0);
   }
 }

crates/oxc_angular_compiler/tests/snapshots/integration_test__pipe_in_if_object_literal.snap

@@ -23,7 +23,7 @@ function TestComponent_Template(rf,ctx) {
     i0.ɵɵpipe(2,"async");
   }
   if ((rf & 2)) {
-    const tmp_0_0;
+    var tmp_0_0;
     i0.ɵɵconditional(((tmp_0_0 = i0.ɵɵpureFunction2(5,_c0,i0.ɵɵpipeBind1(1,1,ctx.value),
         i0.ɵɵpipeBind1(2,3,ctx.overlay)))? 0: -1),tmp_0_0);
   }

crates/oxc_angular_compiler/tests/snapshots/integration_test__switch_block.snap

@@ -33,7 +33,7 @@ function TestComponent_Template(rf,ctx) {
   if ((rf & 1)) { i0.ɵɵconditionalCreate(0,TestComponent_Case_0_Template,4,0)(1,TestComponent_Case_1_Template,
       4,0)(2,TestComponent_Case_2_Template,4,0); }
   if ((rf & 2)) {
-    const tmp_0_0;
+    var tmp_0_0;
     i0.ɵɵconditional((((tmp_0_0 = ctx.value) === 1)? 0: ((tmp_0_0 === 2)? 1: 2)));
   }
 }

crates/oxc_angular_compiler/tests/snapshots/integration_test__switch_inside_for.snap

@@ -38,7 +38,7 @@ function TestComponent_For_1_Template(rf,ctx) {
     i0.ɵɵtext(4," ");
   }
   if ((rf & 2)) {
-    const tmp_10_0;
+    var tmp_10_0;
     const item_r1 = ctx.$implicit;
     i0.ɵɵadvance();
     i0.ɵɵconditional((((tmp_10_0 = item_r1.type) === "a")? 1: ((tmp_10_0 === "b")? 2: 3)));

napi/angular-compiler/benchmarks/bitwarden/.gitignore

@@ -0,0 +1,23 @@
+# Dependencies
+node_modules/
+
+# Build output
+dist/
+
+# Logs
+*.log
+npm-debug.log*
+pnpm-debug.log*
+
+# IDE
+.idea/
+.vscode/
+*.swp
+*.swo
+
+# OS files
+.DS_Store
+Thumbs.db
+
+# Benchmark artifacts
+stats.json

napi/angular-compiler/benchmarks/bitwarden/README.md

@@ -0,0 +1,133 @@
+# Bitwarden Web Vault - OXC Angular Benchmark
+
+This benchmark compares the build performance of the OXC Angular Compiler (via Vite) against Angular's `@ngtools/webpack` (bitwarden's existing webpack build).
+
+## Prerequisites
+
+1. **Clone bitwarden-clients** repository as a sibling to the oxc repository:
+
+   ```bash
+   cd ~/workspace/github  # or wherever your repos are
+   git clone https://github.com/bitwarden/clients.git bitwarden-clients
+   ```
+
+2. **Install bitwarden dependencies**:
+
+   ```bash
+   cd bitwarden-clients
+   pnpm install
+   ```
+
+3. **Install benchmark dependencies**:
+   ```bash
+   cd oxc/napi/angular-compiler/benchmarks/bitwarden
+   pnpm install
+   ```
+
+## Usage
+
+### Run Full Benchmark
+
+Runs both cold build and incremental build comparisons:
+
+```bash
+pnpm benchmark
+```
+
+### Run Specific Benchmarks
+
+```bash
+# Only cold build comparison
+pnpm benchmark --cold
+
+# Only incremental build comparison
+pnpm benchmark --incremental
+
+# Only test Vite/OXC build (skip webpack)
+pnpm benchmark --vite-only
+
+# Only test Webpack build (skip Vite)
+pnpm benchmark --webpack-only
+
+# Custom number of iterations
+pnpm benchmark --iterations=5
+
+# Verbose output
+pnpm benchmark --verbose
+```
+
+### Development Server
+
+Start the Vite dev server for interactive testing:
+
+```bash
+pnpm dev
+```
+
+### Production Build
+
+Build with Vite/OXC only:
+
+```bash
+pnpm build
+```
+
+## Configuration
+
+### Path Customization
+
+If your bitwarden-clients repository is in a different location, update the `BITWARDEN_ROOT` path in:
+
+- `vite.config.ts`
+- `benchmark.ts`
+- `postcss.config.cjs`
+- `tailwind.config.cjs`
+- `tsconfig.app.json`
+
+### Vite Configuration
+
+The `vite.config.ts` includes:
+
+- **vite-tsconfig-paths**: Resolves 70+ path aliases from bitwarden's tsconfig
+- **@oxc/vite-plugin-angular**: OXC's Angular compiler plugin
+- **SCSS preprocessing**: With proper include paths for bitwarden's styles
+- **PostCSS**: Matching bitwarden's configuration (tailwind, autoprefixer, etc.)
+- **process.env polyfills**: For bitwarden's environment variable usage
+
+## What's Being Compared
+
+| Aspect           | Vite/OXC            | Webpack/@ngtools              |
+| ---------------- | ------------------- | ----------------------------- |
+| Bundler          | Vite (esbuild)      | Webpack                       |
+| Angular Compiler | OXC (Rust)          | @ngtools/webpack (TypeScript) |
+| CSS Processing   | Vite's CSS pipeline | MiniCssExtractPlugin          |
+| Source Maps      | Vite native         | Webpack devtool               |
+
+## Expected Results
+
+Based on initial testing, OXC's Rust-based Angular compiler typically provides:
+
+- **Cold builds**: 2-5x faster than webpack
+- **Incremental builds**: 5-10x faster than webpack
+- **Output size**: Comparable (may vary based on tree-shaking differences)
+
+## Troubleshooting
+
+### "bitwarden-clients not found"
+
+Ensure the bitwarden-clients repository is cloned to the expected location (sibling to oxc directory).
+
+### "Failed to resolve import"
+
+Path aliases may need adjustment. Check that:
+
+1. bitwarden's `tsconfig.base.json` is accessible
+2. vite-tsconfig-paths plugin is configured correctly
+
+### "Cannot find module '@angular/...'"
+
+Run `pnpm install` in both the benchmark directory and bitwarden-clients.
+
+### Style/CSS errors
+
+SCSS include paths may need adjustment based on bitwarden's structure.