Skip to content

Commit 6b6c4c0

Browse files
authored
refactor(ci): drop registry-url, rely on project .npmrc for auth (#11)
## Summary Refactor CI/deploy workflows to use the new `setup-vp` behavior from [voidzero-dev/setup-vp#54](voidzero-dev/setup-vp#54). - Drop `registry-url: https://npm.pkg.github.com` from all `setup-vp` steps in `.github/workflows/ci.yml` and `.github/workflows/deploy.yml`. - Rely on the repo-level `.npmrc` (`@void-sdk:registry=https://npm.pkg.github.com`) plus `NODE_AUTH_TOKEN` env: the action auto-generates a matching `_authToken` entry at `$RUNNER_TEMP/.npmrc` for each registry declared in the project `.npmrc` that doesn't already have one. - The checked-in `.npmrc` stays minimal — no auth line needed. ## Pinning Pinned to commit `af4ffd95e8c3d93e048fe8f03afeb2d4e3eba927` (head of PR #54's `fix/respect-project-npmrc` branch) via a commented SHA. Bump back to `@v1` once the PR merges and is released. ## Test plan - [ ] `test` job on this PR runs `vp install` successfully (private `@void-sdk/*` packages resolve from GitHub Packages) - [ ] `staging-deploy` job on this PR completes `vpx void deploy`
1 parent 2f54da2 commit 6b6c4c0

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,9 @@ jobs:
1414
runs-on: ubuntu-latest
1515
steps:
1616
- uses: actions/checkout@v6
17-
- uses: voidzero-dev/setup-vp@v1
17+
- uses: voidzero-dev/setup-vp@4f5aa3e38c781f1b01e78fb9255527cee8a6efa6 # v1.8.0
1818
with:
1919
cache: true
20-
registry-url: https://npm.pkg.github.com
2120
env:
2221
NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }}
2322
- run: vp check
@@ -30,10 +29,9 @@ jobs:
3029
runs-on: ubuntu-latest
3130
steps:
3231
- uses: actions/checkout@v6
33-
- uses: voidzero-dev/setup-vp@v1
32+
- uses: voidzero-dev/setup-vp@4f5aa3e38c781f1b01e78fb9255527cee8a6efa6 # v1.8.0
3433
with:
3534
cache: true
36-
registry-url: https://npm.pkg.github.com
3735
env:
3836
NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }}
3937
- run: vpx void deploy

.github/workflows/deploy.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@ jobs:
99
runs-on: ubuntu-latest
1010
steps:
1111
- uses: actions/checkout@v6
12-
- uses: voidzero-dev/setup-vp@v1
12+
- uses: voidzero-dev/setup-vp@4f5aa3e38c781f1b01e78fb9255527cee8a6efa6 # v1.8.0
1313
with:
1414
cache: true
15-
registry-url: https://npm.pkg.github.com
1615
env:
1716
NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }}
1817
- run: vpx void deploy

0 commit comments

Comments
 (0)