fix(install): validate adjacent npm before use

Author: lyzno1

crates/vite_global_cli/src/commands/mod.rs

@@ -120,7 +120,12 @@ pub(crate) fn managed_npm_bin_for_global_command(
     }
 
     let npm_bin = npm_bin_path_from_node_bin_prefix(node_bin_prefix);
-    npm_bin.as_path().exists().then_some(npm_bin)
+    vite_command::resolve_bin(
+        npm_bin.as_path().as_os_str().to_string_lossy().as_ref(),
+        None,
+        node_bin_prefix,
+    )
+    .ok()
 }
 
 /// Build a PackageManager, converting PackageJsonNotFound into a friendly error message.
@@ -218,17 +223,35 @@ mod tests {
     use super::*;
 
     #[test]
-    fn test_managed_npm_bin_for_global_command_uses_existing_adjacent_npm() {
+    fn test_managed_npm_bin_for_global_command_uses_executable_adjacent_npm() {
         let temp_dir = tempfile::tempdir().unwrap();
         let node_bin_prefix = AbsolutePathBuf::new(temp_dir.path().to_path_buf()).unwrap();
         let expected = npm_bin_path_from_node_bin_prefix(&node_bin_prefix);
         std::fs::write(&expected, "").unwrap();
+        #[cfg(unix)]
+        {
+            use std::os::unix::fs::PermissionsExt;
+            let mut permissions = std::fs::metadata(&expected).unwrap().permissions();
+            permissions.set_mode(0o755);
+            std::fs::set_permissions(&expected, permissions).unwrap();
+        }
 
         let npm_bin = managed_npm_bin_for_global_command(true, &node_bin_prefix).unwrap();
         assert_eq!(npm_bin, expected);
         assert!(managed_npm_bin_for_global_command(false, &node_bin_prefix).is_none());
     }
 
+    #[cfg(unix)]
+    #[test]
+    fn test_managed_npm_bin_for_global_command_falls_back_when_adjacent_npm_is_not_executable() {
+        let temp_dir = tempfile::tempdir().unwrap();
+        let node_bin_prefix = AbsolutePathBuf::new(temp_dir.path().to_path_buf()).unwrap();
+        let npm_bin = npm_bin_path_from_node_bin_prefix(&node_bin_prefix);
+        std::fs::write(&npm_bin, "").unwrap();
+
+        assert!(managed_npm_bin_for_global_command(true, &node_bin_prefix).is_none());
+    }
+
     #[test]
     fn test_managed_npm_bin_for_global_command_falls_back_when_adjacent_npm_is_missing() {
         let temp_dir = tempfile::tempdir().unwrap();