style: apply formatting fixes from vp check --fix

fengmk2 · fengmk2 · commit 0264102262f7 · 2026-04-04T20:19:52.000+08:00
diff --git a/crates/vite_installer/src/cli.rs b/crates/vite_installer/src/cli.rs
@@ -55,9 +55,8 @@ pub fn parse() -> Options {
         opts.registry = std::env::var("NPM_CONFIG_REGISTRY").ok();
     }
     if !opts.no_node_manager {
-        opts.no_node_manager = std::env::var("VP_NODE_MANAGER")
-            .ok()
-            .is_some_and(|v| v.eq_ignore_ascii_case("no"));
+        opts.no_node_manager =
+            std::env::var("VP_NODE_MANAGER").ok().is_some_and(|v| v.eq_ignore_ascii_case("no"));
     }
 
     // quiet implies yes
diff --git a/crates/vite_installer/src/main.rs b/crates/vite_installer/src/main.rs
@@ -109,11 +109,7 @@ async fn do_install(
     if let Some(ref current) = current_version {
         if current == &resolved.version {
             if !opts.quiet {
-                println!(
-                    "\n{} Already installed ({})",
-                    "\u{2714}".green(),
-                    resolved.version
-                );
+                println!("\n{} Already installed ({})", "\u{2714}".green(), resolved.version);
             }
             return Ok(());
         }
@@ -285,16 +281,10 @@ async fn download_with_progress(
     Ok(data)
 }
 
-fn resolve_install_dir(
-    opts: &cli::Options,
-) -> Result<AbsolutePathBuf, Box<dyn std::error::Error>> {
+fn resolve_install_dir(opts: &cli::Options) -> Result<AbsolutePathBuf, Box<dyn std::error::Error>> {
     if let Some(ref dir) = opts.install_dir {
         let path = std::path::PathBuf::from(dir);
-        let abs = if path.is_absolute() {
-            path
-        } else {
-            std::env::current_dir()?.join(path)
-        };
+        let abs = if path.is_absolute() { path } else { std::env::current_dir()?.join(path) };
         AbsolutePathBuf::new(abs).ok_or_else(|| "Invalid installation directory".into())
     } else {
         Ok(vite_shared::get_vp_home()?)
@@ -332,9 +322,20 @@ fn show_interactive_menu(opts: &cli::Options, install_dir: &str) -> bool {
     println!("  This will install the {} CLI and monorepo task runner.", "vp".cyan());
     println!();
     println!("    Install directory: {}", install_dir.cyan());
-    println!("    PATH modification: {}", if opts.no_modify_path { "no".to_string() } else { format!("{bin_dir} \u{2192} User PATH") }.cyan());
+    println!(
+        "    PATH modification: {}",
+        if opts.no_modify_path {
+            "no".to_string()
+        } else {
+            format!("{bin_dir} \u{2192} User PATH")
+        }
+        .cyan()
+    );
     println!("    Version:           {}", version.cyan());
-    println!("    Node.js manager:   {}", if opts.no_node_manager { "disabled" } else { "auto-detect" }.cyan());
+    println!(
+        "    Node.js manager:   {}",
+        if opts.no_node_manager { "disabled" } else { "auto-detect" }.cyan()
+    );
     println!();
     println!("  1) {} (default)", "Proceed with installation".bold());
     println!("  2) Cancel");
@@ -358,10 +359,7 @@ fn print_success(opts: &cli::Options, install_dir: &str) {
     }
 
     println!();
-    println!(
-        "  {} Vite+ has been installed successfully!",
-        "\u{2714}".green().bold()
-    );
+    println!("  {} Vite+ has been installed successfully!", "\u{2714}".green().bold());
     println!();
     println!("  To get started, restart your terminal, then run:");
     println!();
diff --git a/crates/vite_installer/src/windows_path.rs b/crates/vite_installer/src/windows_path.rs
@@ -84,13 +84,7 @@ fn read_user_path() -> io::Result<String> {
 
     let mut hkey: ffi::HKEY = 0;
     let result = unsafe {
-        ffi::RegOpenKeyExW(
-            ffi::HKEY_CURRENT_USER,
-            sub_key.as_ptr(),
-            0,
-            ffi::KEY_READ,
-            &mut hkey,
-        )
+        ffi::RegOpenKeyExW(ffi::HKEY_CURRENT_USER, sub_key.as_ptr(), 0, ffi::KEY_READ, &mut hkey)
     };
 
     if result == ffi::ERROR_FILE_NOT_FOUND {
@@ -143,10 +137,7 @@ fn read_user_path() -> io::Result<String> {
     }
 
     // Convert UTF-16 to String (strip trailing null)
-    let wide: Vec<u16> = buf
-        .chunks_exact(2)
-        .map(|c| u16::from_le_bytes([c[0], c[1]]))
-        .collect();
+    let wide: Vec<u16> = buf.chunks_exact(2).map(|c| u16::from_le_bytes([c[0], c[1]])).collect();
     let s = String::from_utf16_lossy(&wide);
     Ok(s.trim_end_matches('\0').to_string())
 }
@@ -159,13 +150,7 @@ fn write_user_path(path: &str) -> io::Result<()> {
 
     let mut hkey: ffi::HKEY = 0;
     let result = unsafe {
-        ffi::RegOpenKeyExW(
-            ffi::HKEY_CURRENT_USER,
-            sub_key.as_ptr(),
-            0,
-            ffi::KEY_WRITE,
-            &mut hkey,
-        )
+        ffi::RegOpenKeyExW(ffi::HKEY_CURRENT_USER, sub_key.as_ptr(), 0, ffi::KEY_WRITE, &mut hkey)
     };
 
     if result != ffi::ERROR_SUCCESS {
@@ -230,11 +215,8 @@ pub fn add_to_user_path(bin_dir: &str) -> io::Result<()> {
     }
 
     // Prepend to PATH
-    let new_path = if current.is_empty() {
-        bin_dir.to_string()
-    } else {
-        format!("{bin_dir};{current}")
-    };
+    let new_path =
+        if current.is_empty() { bin_dir.to_string() } else { format!("{bin_dir};{current}") };
 
     write_user_path(&new_path)?;
     broadcast_settings_change();
diff --git a/rfcs/windows-installer.md b/rfcs/windows-installer.md
@@ -59,6 +59,7 @@ rustup provides `rustup-init.exe` — a single console binary that users downloa
 rustup uses one binary for everything — `rustup-init.exe` copies itself to `~/.cargo/bin/rustup.exe` and changes behavior based on `argv[0]`. This works because rustup IS the toolchain manager.
 
 **Not suitable for vp** because:
+
 - `vp.exe` is downloaded from the npm registry as a platform-specific package
 - The installer cannot copy itself as `vp.exe` — they are fundamentally different binaries
 - `vp.exe` links `vite_js_runtime`, `vite_workspace`, `oxc_resolver` (~15-20 MB) — the installer needs none of these
@@ -75,6 +76,7 @@ crates/vite_installer/      — standalone installer binary
 `vite_setup` extracts the reusable installation logic currently in `vite_global_cli/src/commands/upgrade/`. Both `vp upgrade` and `vp-setup.exe` call into `vite_setup`.
 
 **Benefits:**
+
 - Installer binary stays small (3-5 MB)
 - `vp upgrade` and `vp-setup.exe` share identical installation logic — no drift
 - Clear separation of concerns
@@ -83,17 +85,17 @@ crates/vite_installer/      — standalone installer binary
 
 ### What Gets Extracted
 
-| Current location in `upgrade/` | Extracted to `vite_setup::` | Purpose |
-|---|---|---|
-| `platform.rs` → `detect_platform_suffix()` | `platform` | OS/arch detection |
-| `registry.rs` → `resolve_version()`, `resolve_platform_package()` | `registry` | npm registry queries |
-| `integrity.rs` → `verify_integrity()` | `integrity` | SHA-512 verification |
-| `install.rs` → `extract_platform_package()` | `extract` | Tarball extraction |
-| `install.rs` → `generate_wrapper_package_json()` | `package_json` | Wrapper package.json |
-| `install.rs` → `write_release_age_overrides()` | `npmrc` | .npmrc overrides |
-| `install.rs` → `install_production_deps()` | `deps` | Run `vp install --silent` |
-| `install.rs` → `swap_current_link()` | `link` | Symlink/junction swap |
-| `install.rs` → `cleanup_old_versions()` | `cleanup` | Old version cleanup |
+| Current location in `upgrade/`                                    | Extracted to `vite_setup::` | Purpose                   |
+| ----------------------------------------------------------------- | --------------------------- | ------------------------- |
+| `platform.rs` → `detect_platform_suffix()`                        | `platform`                  | OS/arch detection         |
+| `registry.rs` → `resolve_version()`, `resolve_platform_package()` | `registry`                  | npm registry queries      |
+| `integrity.rs` → `verify_integrity()`                             | `integrity`                 | SHA-512 verification      |
+| `install.rs` → `extract_platform_package()`                       | `extract`                   | Tarball extraction        |
+| `install.rs` → `generate_wrapper_package_json()`                  | `package_json`              | Wrapper package.json      |
+| `install.rs` → `write_release_age_overrides()`                    | `npmrc`                     | .npmrc overrides          |
+| `install.rs` → `install_production_deps()`                        | `deps`                      | Run `vp install --silent` |
+| `install.rs` → `swap_current_link()`                              | `link`                      | Symlink/junction swap     |
+| `install.rs` → `cleanup_old_versions()`                           | `cleanup`                   | Old version cleanup       |
 
 ### What Stays in `vite_global_cli`
 
@@ -176,24 +178,24 @@ vp-setup.exe -y --version 0.3.0 --no-node-manager --registry https://registry.np
 
 ### CLI Flags
 
-| Flag | Description | Default |
-|---|---|---|
-| `-y` / `--yes` | Accept defaults, no prompts | interactive |
-| `-q` / `--quiet` | Suppress output except errors | false |
-| `--version <VER>` | Install specific version | latest |
-| `--tag <TAG>` | npm dist-tag | latest |
-| `--install-dir <PATH>` | Installation directory | `%USERPROFILE%\.vite-plus` |
-| `--registry <URL>` | npm registry URL | `https://registry.npmjs.org` |
-| `--no-node-manager` | Skip Node.js manager setup | auto-detect |
-| `--no-modify-path` | Don't modify User PATH | modify |
+| Flag                   | Description                   | Default                      |
+| ---------------------- | ----------------------------- | ---------------------------- |
+| `-y` / `--yes`         | Accept defaults, no prompts   | interactive                  |
+| `-q` / `--quiet`       | Suppress output except errors | false                        |
+| `--version <VER>`      | Install specific version      | latest                       |
+| `--tag <TAG>`          | npm dist-tag                  | latest                       |
+| `--install-dir <PATH>` | Installation directory        | `%USERPROFILE%\.vite-plus`   |
+| `--registry <URL>`     | npm registry URL              | `https://registry.npmjs.org` |
+| `--no-node-manager`    | Skip Node.js manager setup    | auto-detect                  |
+| `--no-modify-path`     | Don't modify User PATH        | modify                       |
 
 ### Environment Variables (compatible with `install.ps1`)
 
-| Variable | Maps to |
-|---|---|
-| `VP_VERSION` | `--version` |
-| `VP_HOME` | `--install-dir` |
-| `NPM_CONFIG_REGISTRY` | `--registry` |
+| Variable                  | Maps to             |
+| ------------------------- | ------------------- |
+| `VP_VERSION`              | `--version`         |
+| `VP_HOME`                 | `--install-dir`     |
+| `NPM_CONFIG_REGISTRY`     | `--registry`        |
 | `VP_NODE_MANAGER=yes\|no` | `--no-node-manager` |
 
 CLI flags take precedence over environment variables.
@@ -300,13 +302,13 @@ The binary uses the console subsystem (default for Rust binaries on Windows). Wh
 
 ### Existing Installation Handling
 
-| Scenario | Behavior |
-|---|---|
-| No existing install | Fresh install |
-| Same version installed | Print "already up to date", exit 0 |
-| Different version installed | Upgrade to target version |
-| Corrupt/partial install (broken junction) | Recreate directory structure |
-| Running `vp.exe` in bin/ | Rename to `.old`, copy new (same as trampoline pattern) |
+| Scenario                                  | Behavior                                                |
+| ----------------------------------------- | ------------------------------------------------------- |
+| No existing install                       | Fresh install                                           |
+| Same version installed                    | Print "already up to date", exit 0                      |
+| Different version installed               | Upgrade to target version                               |
+| Corrupt/partial install (broken junction) | Recreate directory structure                            |
+| Running `vp.exe` in bin/                  | Rename to `.old`, copy new (same as trampoline pattern) |
 
 ## Add/Remove Programs Registration
 
@@ -402,17 +404,17 @@ Target: 3-5 MB (release, stripped, LTO).
 
 Key dependencies and their approximate contribution:
 
-| Dependency | Purpose | Size impact |
-|---|---|---|
-| `reqwest` + `native-tls-vendored` | HTTP + TLS | ~1.5 MB |
-| `flate2` + `tar` | Tarball extraction | ~200 KB |
-| `clap` | CLI parsing | ~300 KB |
-| `tokio` (minimal features) | Async runtime | ~400 KB |
-| `indicatif` | Progress bars | ~100 KB |
-| `sha2` | Integrity verification | ~50 KB |
-| `serde_json` | Registry JSON parsing | ~200 KB |
-| `winreg` | Windows registry | ~50 KB |
-| Rust std + overhead | | ~500 KB |
+| Dependency                        | Purpose                | Size impact |
+| --------------------------------- | ---------------------- | ----------- |
+| `reqwest` + `native-tls-vendored` | HTTP + TLS             | ~1.5 MB     |
+| `flate2` + `tar`                  | Tarball extraction     | ~200 KB     |
+| `clap`                            | CLI parsing            | ~300 KB     |
+| `tokio` (minimal features)        | Async runtime          | ~400 KB     |
+| `indicatif`                       | Progress bars          | ~100 KB     |
+| `sha2`                            | Integrity verification | ~50 KB      |
+| `serde_json`                      | Registry JSON parsing  | ~200 KB     |
+| `winreg`                          | Windows registry       | ~50 KB      |
+| Rust std + overhead               |                        | ~500 KB     |
 
 Use `opt-level = "z"` (optimize for size) in package profile override, matching the trampoline approach.
 
@@ -421,6 +423,7 @@ Use `opt-level = "z"` (optimize for size) in package profile override, matching
 ### 1. MSI/NSIS/Inno Setup Installer (Rejected)
 
 Traditional Windows installers provide GUI, Add/Remove Programs, and Start Menu integration. However:
+
 - Adds build-time dependency on external tooling (WiX, NSIS)
 - GUI is unnecessary for a developer CLI tool
 - MSI has complex authoring requirements
@@ -478,11 +481,13 @@ Embed the PowerShell script in a self-extracting exe. Fragile, still requires Po
 ## Testing Strategy
 
 ### Unit Tests
+
 - Platform detection (mock different architectures)
 - PATH modification logic (registry read/write)
 - Version comparison and existing install detection
 
 ### Integration Tests (CI)
+
 - Fresh install from cmd.exe, PowerShell, Git Bash
 - Silent mode (`-y`) installation
 - Custom registry, custom install dir
@@ -491,6 +496,7 @@ Embed the PowerShell script in a self-extracting exe. Fragile, still requires Po
 - Verify PATH is modified correctly
 
 ### Manual Tests
+
 - Double-click from Downloads folder
 - SmartScreen behavior (signed vs unsigned)
 - Windows Defender scan behavior

Original file line number	Diff line number	Diff line change
`@@ -55,9 +55,8 @@ pub fn parse() -> Options {`
`55`	`55`	`opts.registry = std::env::var("NPM_CONFIG_REGISTRY").ok();`
`56`	`56`	`}`
`57`	`57`	`if !opts.no_node_manager {`
`58`		`- opts.no_node_manager = std::env::var("VP_NODE_MANAGER")`
`59`		`- .ok()`
`60`		`- .is_some_and(\|v\| v.eq_ignore_ascii_case("no"));`
	`58`	`+ opts.no_node_manager =`
	`59`	`+ std::env::var("VP_NODE_MANAGER").ok().is_some_and(\|v\| v.eq_ignore_ascii_case("no"));`
`61`	`60`	`}`
`62`	`61`
`63`	`62`	`// quiet implies yes`