Skip to content

Commit 0440e4e

Browse files
committed
ci(ecosystem): drop pnpm.overrides.playwright injection from patch-project.ts
Pre-version-bumping each project (so its lockfile resolves playwright >= 1.60 directly) is the right place to enforce the version — overriding it inside patch-project.ts produced several pitfalls: - pkg.pnpm.overrides is ignored by npm-managed projects (vitest-playwright-repro uses npm); the override never reached the lockfile and the wedge returned - override targeted the bare `playwright` package, missing vitepress which depends on `playwright-chromium` - writing pkg.pnpm before vp migrate flipped migrator branches and could mask upstream pnpm-workspace.yaml overrides on forceFreshMigration projects The repo.json `"playwright": true` flag still drives the workflow's "Install Playwright chromium" step; the actual version pinning will be handled at the upstream project level instead.
1 parent feb29f7 commit 0440e4e

1 file changed

Lines changed: 0 additions & 16 deletions

File tree

ecosystem-ci/patch-project.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,22 +24,6 @@ const cwd = directory ? join(repoRoot, directory) : repoRoot;
2424
// run vp migrate
2525
const cli = process.env.VP_CLI_BIN ?? 'vp';
2626

27-
// Projects that need Playwright (declared via `playwright: true` in repo.json)
28-
// must use Playwright >= 1.60.0, otherwise `npx playwright install chromium`
29-
// wedges after the download bar reaches 100% under Node 24.16.0+
30-
// (microsoft/playwright#40724, fixed in 1.60.0 via microsoft/playwright#40747).
31-
// Force the version uniformly via pnpm overrides so it covers direct deps,
32-
// catalog entries, and transitive-only (e.g. @vitest/browser-playwright) cases.
33-
const needsPlaywright = 'playwright' in repoConfig && repoConfig.playwright;
34-
if (needsPlaywright) {
35-
const pkgPath = join(cwd, 'package.json');
36-
const pkg = JSON.parse(await readFile(pkgPath, 'utf-8'));
37-
pkg.pnpm ??= {};
38-
pkg.pnpm.overrides ??= {};
39-
pkg.pnpm.overrides.playwright = '^1.60.0';
40-
await writeFile(pkgPath, `${JSON.stringify(pkg, null, 2)}\n`, 'utf-8');
41-
}
42-
4327
if (project === 'rollipop') {
4428
const oxfmtrc = await readFile(join(repoRoot, '.oxfmtrc.json'), 'utf-8');
4529
await writeFile(

0 commit comments

Comments
 (0)