refactor: extract refresh_shims helper in install scripts

Extract the repeated "run vp env setup --refresh, show output only on
failure" pattern into Refresh-Shims (install.ps1) and refresh_shims
(install.sh) helper functions, called from 4 places each.

Author: fengmk2

packages/cli/install.ps1

@@ -183,6 +183,16 @@ function Configure-UserPath {
     return "true"
 }
 
+# Run vp env setup --refresh, showing output only on failure
+function Refresh-Shims {
+    param([string]$BinDir)
+    $setupOutput = & "$BinDir\vp.exe" env setup --refresh 2>&1
+    if ($LASTEXITCODE -ne 0) {
+        Write-Warn "Failed to refresh shims:"
+        Write-Host "$setupOutput"
+    }
+}
+
 # Setup Node.js version manager (node/npm/npx shims)
 # Returns: "true" = enabled, "false" = not enabled, "already" = already configured
 function Setup-NodeManager {
@@ -193,21 +203,13 @@ function Setup-NodeManager {
     # Check if Vite+ is already managing Node.js (bin\node.exe exists)
     if (Test-Path "$binPath\node.exe") {
         # Already managing Node.js, just refresh shims
-        $setupOutput = & "$BinDir\vp.exe" env setup --refresh 2>&1
-        if ($LASTEXITCODE -ne 0) {
-            Write-Warn "Failed to refresh shims:"
-            Write-Host "$setupOutput"
-        }
+        Refresh-Shims -BinDir $BinDir
         return "already"
     }
 
     # Auto-enable on CI environment
     if ($env:CI) {
-        $setupOutput = & "$BinDir\vp.exe" env setup --refresh 2>&1
-        if ($LASTEXITCODE -ne 0) {
-            Write-Warn "Failed to refresh shims:"
-            Write-Host "$setupOutput"
-        }
+        Refresh-Shims -BinDir $BinDir
         return "true"
     }
 
@@ -216,11 +218,7 @@ function Setup-NodeManager {
 
     # Auto-enable if no node available on system
     if (-not $nodeAvailable) {
-        $setupOutput = & "$BinDir\vp.exe" env setup --refresh 2>&1
-        if ($LASTEXITCODE -ne 0) {
-            Write-Warn "Failed to refresh shims:"
-            Write-Host "$setupOutput"
-        }
+        Refresh-Shims -BinDir $BinDir
         return "true"
     }
 
@@ -232,11 +230,7 @@ function Setup-NodeManager {
         $response = Read-Host "Press Enter to accept (Y/n)"
 
         if ($response -eq '' -or $response -eq 'y' -or $response -eq 'Y') {
-            $setupOutput = & "$BinDir\vp.exe" env setup --refresh 2>&1
-            if ($LASTEXITCODE -ne 0) {
-                Write-Warn "Failed to refresh shims:"
-                Write-Host "$setupOutput"
-            }
+            Refresh-Shims -BinDir $BinDir
             return "true"
         }
     }

packages/cli/install.sh

@@ -413,6 +413,17 @@ configure_shell_path() {
   # If result is still 1, PATH_CONFIGURED remains "false" (set at function start)
 }
 
+# Run vp env setup --refresh, showing output only on failure
+# Arguments: vp_bin - path to the vp binary
+refresh_shims() {
+  local vp_bin="$1"
+  local setup_output
+  if ! setup_output=$("$vp_bin" env setup --refresh 2>&1); then
+    warn "Failed to refresh shims:"
+    echo "$setup_output" >&2
+  fi
+}
+
 # Setup Node.js version manager (node/npm/npx shims)
 # Sets NODE_MANAGER_ENABLED global
 # Arguments: bin_dir - path to the version's bin directory containing vp
@@ -429,23 +440,14 @@ setup_node_manager() {
 
   # Check if Vite+ is already managing Node.js (bin/node or bin/node.exe exists)
   if [ -e "$bin_path/node" ] || [ -e "$bin_path/node.exe" ]; then
-    # Already managing Node.js, just refresh shims
-    local setup_output
-    if ! setup_output=$("$vp_bin" env setup --refresh 2>&1); then
-      warn "Failed to refresh shims:"
-      echo "$setup_output" >&2
-    fi
+    refresh_shims "$vp_bin"
     NODE_MANAGER_ENABLED="already"
     return 0
   fi
 
   # Auto-enable on CI environment
   if [ -n "$CI" ]; then
-    local setup_output
-    if ! setup_output=$("$vp_bin" env setup --refresh 2>&1); then
-      warn "Failed to refresh shims:"
-      echo "$setup_output" >&2
-    fi
+    refresh_shims "$vp_bin"
     NODE_MANAGER_ENABLED="true"
     return 0
   fi
@@ -458,11 +460,7 @@ setup_node_manager() {
 
   # Auto-enable if no node available on system
   if [ "$node_available" = "false" ]; then
-    local setup_output
-    if ! setup_output=$("$vp_bin" env setup --refresh 2>&1); then
-      warn "Failed to refresh shims:"
-      echo "$setup_output" >&2
-    fi
+    refresh_shims "$vp_bin"
     NODE_MANAGER_ENABLED="true"
     return 0
   fi
@@ -475,11 +473,7 @@ setup_node_manager() {
     read -r response < /dev/tty
 
     if [ -z "$response" ] || [ "$response" = "y" ] || [ "$response" = "Y" ]; then
-      local setup_output
-      if ! setup_output=$("$vp_bin" env setup --refresh 2>&1); then
-        warn "Failed to refresh shims:"
-        echo "$setup_output" >&2
-      fi
+      refresh_shims "$vp_bin"
       NODE_MANAGER_ENABLED="true"
     fi
   fi