fix(migrate): write pnpm catalog for standalone pnpm 9.5-10.6.1 projects

A standalone (non-monorepo) migration on pnpm 9.5.0-10.6.1 rewrote the toolchain
edges to `catalog:` (catalogs are supported from 9.5.0) but never wrote the
catalog entries to pnpm-workspace.yaml: that write was gated on
`usePnpmWorkspaceYaml` (settings support, >= 10.6.2), so the install could not
resolve `catalog:` and failed.

Gate the pnpm-workspace.yaml write on `usePnpmWorkspaceYaml || supportCatalog`
and pass `usePnpmWorkspaceYaml` as the `writeWorkspaceSettings` flag, so a
9.5-10.6.1 project gets a catalog-only file (settings stay in package.json),
mirroring the monorepo orchestrator. 452cbf6 fixed the existing-Vite+ bootstrap
path; this covers the standalone new-project path.

Removes the now-redundant `shouldRewritePnpmWorkspaceYaml` state (it only ever
mirrored `usePnpmWorkspaceYaml`). Adds a reproducing test.

Claude-Session: https://claude.ai/code/session_01DQhS6o1fyQd1yjiee6W8jR

Author: fengmk2

packages/cli/src/migration/__tests__/migrator.spec.ts

@@ -4439,6 +4439,35 @@ describe('rewriteStandaloneProject pnpm workspace yaml', () => {
     expect(devDeps['vite-plus']).toBe('catalog:');
   });
 
+  // PR #1891 review (P1): pnpm 9.5.0-10.6.1 supports catalogs (>= 9.5.0) but not
+  // moving settings to pnpm-workspace.yaml (< 10.6.2). The toolchain edges are
+  // rewritten to `catalog:` regardless, so the catalog ENTRIES must still be
+  // written to pnpm-workspace.yaml or the install cannot resolve them.
+  it('writes the catalog to pnpm-workspace.yaml for a standalone project on pnpm 9.5-10.6.1', () => {
+    fs.writeFileSync(
+      path.join(tmpDir, 'package.json'),
+      JSON.stringify({ name: 'test', devDependencies: { vite: '^7.0.0' } }),
+    );
+    const workspaceInfo = makeWorkspaceInfo(tmpDir, PackageManager.pnpm);
+    workspaceInfo.packageManagerVersion = '9.15.9';
+    workspaceInfo.downloadPackageManager.version = '9.15.9';
+    rewriteStandaloneProject(tmpDir, workspaceInfo, true, true);
+
+    // package.json emits catalog: specs (this part already works today).
+    const pkg = readJson(path.join(tmpDir, 'package.json'));
+    const devDeps = pkg.devDependencies as Record<string, string>;
+    expect(devDeps.vite).toBe('catalog:');
+    expect(devDeps['vite-plus']).toBe('catalog:');
+
+    // The catalog backing those specs must exist. Below 10.6.2 the pnpm settings
+    // stay in package.json, so the workspace file holds only the catalog.
+    expect(fs.existsSync(path.join(tmpDir, 'pnpm-workspace.yaml'))).toBe(true);
+    const yaml = readYaml(path.join(tmpDir, 'pnpm-workspace.yaml'));
+    expect(yaml).toContain('catalog:');
+    expect(yaml).toContain('vite-plus:');
+    expect(yaml).not.toContain('overrides:');
+  });
+
   it('does not duplicate vite-plus into devDependencies when it already lives in dependencies', () => {
     fs.writeFileSync(
       path.join(tmpDir, 'package.json'),

packages/cli/src/migration/migrator/orchestrators.ts

@@ -91,7 +91,6 @@ export function rewriteStandaloneProject(
   const pnpmMajorVersion = pnpmMajor(workspaceInfo.downloadPackageManager.version);
   let extractedStagedConfig: Record<string, string | string[]> | null = null;
   let movedPnpmSettings: Record<string, unknown> | undefined;
-  let shouldRewritePnpmWorkspaceYaml = false;
   let shouldAddPnpmWorkspaceVitePlusOverride = false;
   let shouldAllowBrowserProviderBuilds = false;
   // Whether the project uses vitest directly (a required-peer consumer, an
@@ -175,7 +174,6 @@ export function rewriteStandaloneProject(
       }
     } else if (packageManager === PackageManager.pnpm) {
       if (usePnpmWorkspaceYaml) {
-        shouldRewritePnpmWorkspaceYaml = true;
         shouldAddPnpmWorkspaceVitePlusOverride = isForceOverrideMode();
       }
       const overrideKeys = Object.keys(managed);
@@ -280,14 +278,20 @@ export function rewriteStandaloneProject(
 
   migratePnpmSettingsToWorkspaceYaml(projectPath, movedPnpmSettings);
 
-  if (shouldRewritePnpmWorkspaceYaml) {
+  // Catalogs are supported from pnpm 9.5.0, but pnpm settings only move into
+  // pnpm-workspace.yaml from 10.6.2. When the toolchain edges were rewritten to
+  // `catalog:` (supportCatalog), the catalog entries backing them must be
+  // written even below 10.6.2 or the install cannot resolve them; settings then
+  // stay in package.json (writeWorkspaceSettings = usePnpmWorkspaceYaml). This
+  // mirrors the monorepo orchestrator below.
+  if (packageManager === PackageManager.pnpm && (usePnpmWorkspaceYaml || supportCatalog)) {
     rewritePnpmWorkspaceYaml(
       projectPath,
       pnpmMajorVersion,
       shouldAllowBrowserProviderBuilds,
       usesVitest,
       vitestEcosystemPackages,
-      true,
+      usePnpmWorkspaceYaml,
       providerCatalogAdditions,
     );
   }