Skip to content

Commit 1dd7b6f

Browse files
committed
fix(migrate): move pnpm settings to workspace config
1 parent 7020d2a commit 1dd7b6f

6 files changed

Lines changed: 368 additions & 238 deletions

File tree

packages/cli/snap-tests-global/migration-upgrade-stale-local-pnpm/snap.txt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
• Node <semver> pnpm <semver>
55
• Package manager settings configured
66

7-
> cat package.json # stale wrapper deps and plain vite-plus range should be repaired
7+
> cat package.json # stale wrapper deps and plain vite-plus range should be repaired; empty pnpm field should be removed
88
{
99
"name": "migration-upgrade-stale-local-pnpm",
1010
"devDependencies": {
@@ -17,11 +17,10 @@
1717
"version": "<semver>",
1818
"onFail": "download"
1919
}
20-
},
21-
"pnpm": {}
20+
}
2221
}
2322

24-
> cat pnpm-workspace.yaml # empty pnpm field must not hide workspace overrides
23+
> cat pnpm-workspace.yaml # pnpm settings should be consolidated here
2524
overrides:
2625
vite: 'catalog:'
2726
peerDependencyRules:

packages/cli/snap-tests-global/migration-upgrade-stale-local-pnpm/steps.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"commands": [
44
{ "command": "node setup-local.mjs", "ignoreOutput": true },
55
"vp migrate --no-interactive # newer global CLI must bypass the installed stale local CLI",
6-
"cat package.json # stale wrapper deps and plain vite-plus range should be repaired",
7-
"cat pnpm-workspace.yaml # empty pnpm field must not hide workspace overrides"
6+
"cat package.json # stale wrapper deps and plain vite-plus range should be repaired; empty pnpm field should be removed",
7+
"cat pnpm-workspace.yaml # pnpm settings should be consolidated here"
88
]
99
}

0 commit comments

Comments
 (0)