Commit 27c91c2
committed
feat(create): always exclude node_modules from .gitignore after git init
Bundled `@org` templates may ship without a `.gitignore` (or with one
that omits `node_modules`), so the user's first commit could end up
tracking installed dependencies. Add a small post-`git init` step that
guarantees the line is present.
- `create/utils.ts` — new `ensureGitignoreNodeModules(projectDir)` that:
- creates a fresh `.gitignore` containing `node_modules\n` when none
exists (the bundled-monorepo case),
- appends `node_modules\n` when a `.gitignore` exists but omits it
(terminating the previous line first if the file lacks a trailing
newline),
- is a no-op when `node_modules` (or `node_modules/`) already
appears as a standalone line.
- `create/bin.ts` — call the helper from the monorepo branch right
after `git init` succeeds. Both the builtin `vite:monorepo` (whose
template's `_gitignore` already lists `node_modules`) and the
bundled `@org` monorepo path now end up with the line guaranteed.
Tests:
- 5 unit tests over the helper (fresh, append, no-newline, no-op,
trailing-slash variant).
- The bundled-monorepo snap-test gains a `cat my-mono/.gitignore`
step verifying the file is created with `node_modules`.
- Existing `new-vite-monorepo` snap-test stays byte-stable — the
template-shipped gitignore already lists `node_modules`, so the
helper is a no-op there.1 parent 5e3158c commit 27c91c2
5 files changed
Lines changed: 83 additions & 3 deletions
File tree
- packages/cli
- snap-tests/create-org-bundled-monorepo
- src/create
- __tests__
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
2 | 6 | | |
3 | 7 | | |
4 | 8 | | |
| 9 | + | |
5 | 10 | | |
6 | 11 | | |
7 | 12 | | |
| |||
87 | 92 | | |
88 | 93 | | |
89 | 94 | | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
873 | 873 | | |
874 | 874 | | |
875 | 875 | | |
| 876 | + | |
876 | 877 | | |
877 | 878 | | |
878 | 879 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
115 | 138 | | |
116 | 139 | | |
117 | 140 | | |
| |||
0 commit comments