Skip to content

Commit 297597e

Browse files
committed
chore(ci): remove vp env off E2E steps, covered by snap test
The snap test command-env-off-on now covers system-first mode switching with runtime assertions, making the CI E2E steps redundant.
1 parent 83a0d64 commit 297597e

1 file changed

Lines changed: 0 additions & 48 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -235,11 +235,6 @@ jobs:
235235
if: ${{ matrix.target == 'x86_64-unknown-linux-gnu' }}
236236
run: pnpm tsgo
237237

238-
- name: Save system Node.js info
239-
run: |
240-
echo "SYSTEM_NODE_PATH=$(which node)" >> "$GITHUB_ENV"
241-
echo "SYSTEM_NODE_VERSION=$(node --version)" >> "$GITHUB_ENV"
242-
243238
- name: Install Global CLI vp
244239
run: |
245240
pnpm bootstrap-cli:ci
@@ -263,28 +258,6 @@ jobs:
263258
env:
264259
RUST_MIN_STACK: 8388608
265260

266-
- name: Test vp env off (system-first mode)
267-
run: |
268-
echo "System Node.js: $SYSTEM_NODE_PATH ($SYSTEM_NODE_VERSION)"
269-
270-
vp env off
271-
vp env doctor
272-
273-
# Verify vp --version still works using system Node.js
274-
vp --version
275-
276-
# In system-first mode, the node shim should resolve to system node
277-
SHIM_NODE_VERSION=$(node --version)
278-
echo "Shim Node.js version: $SHIM_NODE_VERSION"
279-
if [ "$SHIM_NODE_VERSION" != "$SYSTEM_NODE_VERSION" ]; then
280-
echo "Error: expected shim to use system Node.js $SYSTEM_NODE_VERSION, got $SHIM_NODE_VERSION"
281-
exit 1
282-
fi
283-
284-
vp env on
285-
vp env doctor
286-
echo "vp env off/on test passed"
287-
288261
- name: Test global package install (powershell)
289262
if: ${{ matrix.os == 'windows-latest' }}
290263
shell: pwsh
@@ -325,27 +298,6 @@ jobs:
325298
vp env use --unset
326299
node --version
327300
328-
- name: Test vp env off (powershell)
329-
if: ${{ matrix.os == 'windows-latest' }}
330-
shell: pwsh
331-
run: |
332-
Write-Host "System Node.js: $env:SYSTEM_NODE_PATH ($env:SYSTEM_NODE_VERSION)"
333-
334-
vp env off
335-
vp env doctor
336-
vp --version
337-
338-
$ShimNodeVersion = node --version
339-
Write-Host "Shim Node.js version: $ShimNodeVersion"
340-
if ($ShimNodeVersion -ne $env:SYSTEM_NODE_VERSION) {
341-
Write-Error "Expected shim to use system Node.js $env:SYSTEM_NODE_VERSION, got $ShimNodeVersion"
342-
exit 1
343-
}
344-
345-
vp env on
346-
vp env doctor
347-
Write-Host "vp env off/on test passed"
348-
349301
- name: Test global package install (cmd)
350302
if: ${{ matrix.os == 'windows-latest' }}
351303
shell: cmd

0 commit comments

Comments
 (0)