refactor(global-cli): use #[from] PmCli + is_user_message() helper

Replace the explicit per-variant `From<vite_pm_cli::Error>` impl
(remapping UserMessage/Install/Workspace/etc. one-by-one) with an
`#[error(transparent)] PmCli(#[from] vite_pm_cli::Error)` variant and
an `Error::is_user_message()` helper that knows about both the
top-level `UserMessage(_)` and the wrapped `PmCli(UserMessage(_))`.

This drops the 12-line manual match in error.rs, localizes the
"is friendly message" semantic on `Error` itself instead of leaking
variant matches into main.rs, and makes adding future sub-error crates
a one-line change to `is_user_message`.

Also switch the two `eprintln!("{e}")` calls in main.rs that print
user-facing messages to `output::raw_stderr` for consistency with the
rest of the codebase's "go through `output::*` instead of raw print
macros" rule.

Author: fengmk2

crates/vite_global_cli/src/error.rs

@@ -64,20 +64,15 @@ pub enum Error {
         version_source: String,
         help: String,
     },
+
+    #[error(transparent)]
+    PmCli(#[from] vite_pm_cli::Error),
 }
 
-// Explicit per-variant remap (not `#[from]`) so `UserMessage` stays a
-// distinct variant `main.rs` can pattern-match to skip the "error: "
-// prefix when the message originates from the PM crate.
-impl From<vite_pm_cli::Error> for Error {
-    fn from(err: vite_pm_cli::Error) -> Self {
-        match err {
-            vite_pm_cli::Error::Install(e) => Self::Install(e),
-            vite_pm_cli::Error::Workspace(e) => Self::Workspace(e),
-            vite_pm_cli::Error::CommandExecution(e) => Self::CommandExecution(e),
-            vite_pm_cli::Error::Json(e) => Self::JsonError(e),
-            vite_pm_cli::Error::UserMessage(s) => Self::UserMessage(s),
-            vite_pm_cli::Error::Other(s) => Self::Other(s),
-        }
+impl Error {
+    /// Whether this error should be printed without the "error: " prefix
+    /// (a friendly user-facing message, not a stack trace).
+    pub fn is_user_message(&self) -> bool {
+        matches!(self, Self::UserMessage(_) | Self::PmCli(vite_pm_cli::Error::UserMessage(_)))
     }
 }

crates/vite_global_cli/src/main.rs

@@ -196,8 +196,8 @@ async fn run_corrected_args(cwd: &vite_path::AbsolutePathBuf, raw_args: &[String
     match run_command_with_options(cwd.clone(), parsed, render_options).await {
         Ok(exit_status) => exit_status_to_exit_code(exit_status),
         Err(e) => {
-            if matches!(&e, error::Error::UserMessage(_)) {
-                eprintln!("{e}");
+            if e.is_user_message() {
+                output::raw_stderr(&format!("{e}"));
             } else {
                 output::error(&format!("{e}"));
             }
@@ -395,8 +395,8 @@ async fn main() -> ExitCode {
         Ok(args) => match run_command(cwd.clone(), args).await {
             Ok(exit_status) => exit_status_to_exit_code(exit_status),
             Err(e) => {
-                if matches!(&e, error::Error::UserMessage(_)) {
-                    eprintln!("{e}");
+                if e.is_user_message() {
+                    output::raw_stderr(&format!("{e}"));
                 } else {
                     output::error(&format!("{e}"));
                 }