Commit 4eaba42
committed
refactor(migrate): drop @nuxt/eslint from ESLINT_ECOSYSTEM_NAMES
The entry was unreachable: when `@nuxt/eslint` is present anywhere in
the workspace, `detectIncompatibleEslintIntegration` short-circuits
the entire ESLint migration before `rewriteEslintPackageJson` runs,
so the second list never gets consulted. Two side effects from
keeping it duplicated:
- Maintenance hazard: the "what to do about Nuxt" decision lives in
two places that could drift.
- Misleading future intent: a contributor scanning the cleanup list
would conclude `@nuxt/eslint` gets stripped on migration, which
isn't true today.
The right home for the policy is `INCOMPATIBLE_ESLINT_INTEGRATIONS`
(which is already what controls the actual behavior). Added an
explicit unit test asserting `rewriteEslintPackageJson` leaves
`@nuxt/eslint` alone, with a comment explaining the upstream skip.1 parent 9146fc1 commit 4eaba42
2 files changed
Lines changed: 21 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
404 | 404 | | |
405 | 405 | | |
406 | 406 | | |
407 | | - | |
| 407 | + | |
408 | 408 | | |
409 | 409 | | |
410 | 410 | | |
| |||
416 | 416 | | |
417 | 417 | | |
418 | 418 | | |
419 | | - | |
420 | 419 | | |
421 | 420 | | |
422 | 421 | | |
| |||
425 | 424 | | |
426 | 425 | | |
427 | 426 | | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
428 | 442 | | |
429 | 443 | | |
430 | 444 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
383 | 383 | | |
384 | 384 | | |
385 | 385 | | |
386 | | - | |
387 | | - | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
388 | 391 | | |
389 | 392 | | |
390 | 393 | | |
| |||
0 commit comments