Merge branch 'voidzero-dev:main' into feat/cli-completion

Author: nekomoyi

.claude/skills/add-ecosystem-ci/SKILL.md

@@ -25,7 +25,11 @@ gh api repos/OWNER/REPO/commits/BRANCH --jq '.sha'
 
 Fetch the repository's root to check if the main package.json is in a subdirectory (like `web/`, `app/`, `frontend/`).
 
-### 2.2 Auto-detect Commands from GitHub Workflows
+### 2.2 Check if Project Already Uses Vite-Plus
+
+Check the project's root `package.json` for `vite-plus` in `dependencies` or `devDependencies`. If the project already uses vite-plus, set `forceFreshMigration: true` in `repo.json`. This tells `patch-project.ts` to set `VITE_PLUS_FORCE_MIGRATE=1` so `vp migrate` forces full dependency rewriting instead of skipping with "already using Vite+".
+
+### 2.3 Auto-detect Commands from GitHub Workflows
 
 Fetch the project's GitHub workflow files to detect available commands:
 
@@ -43,7 +47,7 @@ Look for common patterns in workflow files:
 - Commands like: `lint`, `build`, `test`, `type-check`, `typecheck`, `format`, `format:check`
 - Map detected commands to `vp` equivalents: `vp run lint`, `vp run build`, etc.
 
-### 2.3 Ask User to Confirm
+### 2.4 Ask User to Confirm
 
 Present the auto-detected configuration and ask user to confirm or modify:
 
@@ -62,7 +66,8 @@ Present the auto-detected configuration and ask user to confirm or modify:
        "repository": "https://github.com/owner/repo.git",
        "branch": "main",
        "hash": "full-commit-sha",
-       "directory": "web" // only if subdirectory is needed
+       "directory": "web", // only if subdirectory is needed
+       "forceFreshMigration": true // only if project already uses vite-plus
      }
    }
    ```
@@ -110,4 +115,5 @@ node ecosystem-ci/clone.ts project-name
 - The `directory` field is optional - only add it if the package.json is not in the project root
 - If `directory` is specified in repo.json, it must also be specified in the workflow matrix
 - `patch-project.ts` automatically handles running `vp migrate` in the correct directory
+- `forceFreshMigration` is required for projects that already have `vite-plus` in their package.json — it sets `VITE_PLUS_FORCE_MIGRATE=1` so `vp migrate` forces full dependency rewriting instead of skipping
 - OS exclusions are added to the existing `exclude` section in the workflow matrix

.github/workflows/claude.yml

@@ -6,7 +6,7 @@ on:
 
 jobs:
   analyze:
-    if: github.repository == 'voidzero-dev/vite-plus' && github.event.action == 'assigned' && github.event.assignee.login == 'boshen' && github.event.sender.login == 'boshen'
+    if: github.repository == 'voidzero-dev/vite-plus' && github.event.action == 'assigned' && github.event.assignee.login == 'boshen'
     runs-on: ubuntu-slim
     permissions:
       contents: read

.github/workflows/e2e-test.yml

@@ -257,6 +257,13 @@ jobs:
               vp check
               vp pack
               vp test
+          - name: vinext
+            node-version: 24
+            command: |
+              vp run build
+              vp check --fix
+              vp run check
+              vp run test
         exclude:
           # frm-stack uses Docker (testcontainers) which doesn't work the same way on Windows
           - os: windows-latest
@@ -266,6 +273,10 @@ jobs:
           - os: windows-latest
             project:
               name: dify
+          # vinext uses workerd native deps that don't build on Windows
+          - os: windows-latest
+            project:
+              name: vinext
 
     steps:
       - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
@@ -310,6 +321,11 @@ jobs:
           node $GITHUB_WORKSPACE/ecosystem-ci/patch-project.ts ${{ matrix.project.name }}
           vp install --no-frozen-lockfile
 
+      - name: Verify local tgz packages installed
+        working-directory: ${{ runner.temp }}/vite-plus-ecosystem-ci/${{ matrix.project.name }}${{ matrix.project.directory && format('/{0}', matrix.project.directory) || '' }}
+        shell: bash
+        run: node $GITHUB_WORKSPACE/ecosystem-ci/verify-install.ts
+
       - name: Run vite-plus commands in ${{ matrix.project.name }}
         working-directory: ${{ runner.temp }}/vite-plus-ecosystem-ci/${{ matrix.project.name }}${{ matrix.project.directory && format('/{0}', matrix.project.directory) || '' }}
         run: ${{ matrix.project.command }}

.github/workflows/issue-close-require.yml

@@ -0,0 +1,21 @@
+name: Issue Close Require
+
+on:
+  schedule:
+    - cron: '0 0 * * *'
+
+jobs:
+  close-issues:
+    if: github.repository == 'voidzero-dev/vite-plus'
+    runs-on: ubuntu-slim
+    permissions:
+      issues: write # for actions-cool/issues-helper to update issues
+      pull-requests: write # for actions-cool/issues-helper to update PRs
+    steps:
+      - name: needs reproduction
+        uses: actions-cool/issues-helper@71b62d7da76e59ff7b193904feb6e77d4dbb2777 # v3
+        with:
+          actions: 'close-issues'
+          token: ${{ secrets.GITHUB_TOKEN }}
+          labels: 'needs reproduction'
+          inactive-day: 3

.github/workflows/issue-labeled.yml

@@ -0,0 +1,44 @@
+name: Issue Labeled
+
+on:
+  issues:
+    types: [labeled]
+
+jobs:
+  reply-labeled:
+    if: github.repository == 'voidzero-dev/vite-plus'
+    runs-on: ubuntu-slim
+    permissions:
+      issues: write # for actions-cool/issues-helper to update issues
+      pull-requests: write # for actions-cool/issues-helper to update PRs
+    steps:
+      - name: contribution welcome
+        if: github.event.label.name == 'contribution welcome' || github.event.label.name == 'help wanted'
+        uses: actions-cool/issues-helper@71b62d7da76e59ff7b193904feb6e77d4dbb2777 # v3
+        with:
+          actions: 'remove-labels'
+          token: ${{ secrets.GITHUB_TOKEN }}
+          issue-number: ${{ github.event.issue.number }}
+          labels: 'pending triage, needs reproduction'
+
+      - name: needs reproduction
+        if: github.event.label.name == 'needs reproduction'
+        uses: actions-cool/issues-helper@71b62d7da76e59ff7b193904feb6e77d4dbb2777 # v3
+        with:
+          actions: 'create-comment, remove-labels'
+          token: ${{ secrets.GITHUB_TOKEN }}
+          issue-number: ${{ github.event.issue.number }}
+          labels: 'pending triage'
+          body: |
+            Hello @${{ github.event.issue.user.login }} 👋
+
+            Please provide a [minimal reproduction](https://stackoverflow.com/help/minimal-reproducible-example) using a GitHub repository. This helps us understand and resolve your issue much faster.
+
+            **A good reproduction should be:**
+            - **Minimal** – include only the code necessary to demonstrate the issue
+            - **Complete** – contain everything needed to run and observe the problem
+            - **Reproducible** – consistently show the issue with clear steps
+
+            If no reproduction is provided, issues labeled `needs reproduction` will be closed after 3 days of inactivity.
+
+            For more context on why this is required, please read: https://antfu.me/posts/why-reproductions-are-required

.github/workflows/test-standalone-install.yml

@@ -114,6 +114,41 @@ jobs:
           vp upgrade --rollback
           vp --version
 
+  test-install-sh-readonly-config:
+    name: Test install.sh (readonly shell config)
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    steps:
+      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+
+      - name: Make shell config files read-only
+        run: |
+          # Simulate Nix-managed or read-only shell configs
+          touch ~/.bashrc ~/.bash_profile ~/.profile
+          chmod 444 ~/.bashrc ~/.bash_profile ~/.profile
+
+      - name: Run install.sh
+        run: |
+          output=$(cat packages/cli/install.sh | bash 2>&1) || {
+            echo "$output"
+            echo "Install script exited with non-zero status"
+            exit 1
+          }
+          echo "$output"
+          # Verify installation succeeds (not a fatal error)
+          echo "$output" | grep -q "successfully installed"
+          # Verify fallback message shows binary location
+          echo "$output" | grep -q "vp was installed to:"
+          # Verify fallback message shows manual instructions
+          echo "$output" | grep -q "Or run vp directly:"
+          # Verify the permission warning was shown
+          echo "$output" | grep -qi "permission denied"
+
+      - name: Verify vp works via direct path
+        run: |
+          ~/.vite-plus/bin/vp --version
+
   test-install-sh-arm64:
     name: Test install.sh (Linux ARM64 glibc via QEMU)
     runs-on: ubuntu-latest

crates/vite_global_cli/src/commands/version.rs

@@ -10,11 +10,10 @@ use std::{
 use owo_colors::OwoColorize;
 use serde::Deserialize;
 use vite_install::get_package_manager_type_and_version;
-use vite_js_runtime::{VersionSource, resolve_node_version};
 use vite_path::AbsolutePathBuf;
 use vite_workspace::find_workspace_root;
 
-use crate::{error::Error, help};
+use crate::{commands::env::config::resolve_version, error::Error, help};
 
 #[derive(Debug, Deserialize)]
 #[serde(rename_all = "camelCase")]
@@ -133,14 +132,31 @@ fn format_version(version: Option<String>) -> String {
 }
 
 async fn get_node_version_info(cwd: &AbsolutePathBuf) -> Option<(String, String)> {
-    let resolution_opt = resolve_node_version(cwd, true).await.ok()?;
-    let resolution = resolution_opt?;
-    let source_label = match resolution.source {
-        VersionSource::NodeVersionFile => ".node-version",
-        VersionSource::EnginesNode => "engines.node",
-        VersionSource::DevEnginesRuntime => "devEngines.runtime",
-    };
-    Some((resolution.version.to_string(), source_label.to_string()))
+    // Try the full managed resolution chain
+    if let Ok(resolution) = resolve_version(cwd).await {
+        return Some((resolution.version, resolution.source));
+    }
+
+    // Fallback: detect system Node version (with VITE_PLUS_BYPASS to avoid hitting the shim)
+    let version = detect_system_node_version()?;
+    Some((version, "system".to_string()))
+}
+
+fn detect_system_node_version() -> Option<String> {
+    let output = std::process::Command::new("node")
+        .arg("--version")
+        .env(vite_shared::env_vars::VITE_PLUS_BYPASS, "1")
+        .output()
+        .ok()?;
+    if !output.status.success() {
+        return None;
+    }
+    let version = String::from_utf8(output.stdout).ok()?;
+    let version = version.trim().strip_prefix('v').unwrap_or(version.trim());
+    if version.is_empty() {
+        return None;
+    }
+    Some(version.to_string())
 }
 
 /// Execute the `--version` command.
@@ -182,7 +198,10 @@ pub async fn execute(cwd: AbsolutePathBuf) -> Result<ExitStatus, Error> {
 
     let node_info = get_node_version_info(&cwd)
         .await
-        .map(|(v, s)| format!("v{v} ({s})"))
+        .map(|(v, s)| match s.as_str() {
+            "lts" | "default" | "system" => format!("v{v}"),
+            _ => format!("v{v} ({s})"),
+        })
         .unwrap_or(NOT_FOUND.to_string());
 
     let env_rows = [("Package manager", package_manager_info), ("Node.js", node_info)];
@@ -197,9 +216,9 @@ mod tests {
     #[cfg(unix)]
     use std::{fs, path::Path};
 
-    use super::format_version;
     #[cfg(unix)]
     use super::{ToolSpec, find_local_vite_plus, resolve_tool_version};
+    use super::{detect_system_node_version, format_version};
 
     #[cfg(unix)]
     fn symlink_dir(src: &Path, dst: &Path) {
@@ -212,6 +231,15 @@ mod tests {
         assert_eq!(format_version(None), "Not found");
     }
 
+    #[test]
+    fn detect_system_node_version_returns_version() {
+        let version = detect_system_node_version();
+        assert!(version.is_some(), "expected node to be installed");
+        let version = version.unwrap();
+        assert!(!version.starts_with('v'), "version should not have v prefix");
+        assert!(version.contains('.'), "expected semver-like version, got: {version}");
+    }
+
     #[cfg(unix)]
     #[test]
     fn resolves_tool_versions_from_pnpm_symlink_layout() {

docs/guide/pack.md

@@ -25,8 +25,8 @@ See the [tsdown guide](https://tsdown.dev/guide/) and the [tsdown config file do
 Use it for:
 
 - [declaration files (`dts`)](https://tsdown.dev/options/dts)
-- [output formats](https://tsdown.dev/options/format)
-- [watch mode](https://tsdown.dev/options/watch)
+- [output formats](https://tsdown.dev/options/output-format)
+- [watch mode](https://tsdown.dev/options/watch-mode)
 - [standalone executables](https://tsdown.dev/options/exe#executable)
 
 ```ts

ecosystem-ci/patch-project.ts

@@ -21,18 +21,6 @@ const cwd = directory ? join(repoRoot, directory) : repoRoot;
 // run vp migrate
 const cli = process.env.VITE_PLUS_CLI_BIN ?? 'vp';
 
-// Projects that already have vite-plus need it removed before migration so
-// vp migrate treats them as fresh and applies tgz overrides. Without this,
-// vp migrate detects "already using Vite+" and skips override injection.
-const forceFreshMigration = 'forceFreshMigration' in repoConfig && repoConfig.forceFreshMigration;
-if (forceFreshMigration) {
-  const pkgPath = join(cwd, 'package.json');
-  const pkg = JSON.parse(await readFile(pkgPath, 'utf-8'));
-  delete pkg.devDependencies?.['vite-plus'];
-  delete pkg.dependencies?.['vite-plus'];
-  await writeFile(pkgPath, JSON.stringify(pkg, null, 2) + '\n', 'utf-8');
-}
-
 if (project === 'rollipop') {
   const oxfmtrc = await readFile(join(repoRoot, '.oxfmtrc.json'), 'utf-8');
   await writeFile(
@@ -42,11 +30,16 @@ if (project === 'rollipop') {
   );
 }
 
+// Projects that already use vite-plus need VITE_PLUS_FORCE_MIGRATE=1 so
+// vp migrate runs full dependency rewriting instead of skipping.
+const forceFreshMigration = 'forceFreshMigration' in repoConfig && repoConfig.forceFreshMigration;
+
 execSync(`${cli} migrate --no-agent --no-interactive`, {
   cwd,
   stdio: 'inherit',
   env: {
     ...process.env,
+    ...(forceFreshMigration ? { VITE_PLUS_FORCE_MIGRATE: '1' } : {}),
     VITE_PLUS_OVERRIDE_PACKAGES: JSON.stringify({
       vite: `file:${tgzDir}/voidzero-dev-vite-plus-core-0.0.0.tgz`,
       vitest: `file:${tgzDir}/voidzero-dev-vite-plus-test-0.0.0.tgz`,

ecosystem-ci/repo.json

@@ -13,7 +13,8 @@
   "vibe-dashboard": {
     "repository": "https://github.com/voidzero-dev/vibe-dashboard.git",
     "branch": "main",
-    "hash": "fcb0518e75e0f05e09ac910dcc88090220dfd3ae"
+    "hash": "158e4a0c3d8a1801e330300a5deba4506fd5dfb9",
+    "forceFreshMigration": true
   },
   "rollipop": {
     "repository": "https://github.com/leegeunhyeok/rollipop.git",
@@ -64,6 +65,13 @@
   "vp-config": {
     "repository": "https://github.com/kazupon/vp-config.git",
     "branch": "main",
-    "hash": "b58c48d71a17c25dec71a003535e6312791ce2aa"
+    "hash": "b58c48d71a17c25dec71a003535e6312791ce2aa",
+    "forceFreshMigration": true
+  },
+  "vinext": {
+    "repository": "https://github.com/cloudflare/vinext.git",
+    "branch": "main",
+    "hash": "f78dd2b39f5b02242417e0a684b1f2f55d3dbdff",
+    "forceFreshMigration": true
   }
 }