Commit 59aa22c
fix(migration): only manage pnpm allowBuilds when webdriverio is used
edgedriver/geckodriver reach a project's dependency tree solely through the
opt-in webdriverio Vitest browser provider, which is an OPTIONAL peer of both
vite-plus and vitest (peerDependenciesMeta.optional). pnpm's autoInstallPeers
never installs an optional peer, so a non-webdriverio project never installs
those drivers — the `allowBuilds.<driver>: false` default-deny the migrator
wrote for every pnpm v10 project was inert config.
Make the migrator hands-off: when the project does not use webdriverio it now
writes nothing to allowBuilds and leaves any user-authored entry (their own
build-script trust decision) untouched. The webdriverio-present path still
writes `true` — load-bearing, since those drivers really install and their
postinstall must run, and it still overwrites a stale `false` when webdriverio
is added later.
This also drops the stale-`false` cleanup that, with the default-deny gone,
could delete a user's intentional `false` and could orphan a YAML anchor/alias
on deletion (crashing serialization). The now-unused directDriverDeps
collection/threading (collectDirectDriverDeps, collectWorkspaceDirectDriverDeps,
hasOwnDriverPostinstallDependency) is removed.
64 migration snaps drop the inert allowBuilds block; the one webdriverio fixture
keeps `true`. 220 migrator + 718 vite-plus src tests pass; vp check clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent d21d56d commit 59aa22c
66 files changed
Lines changed: 101 additions & 406 deletions
File tree
- packages/cli
- snap-tests-global
- migration-add-git-hooks
- migration-auto-create-vite-config
- migration-baseurl-tsconfig
- migration-chained-lint-staged-pre-commit
- migration-composed-husky-custom-dir
- migration-composed-husky-prepare
- migration-env-prefix-lint-staged
- migration-eslint-lint-staged
- migration-eslint-lintstagedrc
- migration-eslint-npx-wrapper
- migration-eslint
- migration-existing-husky-lint-staged
- migration-existing-husky-v8-hooks
- migration-existing-husky-v8-multi-hooks
- migration-existing-husky
- migration-existing-lint-staged-config
- migration-existing-pnpm-exec-lint-staged
- migration-existing-prepare-script
- migration-from-tsdown-json-config
- migration-from-tsdown
- migration-from-vitest-files
- migration-hooks-skip-on-existing-hookspath
- migration-husky-catalog-version
- migration-husky-latest-dist-tag-v9-installed
- migration-husky-latest-dist-tag
- migration-husky-or-prepare
- migration-husky-semicolon-prepare
- migration-husky-v8-preserves-lint-staged
- migration-lazy-plugins-await
- migration-lint-staged-in-scripts
- migration-lint-staged-merge-fail
- migration-lint-staged-ts-config
- migration-lintstagedrc-json
- migration-lintstagedrc-merge-fail
- migration-lintstagedrc-not-support
- migration-lintstagedrc-staged-exists
- migration-merge-vite-config-js
- migration-merge-vite-config-ts
- migration-monorepo-pnpm-overrides-dependency-selector
- migration-monorepo-pnpm
- migration-no-git-repo
- migration-no-hooks-with-husky
- migration-no-hooks
- migration-other-hook-tool
- migration-oxlintrc-json-with-comments
- migration-oxlintrc-jsonc
- migration-partially-migrated-pre-commit
- migration-prettier-eslint-combo
- migration-prettier-ignore-unknown
- migration-prettier-lint-staged
- migration-prettier-pkg-json
- migration-prettier
- migration-rewrite-declare-module
- migration-skip-vite-dependency
- migration-skip-vite-peer-dependency
- migration-standalone-pnpm
- migration-subpath
- migration-tsconfig-esmoduleinterop
- migration-vite-version
- migration-vitest-peer-dep
- new-vite-monorepo
- snap-tests
- create-approve-builds-migrate-pnpm11
- create-approve-builds-pnpm11
- create-org-bundled-monorepo
- src/migration
- __tests__
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 32 | | |
36 | 33 | | |
37 | 34 | | |
| |||
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | 62 | | |
66 | 63 | | |
67 | 64 | | |
| |||
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | 65 | | |
69 | 66 | | |
70 | 67 | | |
| |||
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 32 | | |
36 | 33 | | |
37 | 34 | | |
| |||
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 32 | | |
36 | 33 | | |
37 | 34 | | |
| |||
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 32 | | |
36 | 33 | | |
37 | 34 | | |
| |||
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 32 | | |
36 | 33 | | |
37 | 34 | | |
| |||
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 32 | | |
36 | 33 | | |
37 | 34 | | |
| |||
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 32 | | |
36 | 33 | | |
37 | 34 | | |
| |||
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | 37 | | |
41 | 38 | | |
42 | 39 | | |
| |||
0 commit comments