Skip to content

Commit 6b56402

Browse files
committed
refactor(create): drop "selected 'X' from @org/create" breadcrumb
Removed the `prompts.log.info('selected ... from ...')` line that used to precede every manifest-driven template resolution. Rationale (cpojer, PR #1398): the clack picker already prints the selected entry above in its completed-prompt line, so the info note was a redundant restatement of what the user just picked a moment before. Impact on downstream failure context (the original reason the breadcrumb was added, via the Cursor "chosen template fails to resolve with context" finding): for the interactive path, the picker's own completed-prompt line still shows the selection. For the non-interactive `@org:name` path, the error surfaces from the downstream runner — no vp-side framing. If that proves confusing in practice, we can add the breadcrumb back only in failure paths. Snap regenerated for `create-org-bundled` (the only fixture that captured the line). 265 unit tests still pass.
1 parent c441ba6 commit 6b56402

2 files changed

Lines changed: 0 additions & 6 deletions

File tree

packages/cli/snap-tests/create-org-bundled/snap.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
> node $SNAP_CASES_DIR/.shared/mock-npm-registry.mjs -- vp create @your-org:demo --no-interactive --directory my-demo-app # bundled template: extract tarball, copy subdir
2-
3-
selected 'demo' from @your-org/create
42
◇ Scaffolded my-demo-app
53
• Node <semver> pnpm <semver>
64
→ Next: cd my-demo-app && vp run

packages/cli/src/create/org-resolve.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,6 @@ async function resolveEntry(
8686
manifest: OrgManifest,
8787
entry: OrgTemplateEntry,
8888
): Promise<OrgResolution> {
89-
// Breadcrumb so a later downstream failure (e.g. the referenced
90-
// `@org/template-web` package is missing) still tells the user what
91-
// manifest entry produced that chain.
92-
prompts.log.info(`selected '${entry.name}' from ${manifest.packageName}`);
9389
if (isRelativePath(entry.template)) {
9490
const extracted = await ensureOrgPackageExtracted(manifest);
9591
const bundledLocalPath = resolveBundledPath(extracted, entry.template);

0 commit comments

Comments
 (0)