Skip to content

Commit 6bafd60

Browse files
committed
fix: show error output when vp env setup --refresh fails
Previously, install.sh piped to /dev/null and install.ps1 piped to Out-Null, silently swallowing errors. Now output is captured and only displayed on failure, keeping success output quiet.
1 parent 216be05 commit 6bafd60

2 files changed

Lines changed: 40 additions & 8 deletions

File tree

packages/cli/install.ps1

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,13 +193,21 @@ function Setup-NodeManager {
193193
# Check if Vite+ is already managing Node.js (bin\node.exe exists)
194194
if (Test-Path "$binPath\node.exe") {
195195
# Already managing Node.js, just refresh shims
196-
& "$BinDir\vp.exe" env setup --refresh | Out-Null
196+
$setupOutput = & "$BinDir\vp.exe" env setup --refresh 2>&1
197+
if ($LASTEXITCODE -ne 0) {
198+
Write-Warn "Failed to refresh shims:"
199+
Write-Host "$setupOutput"
200+
}
197201
return "already"
198202
}
199203

200204
# Auto-enable on CI environment
201205
if ($env:CI) {
202-
& "$BinDir\vp.exe" env setup --refresh | Out-Null
206+
$setupOutput = & "$BinDir\vp.exe" env setup --refresh 2>&1
207+
if ($LASTEXITCODE -ne 0) {
208+
Write-Warn "Failed to refresh shims:"
209+
Write-Host "$setupOutput"
210+
}
203211
return "true"
204212
}
205213

@@ -208,7 +216,11 @@ function Setup-NodeManager {
208216

209217
# Auto-enable if no node available on system
210218
if (-not $nodeAvailable) {
211-
& "$BinDir\vp.exe" env setup --refresh | Out-Null
219+
$setupOutput = & "$BinDir\vp.exe" env setup --refresh 2>&1
220+
if ($LASTEXITCODE -ne 0) {
221+
Write-Warn "Failed to refresh shims:"
222+
Write-Host "$setupOutput"
223+
}
212224
return "true"
213225
}
214226

@@ -220,7 +232,11 @@ function Setup-NodeManager {
220232
$response = Read-Host "Press Enter to accept (Y/n)"
221233

222234
if ($response -eq '' -or $response -eq 'y' -or $response -eq 'Y') {
223-
& "$BinDir\vp.exe" env setup --refresh | Out-Null
235+
$setupOutput = & "$BinDir\vp.exe" env setup --refresh 2>&1
236+
if ($LASTEXITCODE -ne 0) {
237+
Write-Warn "Failed to refresh shims:"
238+
Write-Host "$setupOutput"
239+
}
224240
return "true"
225241
}
226242
}

packages/cli/install.sh

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -430,14 +430,22 @@ setup_node_manager() {
430430
# Check if Vite+ is already managing Node.js (bin/node or bin/node.exe exists)
431431
if [ -e "$bin_path/node" ] || [ -e "$bin_path/node.exe" ]; then
432432
# Already managing Node.js, just refresh shims
433-
"$vp_bin" env setup --refresh > /dev/null
433+
local setup_output
434+
if ! setup_output=$("$vp_bin" env setup --refresh 2>&1); then
435+
warn "Failed to refresh shims:"
436+
echo "$setup_output" >&2
437+
fi
434438
NODE_MANAGER_ENABLED="already"
435439
return 0
436440
fi
437441

438442
# Auto-enable on CI environment
439443
if [ -n "$CI" ]; then
440-
"$vp_bin" env setup --refresh > /dev/null
444+
local setup_output
445+
if ! setup_output=$("$vp_bin" env setup --refresh 2>&1); then
446+
warn "Failed to refresh shims:"
447+
echo "$setup_output" >&2
448+
fi
441449
NODE_MANAGER_ENABLED="true"
442450
return 0
443451
fi
@@ -450,7 +458,11 @@ setup_node_manager() {
450458

451459
# Auto-enable if no node available on system
452460
if [ "$node_available" = "false" ]; then
453-
"$vp_bin" env setup --refresh > /dev/null
461+
local setup_output
462+
if ! setup_output=$("$vp_bin" env setup --refresh 2>&1); then
463+
warn "Failed to refresh shims:"
464+
echo "$setup_output" >&2
465+
fi
454466
NODE_MANAGER_ENABLED="true"
455467
return 0
456468
fi
@@ -463,7 +475,11 @@ setup_node_manager() {
463475
read -r response < /dev/tty
464476

465477
if [ -z "$response" ] || [ "$response" = "y" ] || [ "$response" = "Y" ]; then
466-
"$vp_bin" env setup --refresh > /dev/null
478+
local setup_output
479+
if ! setup_output=$("$vp_bin" env setup --refresh 2>&1); then
480+
warn "Failed to refresh shims:"
481+
echo "$setup_output" >&2
482+
fi
467483
NODE_MANAGER_ENABLED="true"
468484
fi
469485
fi

0 commit comments

Comments
 (0)