fix(core): rewrite rolldown native packages

Author: jong-kyung

packages/core/__tests__/build-artifacts.spec.ts

@@ -46,8 +46,14 @@ describe('build artifacts', () => {
     ]);
   });
 
-  it('declares Vite+ native packages as core optional dependencies', () => {
-    for (const packageName of getNativePlatformPackageNames(cliPkgJson.napi.targets)) {
+  it('declares only generated Vite+ native packages as core optional dependencies', () => {
+    const packageNames = getNativePlatformPackageNames(cliPkgJson.napi.targets);
+    const nativeOptionalDependencyNames = Object.keys(corePkgJson.optionalDependencies).filter((name) =>
+      name.startsWith('@voidzero-dev/vite-plus-'),
+    );
+
+    expect(nativeOptionalDependencyNames.toSorted()).toEqual(packageNames.toSorted());
+    for (const packageName of packageNames) {
       expect(corePkgJson.optionalDependencies).toHaveProperty(packageName, corePkgJson.version);
     }
 

packages/core/build-support/native-platform-packages.ts

@@ -3,7 +3,7 @@ const archMap: Record<string, string> = {
   x86_64: 'x64',
 };
 
-function getNativePlatformPackageSuffix(target: string): string {
+export function getNativePlatformPackageName(target: string): string {
   const [archTarget, ...platformParts] = target.split('-');
   const arch = archMap[archTarget];
   const platform = platformParts.join('-');
@@ -13,25 +13,21 @@ function getNativePlatformPackageSuffix(target: string): string {
   }
 
   if (platform === 'apple-darwin') {
-    return `darwin-${arch}`;
+    return `@voidzero-dev/vite-plus-darwin-${arch}`;
   }
   if (platform === 'unknown-linux-gnu') {
-    return `linux-${arch}-gnu`;
+    return `@voidzero-dev/vite-plus-linux-${arch}-gnu`;
   }
   if (platform === 'unknown-linux-musl') {
-    return `linux-${arch}-musl`;
+    return `@voidzero-dev/vite-plus-linux-${arch}-musl`;
   }
   if (platform === 'pc-windows-msvc') {
-    return `win32-${arch}-msvc`;
+    return `@voidzero-dev/vite-plus-win32-${arch}-msvc`;
   }
 
   throw new Error(`Unsupported NAPI target platform: ${target}`);
 }
 
-export function getNativePlatformPackageName(target: string): string {
-  return `@voidzero-dev/vite-plus-${getNativePlatformPackageSuffix(target)}`;
-}
-
 export function getNativePlatformPackageNames(targets: string[]): string[] {
   return targets.map(getNativePlatformPackageName);
 }

packages/core/build.ts

@@ -372,6 +372,8 @@ async function bundleRolldown() {
     },
   });
 
+  const vitePlusNativePackages = new Set(getNativePlatformPackageNames(cliPkgJson.napi.targets));
+
   // Rewrite @rolldown/pluginutils imports in JS and type declaration files
   for (const file of rolldownFiles) {
     if (
@@ -388,8 +390,10 @@ async function bundleRolldown() {
             with: { type: 'json' },
           })
         ).default.version;
-        // @rolldown/binding-darwin-arm64 → @voidzero-dev/vite-plus-darwin-arm64/binding
-        source = source.replace(/@rolldown\/binding-([a-z0-9-]+)/g, 'vite-plus/binding');
+        source = source.replace(/@rolldown\/binding-([a-z0-9-]+)/g, (specifier, suffix) => {
+          const packageName = `@voidzero-dev/vite-plus-${suffix}`;
+          return vitePlusNativePackages.has(packageName) ? packageName : specifier;
+        });
         source = source.replaceAll(`${rolldownBindingVersion}`, pkgJson.version);
       }
       const newSource = rewriteModuleSpecifiers(source, file, { rules });