Skip to content

Commit 84380a4

Browse files
committed
docs(rust-toolchain): explain why the pinned nightly date matters
The existing comment justifies using nightly at all (Z-bindeps and windows_process_extensions_main_thread_handle), but a future `feat(deps): upgrade upstream dependencies` PR bumps the date and nobody remembers why. Add a note that the date itself is gated by oxc_transformer >=0.130 using `if let` guards, which only stabilized in rustc 1.94 (2026-01-29) — earlier nightlies fail with E0658.
1 parent 289dc52 commit 84380a4

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

rust-toolchain.toml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,13 @@
22
# Needed nightly features:
33
# - cargo `Z-bindeps` to build and embed preload shared libraries as dependencies of fspy
44
# - `windows_process_extensions_main_thread_handle` to get the main thread handle for Detours injection
5+
#
6+
# Why this date in particular:
7+
# - oxc_transformer (>=0.130) uses `if let` guards inside match arms (`if_let_guard`,
8+
# rust-lang/rust#51114). That feature stabilized in rustc 1.94 (released 2026-01-29),
9+
# so any nightly from late January 2026 onward compiles it. Earlier pins (e.g.
10+
# nightly-2025-12-11) hit E0658 during `cargo clippy --all-features`.
11+
# Bump in lockstep with upstream oxc/rolldown updates; pick any nightly past the
12+
# stabilization date for the features the new versions use.
513
channel = "nightly-2026-03-15"
614
profile = "default"

0 commit comments

Comments
 (0)