Merge branch 'main' into fix-cli-create-fmt-call

Author: fengmk2

.github/workflows/ci.yml

@@ -23,8 +23,21 @@ defaults:
     shell: bash
 
 jobs:
+  optimize-ci:
+    runs-on: ubuntu-latest # or whichever runner you use for your CI
+    outputs:
+      skip: ${{ steps.check_skip.outputs.skip }}
+    steps:
+      - name: Optimize CI
+        id: check_skip
+        uses: withgraphite/graphite-ci-action@ee395f3a78254c006d11339669c6cabddf196f72
+        with:
+          graphite_token: ${{ secrets.GRAPHITE_CI_OPTIMIZER_TOKEN }}
+
   detect-changes:
     runs-on: ubuntu-latest
+    needs: optimize-ci
+    if: needs.optimize-ci.outputs.skip == 'false'
     permissions:
       contents: read
       pull-requests: read

packages/cli/snap-tests/bin-oxlint-wrapper/snap.txt

@@ -16,9 +16,10 @@ Basic Configuration
                               running via Node.js
                               * you can use comments in configuration files.
                               * tries to be compatible with ESLint v8's format
-        --tsconfig=<./tsconfig.json>  TypeScript `tsconfig.json` path for reading path alias and
-                              project references for import plugin. If not provided, will look for
-                              `tsconfig.json` in the current working directory.
+        --tsconfig=<./tsconfig.json>  Override the TypeScript config used for import resolution.
+                              Oxlint automatically discovers the relevant `tsconfig.json` for each
+                              file. Use this only when your project uses a non-standard tsconfig
+                              name or location.
         --init                Initialize oxlint configuration with default values
 
 Allowing / Denying Multiple Lints
@@ -42,9 +43,7 @@ Enable/Disable Plugins
         --disable-unicorn-plugin  Disable unicorn plugin, which is turned on by default
         --disable-oxc-plugin  Disable oxc unique rules, which is turned on by default
         --disable-typescript-plugin  Disable TypeScript plugin, which is turned on by default
-        --import-plugin       Enable import plugin and detect ESM problems. It should be used with
-                              the `--tsconfig` flag if your project has a tsconfig with a name other
-                              than `tsconfig.json`.
+        --import-plugin       Enable import plugin and detect ESM problems.
         --react-plugin        Enable react plugin, which is turned off by default
         --jsdoc-plugin        Enable jsdoc plugin and detect JSDoc problems
         --jest-plugin         Enable the Jest plugin and detect test problems

packages/cli/snap-tests/check-fix-missing-stderr/snap.txt

@@ -2,6 +2,7 @@
 error: Formatting could not complete
 Failed to load configuration file.
 <cwd>/vite.config.ts
+Error: The `fmt` field in the default export must be an object.
 Ensure the file has a valid default export of a JSON-serializable configuration object.
 
 Formatting failed during fix
@@ -10,6 +11,7 @@ Formatting failed during fix
 error: Formatting could not start
 Failed to load configuration file.
 <cwd>/vite.config.ts
+Error: The `fmt` field in the default export must be an object.
 Ensure the file has a valid default export of a JSON-serializable configuration object.
 
 Formatting failed before analysis started

packages/cli/snap-tests/command-helper/snap.txt

@@ -127,9 +127,10 @@ Basic Configuration
                               running via Node.js
                               * you can use comments in configuration files.
                               * tries to be compatible with ESLint v8's format
-        --tsconfig=<./tsconfig.json>  TypeScript `tsconfig.json` path for reading path alias and
-                              project references for import plugin. If not provided, will look for
-                              `tsconfig.json` in the current working directory.
+        --tsconfig=<./tsconfig.json>  Override the TypeScript config used for import resolution.
+                              Oxlint automatically discovers the relevant `tsconfig.json` for each
+                              file. Use this only when your project uses a non-standard tsconfig
+                              name or location.
         --init                Initialize oxlint configuration with default values
 
 Allowing / Denying Multiple Lints
@@ -153,9 +154,7 @@ Enable/Disable Plugins
         --disable-unicorn-plugin  Disable unicorn plugin, which is turned on by default
         --disable-oxc-plugin  Disable oxc unique rules, which is turned on by default
         --disable-typescript-plugin  Disable TypeScript plugin, which is turned on by default
-        --import-plugin       Enable import plugin and detect ESM problems. It should be used with
-                              the `--tsconfig` flag if your project has a tsconfig with a name other
-                              than `tsconfig.json`.
+        --import-plugin       Enable import plugin and detect ESM problems.
         --react-plugin        Enable react plugin, which is turned off by default
         --jsdoc-plugin        Enable jsdoc plugin and detect JSDoc problems
         --jest-plugin         Enable the Jest plugin and detect test problems

packages/cli/src/create/__tests__/utils.spec.ts

@@ -17,7 +17,8 @@ describe('formatTargetDir', () => {
     expect(formatTargetDir('../../foo/bar')).matchSnapshot();
   });
 
-  it.skipIf(process.platform === 'win32')('should format target dir with valid input', () => {
+  // Should work on all platforms (including Windows) - directory must always use forward slashes
+  it('should format target dir with valid input', () => {
     expect(formatTargetDir('./my-package')).matchSnapshot();
     expect(formatTargetDir('my-package')).matchSnapshot();
     expect(formatTargetDir('@my-scope/my-package')).matchSnapshot();
@@ -28,6 +29,17 @@ describe('formatTargetDir', () => {
     expect(formatTargetDir('./foo/bar/@scope/my-package/sub-package')).matchSnapshot();
   });
 
+  // Regression test for https://github.com/voidzero-dev/vite-plus/issues/938
+  // On Windows, path.join/normalize produce backslashes which break when passed as CLI args.
+  // Nested paths are the critical cases since they involve path separators.
+  it('should always use forward slashes in directory (issue #938)', () => {
+    expect(formatTargetDir('foo/@my-scope/my-package').directory).toBe('foo/my-package');
+    expect(formatTargetDir('./foo/bar/@scope/my-package').directory).toBe('foo/bar/my-package');
+    expect(formatTargetDir('./foo/bar/@scope/my-package/sub-package').directory).toBe(
+      'foo/bar/@scope/my-package/sub-package',
+    );
+  });
+
   it('should format target dir with invalid package name', () => {
     expect(formatTargetDir('my-package@').error).matchSnapshot();
     expect(formatTargetDir('my-package@1.0.0').error).matchSnapshot();

packages/cli/src/create/bin.ts

@@ -584,7 +584,7 @@ Use \`vp create --list\` to list all available templates, or run \`vp create --h
       const selected = await promptPackageNameAndTargetDir(defaultPackageName, options.interactive);
       packageName = selected.packageName;
       targetDir = selectedParentDir
-        ? path.join(selectedParentDir, selected.targetDir)
+        ? path.join(selectedParentDir, selected.targetDir).split(path.sep).join('/')
         : selected.targetDir;
     }
   }
@@ -782,7 +782,7 @@ Use \`vp create --list\` to list all available templates, or run \`vp create --h
       const selected = await promptPackageNameAndTargetDir(defaultPackageName, options.interactive);
       packageName = selected.packageName;
       targetDir = templateInfo.parentDir
-        ? path.join(templateInfo.parentDir, selected.targetDir)
+        ? path.join(templateInfo.parentDir, selected.targetDir).split(path.sep).join('/')
         : selected.targetDir;
     }
     pauseCreateProgress();

packages/cli/src/create/utils.ts

@@ -85,7 +85,7 @@ export function formatTargetDir(input: string): {
       error: `Parsed package name "${packageName}" is invalid: ${message}`,
     };
   }
-  return { directory: targetDir, packageName };
+  return { directory: targetDir.split(path.sep).join('/'), packageName };
 }
 
 // Get the project directory from the project name

packages/core/package.json

@@ -115,7 +115,7 @@
     "@babel/types": "^7.28.5",
     "@oxc-node/cli": "catalog:",
     "@oxc-node/core": "catalog:",
-    "@vitejs/devtools": "^0.1.0",
+    "@vitejs/devtools": "^0.1.2",
     "es-module-lexer": "^1.7.0",
     "hookable": "^6.0.1",
     "magic-string": "^0.30.21",
@@ -136,8 +136,8 @@
   },
   "peerDependencies": {
     "@arethetypeswrong/core": "^0.18.1",
-    "@tsdown/css": "0.21.3",
-    "@tsdown/exe": "0.21.3",
+    "@tsdown/css": "0.21.4",
+    "@tsdown/exe": "0.21.4",
     "@types/node": "^20.19.0 || >=22.12.0",
     "@vitejs/devtools": "^0.0.0-alpha.31",
     "esbuild": "^0.27.0",
@@ -219,6 +219,6 @@
   "bundledVersions": {
     "vite": "8.0.0",
     "rolldown": "1.0.0-rc.9",
-    "tsdown": "0.21.3"
+    "tsdown": "0.21.4"
   }
 }