style: fix clippy needless-pass-by-ref-mut

Author: Brooooooklyn

crates/fspy/src/unix/mod.rs

@@ -175,7 +175,7 @@ pub(crate) async fn spawn_impl(mut command: Command) -> io::Result<TrackedChild>
     let supervisor = supervise::<SyscallHandler>()?;
 
     #[cfg(target_os = "linux")]
-    let mut supervisor_pre_exec = supervisor.pre_exec;
+    let supervisor_pre_exec = supervisor.pre_exec;
 
     let payload = Payload {
         ipc_fd: shm_fd_sender.as_raw_fd(),
@@ -201,7 +201,7 @@ pub(crate) async fn spawn_impl(mut command: Command) -> io::Result<TrackedChild>
 
     let mut exec = command.get_exec();
     let mut exec_resolve_accesses = PathAccessArena::default();
-    let mut pre_exec = handle_exec(
+    let pre_exec = handle_exec(
         &mut exec,
         ExecResolveConfig::search_path_enabled(None),
         &encoded_payload,
@@ -221,7 +221,7 @@ pub(crate) async fn spawn_impl(mut command: Command) -> io::Result<TrackedChild>
 
             #[cfg(target_os = "linux")]
             supervisor_pre_exec.run()?;
-            if let Some(pre_exec) = &mut pre_exec {
+            if let Some(pre_exec) = pre_exec.as_ref() {
                 pre_exec.run()?;
             }
             Ok(())

crates/fspy_preload_unix/src/interceptions/spawn/exec/mod.rs

@@ -35,7 +35,7 @@ fn handle_exec(
         global_client().expect("exec unexpectedly called before client initialized in ctor");
     let result = unsafe {
         client.handle_exec(config, RawExec { prog, argv, envp }, |raw_command, pre_exec| {
-            if let Some(mut pre_exec) = pre_exec {
+            if let Some(pre_exec) = pre_exec {
                 pre_exec.run()?
             };
             Ok(execve::original()(raw_command.prog, raw_command.argv, raw_command.envp))

crates/fspy_preload_unix/src/interceptions/spawn/posix_spawn.rs

@@ -51,7 +51,7 @@ unsafe fn handle_posix_spawn(
                         raw_command.envp.cast(),
                     )
                 };
-                if let Some(mut pre_exec) = pre_exec {
+                if let Some(pre_exec) = pre_exec {
                     thread::scope(move |s| {
                         let call_original = AssertSend(call_original);
                         s.spawn(move || {

crates/fspy_seccomp_unotify/src/supervisor/mod.rs

@@ -27,7 +27,7 @@ pub struct Supervisor<F> {
 
 pub struct PreExec(OwnedFd);
 impl PreExec {
-    pub fn run(&mut self) -> nix::Result<()> {
+    pub fn run(&self) -> nix::Result<()> {
         let mut fd_flag = FdFlag::from_bits_retain(fcntl(&self.0, FcntlArg::F_GETFD)?);
         fd_flag.remove(FdFlag::FD_CLOEXEC);
         fcntl(&self.0, FcntlArg::F_SETFD(fd_flag))?;

crates/fspy_seccomp_unotify/tests/arg_types.rs

@@ -52,7 +52,7 @@ async fn run_in_pre_exec(
 ) -> Result<Vec<Syscall>, Box<dyn Error>> {
     Ok(timeout(Duration::from_secs(5), async move {
         let mut cmd = Command::new("/bin/echo");
-        let Supervisor { payload, handling_loop, mut pre_exec } = supervise::<SyscallRecorder>()?;
+        let Supervisor { payload, handling_loop, pre_exec } = supervise::<SyscallRecorder>()?;
 
         unsafe {
             cmd.pre_exec(move || {

crates/fspy_shared_unix/src/spawn/linux/mod.rs

@@ -15,7 +15,7 @@ const LD_PRELOAD: &str = "LD_PRELOAD";
 
 pub struct PreExec(SeccompPayload);
 impl PreExec {
-    pub fn run(&mut self) -> nix::Result<()> {
+    pub fn run(&self) -> nix::Result<()> {
         install_target(&self.0)
     }
 }

crates/fspy_shared_unix/src/spawn/macos.rs

@@ -15,7 +15,7 @@ use crate::{
 
 pub struct PreExec(Infallible);
 impl PreExec {
-    pub fn run(&mut self) -> nix::Result<()> {
+    pub fn run(&self) -> nix::Result<()> {
         match self.0 {}
     }
 }

crates/vite_task/src/cache.rs

@@ -127,7 +127,7 @@ impl TaskCache {
     }
 
     pub async fn update(
-        &mut self,
+        &self,
         resolved_task: &ResolvedTask,
         cached_task: CommandCacheValue,
     ) -> Result<(), Error> {

crates/vite_task/src/doc.rs

@@ -10,7 +10,7 @@ use crate::{
 
 pub async fn doc<Doc: Future<Output = Result<ResolveCommandResult, Error>>, DocFn: Fn() -> Doc>(
     resolve_doc_command: DocFn,
-    workspace: &mut Workspace,
+    workspace: &Workspace,
     args: &Vec<String>,
 ) -> Result<ExecutionSummary, Error> {
     let resolved_task =

crates/vite_task/src/fmt.rs

@@ -18,7 +18,7 @@ pub struct FmtConfig {
 #[tracing::instrument(skip(resolve_fmt_command, workspace))]
 pub async fn fmt<Fmt: Future<Output = Result<ResolveCommandResult, Error>>, FmtFn: Fn() -> Fmt>(
     resolve_fmt_command: FmtFn,
-    workspace: &mut Workspace,
+    workspace: &Workspace,
     args: &Vec<String>,
 ) -> Result<ExecutionSummary, Error> {
     let resolved_task =