Commit 96567b6
committed
fix(ci): work around rolldown@1.0.1 binding tokio panic
The npm-published rolldown@1.0.1 binding enables the mimalloc v3
feature (`crates/rolldown_binding/Cargo.toml` rolldown#9349), which
panics with `[internal exception] blocking task ran twice` in tokio
when tsdown drives rolldown through vp pack on darwin-arm64. The
result is that vp pack exits silently after "Build start", which
breaks every CLI snap test that bundles via vp pack (command-pack,
command-pack-exe, command-pack-external, command-pack-monorepo,
vp-cache-monorepo-missing, vp-pack-cache-disabled).
Force the binding download to use rolldown@1.0.0 while keeping the
1.0.1 JS sources (and the pluginutils relocation that depends on
them). The 1.0.0 binding is ABI-compatible with the surface vite-plus
exercises through tsdown/rolldown. Revert once an upstream rolldown
release ships without mimalloc v3 or fixes the panic.
The command-staged-broken-config snap.txt also rolls back to its
pre-PR form because the diagnostic prefix comes from the binding's
bundled oxc — `Error: Unexpected token` (1.0.0/oxc 0.128) vs.
`Unexpected token` (1.0.1/oxc 0.130).1 parent 8976c24 commit 96567b6
2 files changed
Lines changed: 10 additions & 1 deletion
File tree
- .github/actions/download-rolldown-binaries
- packages/cli/snap-tests-global/command-staged-broken-config
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
45 | 54 | | |
46 | 55 | | |
47 | 56 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
0 commit comments