refactor(hooks): extract shared promptGitHooks and clean up

- Extract duplicate `promptGitHooks()` from create/bin.ts and
  migration/bin.ts into utils/prompts.ts with a minimal interface
- Remove trivial `assert!(true)` tests from prepare.rs and lint_staged.rs
- Use `readJsonFile()` instead of raw `JSON.parse(fs.readFileSync())`
  in setupGitHooks for consistency

Author: fengmk2

crates/vite_global_cli/src/commands/lint_staged.rs

@@ -10,12 +10,3 @@ use crate::error::Error;
 pub async fn execute(cwd: AbsolutePathBuf, args: &[String]) -> Result<ExitStatus, Error> {
     super::delegate::execute(cwd, "lint-staged", args).await
 }
-
-#[cfg(test)]
-mod tests {
-    #[test]
-    fn test_lint_staged_command_module_exists() {
-        // Basic test to ensure the module compiles
-        assert!(true);
-    }
-}

crates/vite_global_cli/src/commands/prepare.rs

@@ -10,12 +10,3 @@ use crate::error::Error;
 pub async fn execute(cwd: AbsolutePathBuf, args: &[String]) -> Result<ExitStatus, Error> {
     super::delegate::execute(cwd, "prepare", args).await
 }
-
-#[cfg(test)]
-mod tests {
-    #[test]
-    fn test_prepare_command_module_exists() {
-        // Basic test to ensure the module compiles
-        assert!(true);
-    }
-}

packages/cli/src/create/bin.ts

@@ -21,6 +21,7 @@ import { displayRelative } from '../utils/path.js';
 import {
   defaultInteractive,
   downloadPackageManager,
+  promptGitHooks,
   runViteInstall,
   selectPackageManager,
 } from '../utils/prompts.js';
@@ -70,7 +71,10 @@ const helpMessage = renderCliDoc({
           label: '--agent NAME',
           description: 'Create an agent instructions file for the specified agent.',
         },
-        { label: '--hooks', description: 'Set up pre-commit hooks (default in non-interactive mode)' },
+        {
+          label: '--hooks',
+          description: 'Set up pre-commit hooks (default in non-interactive mode)',
+        },
         { label: '--no-hooks', description: 'Skip pre-commit hooks setup' },
         { label: '--no-interactive', description: 'Run in non-interactive mode' },
         { label: '--list', description: 'List all available templates' },
@@ -694,27 +698,6 @@ async function showAvailableTemplates() {
   log(listTemplatesMessage);
 }
 
-async function promptGitHooks(options: Options): Promise<boolean> {
-  if (options.hooks === false) {
-    return false;
-  }
-  if (options.hooks === true) {
-    return true;
-  }
-  if (options.interactive) {
-    const selected = await prompts.confirm({
-      message: 'Set up pre-commit hooks to run format, lint, and type checks with auto-fix?',
-      initialValue: true,
-    });
-    if (prompts.isCancel(selected)) {
-      cancelAndExit();
-      return false;
-    }
-    return selected;
-  }
-  return true; // non-interactive default
-}
-
 main().catch((err) => {
   prompts.log.error(err.message);
   console.error(err);

packages/cli/src/migration/bin.ts

@@ -14,6 +14,7 @@ import {
   cancelAndExit,
   defaultInteractive,
   downloadPackageManager,
+  promptGitHooks,
   runViteInstall,
   selectPackageManager,
   upgradeYarn,
@@ -246,27 +247,6 @@ async function main() {
   prompts.outro(green('✔ Migration completed!'));
 }
 
-async function promptGitHooks(options: MigrationOptions): Promise<boolean> {
-  if (options.hooks === false) {
-    return false;
-  }
-  if (options.hooks === true) {
-    return true;
-  }
-  if (options.interactive) {
-    const selected = await prompts.confirm({
-      message: 'Set up pre-commit hooks to run format, lint, and type checks with auto-fix?',
-      initialValue: true,
-    });
-    if (prompts.isCancel(selected)) {
-      cancelAndExit();
-      return false;
-    }
-    return selected;
-  }
-  return true; // non-interactive default
-}
-
 main().catch((err) => {
   prompts.log.error(err.message);
   console.error(err);

packages/cli/src/migration/migrator.ts

@@ -19,7 +19,7 @@ import {
   VITE_PLUS_OVERRIDE_PACKAGES,
   VITE_PLUS_VERSION,
 } from '../utils/constants.js';
-import { editJsonFile, isJsonFile } from '../utils/json.js';
+import { editJsonFile, isJsonFile, readJsonFile } from '../utils/json.js';
 import { detectPackageMetadata } from '../utils/package.js';
 import { displayRelative, rulesDir } from '../utils/path.js';
 import { editYamlFile, scalarString, type YamlDocument } from '../utils/yaml.js';
@@ -662,11 +662,12 @@ export function setupGitHooks(projectPath: string): void {
     return;
   }
 
-  const pkgContent = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
-
   // Check for other hook tools → warn and skip
+  const pkgContent = readJsonFile(packageJsonPath);
   for (const tool of OTHER_HOOK_TOOLS) {
-    if (pkgContent.devDependencies?.[tool] || pkgContent.dependencies?.[tool] || pkgContent[tool]) {
+    const deps = pkgContent.devDependencies as Record<string, string> | undefined;
+    const prodDeps = pkgContent.dependencies as Record<string, string> | undefined;
+    if (deps?.[tool] || prodDeps?.[tool] || pkgContent[tool]) {
       prompts.log.warn(
         `⚠ Detected ${tool} — skipping git hooks setup. Please configure git hooks manually.`,
       );

packages/cli/src/utils/prompts.ts

@@ -91,6 +91,30 @@ export async function upgradeYarn(cwd: string, interactive?: boolean) {
   }
 }
 
+export async function promptGitHooks(options: {
+  hooks?: boolean;
+  interactive: boolean;
+}): Promise<boolean> {
+  if (options.hooks === false) {
+    return false;
+  }
+  if (options.hooks === true) {
+    return true;
+  }
+  if (options.interactive) {
+    const selected = await prompts.confirm({
+      message: 'Set up pre-commit hooks to run format, lint, and type checks with auto-fix?',
+      initialValue: true,
+    });
+    if (prompts.isCancel(selected)) {
+      cancelAndExit();
+      return false;
+    }
+    return selected;
+  }
+  return true; // non-interactive default
+}
+
 export function defaultInteractive() {
   // If CI environment, use non-interactive mode by default
   return !process.env.CI && process.stdin.isTTY;